Skip to content

Implement APIGW Inferred Proxy Spans #9154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 10 commits into
base: master
Choose a base branch
from
Draft

Implement APIGW Inferred Proxy Spans #9154

wants to merge 10 commits into from

Conversation

zarirhamza
Copy link
Contributor

@zarirhamza zarirhamza commented Jul 11, 2025 •
edited
Loading

What Does This Do

Adds an inferred proxy span as the parent of http request spans if http headers with x-dd-proxy are detected

Motivation

We want to have observability of router/ proxy services like AWS API Gateway, that redirect client calls to various targets. There is distinct http header metadata available to us from http requests that can allow us to "infer" the presence of these proxy services.

Additional Notes

  • Confirm implementation
  • Add tests
  • Check telemetry
  • Update system tests

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@zarirhamza zarirhamza added this to the 1.52.0 milestone Jul 11, 2025
@zarirhamza zarirhamza requested review from a team as code owners July 11, 2025 02:05
@zarirhamza zarirhamza requested a review from amarziali July 11, 2025 02:05
@zarirhamza zarirhamza marked this pull request as draft July 11, 2025 02:05
@pr-commenter
Copy link

pr-commenter bot commented Jul 11, 2025 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master zarir/apigw
git_commit_date 1752586391 1752593245
git_commit_sha b86f4f7 02d23f8
release_version 1.52.0-SNAPSHOT~b86f4f70d6 1.52.0-SNAPSHOT~02d23f8591
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1752595077 1752595077
ci_job_id 1029525231 1029525231
ci_pipeline_id 70596267 70596267
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-03ar7p3x 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-03ar7p3x 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 44 metrics, 9 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.52.0-SNAPSHOT~02d23f8591, baseline=1.52.0-SNAPSHOT~b86f4f70d6

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (992.999 ms) : 0, 992999
Total [baseline] (8.586 s) : 0, 8585854
Agent [candidate] (995.503 ms) : 0, 995503
Total [candidate] (8.63 s) : 0, 8630321
section iast
Agent [baseline] (1.139 s) : 0, 1139482
Total [baseline] (9.357 s) : 0, 9357349
Agent [candidate] (1.132 s) : 0, 1132214
Total [candidate] (9.356 s) : 0, 9355581
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 992.999 ms -
Agent iast 1.139 s 146.483 ms (14.8%)
Total tracing 8.586 s -
Total iast 9.357 s 771.495 ms (9.0%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 995.503 ms -
Agent iast 1.132 s 136.711 ms (13.7%)
Total tracing 8.63 s -
Total iast 9.356 s 725.26 ms (8.4%) 
gantt
    title insecure-bank - break down per module: candidate=1.52.0-SNAPSHOT~02d23f8591, baseline=1.52.0-SNAPSHOT~b86f4f70d6

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (684.977 ms) : 0, 684977
BytebuddyAgent [candidate] (686.493 ms) : 0, 686493
GlobalTracer [baseline] (241.962 ms) : 0, 241962
GlobalTracer [candidate] (242.878 ms) : 0, 242878
AppSec [baseline] (30.393 ms) : 0, 30393
AppSec [candidate] (30.382 ms) : 0, 30382
Debugger [baseline] (5.965 ms) : 0, 5965
Debugger [candidate] (6.02 ms) : 0, 6020
Remote Config [baseline] (683.13 µs) : 0, 683
Remote Config [candidate] (678.068 µs) : 0, 678
Telemetry [baseline] (8.255 ms) : 0, 8255
Telemetry [candidate] (8.224 ms) : 0, 8224
section iast
BytebuddyAgent [baseline] (810.082 ms) : 0, 810082
BytebuddyAgent [candidate] (805.802 ms) : 0, 805802
GlobalTracer [baseline] (235.06 ms) : 0, 235060
GlobalTracer [candidate] (233.136 ms) : 0, 233136
IAST [baseline] (30.31 ms) : 0, 30310
IAST [candidate] (29.9 ms) : 0, 29900
AppSec [baseline] (27.959 ms) : 0, 27959
AppSec [candidate] (27.431 ms) : 0, 27431
Debugger [baseline] (5.85 ms) : 0, 5850
Debugger [candidate] (6.609 ms) : 0, 6609
Remote Config [baseline] (593.088 µs) : 0, 593
Remote Config [candidate] (576.763 µs) : 0, 577
Telemetry [baseline] (8.097 ms) : 0, 8097
Telemetry [candidate] (7.895 ms) : 0, 7895
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.52.0-SNAPSHOT~02d23f8591, baseline=1.52.0-SNAPSHOT~b86f4f70d6

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.001 s) : 0, 1001340
Total [baseline] (10.627 s) : 0, 10626621
Agent [candidate] (994.313 ms) : 0, 994313
Total [candidate] (10.623 s) : 0, 10622932
section appsec
Agent [baseline] (1.174 s) : 0, 1173753
Total [baseline] (10.763 s) : 0, 10762871
Agent [candidate] (1.175 s) : 0, 1175355
Total [candidate] (10.77 s) : 0, 10770370
section iast
Agent [baseline] (1.131 s) : 0, 1130890
Total [baseline] (10.827 s) : 0, 10827157
Agent [candidate] (1.132 s) : 0, 1131678
Total [candidate] (10.85 s) : 0, 10850271
section profiling
Agent [baseline] (1.248 s) : 0, 1247905
Total [baseline] (10.947 s) : 0, 10946898
Agent [candidate] (1.245 s) : 0, 1245448
Total [candidate] (10.907 s) : 0, 10906825
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.001 s -
Agent appsec 1.174 s 172.413 ms (17.2%)
Agent iast 1.131 s 129.55 ms (12.9%)
Agent profiling 1.248 s 246.565 ms (24.6%)
Total tracing 10.627 s -
Total appsec 10.763 s 136.251 ms (1.3%)
Total iast 10.827 s 200.537 ms (1.9%)
Total profiling 10.947 s 320.278 ms (3.0%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 994.313 ms -
Agent appsec 1.175 s 181.042 ms (18.2%)
Agent iast 1.132 s 137.365 ms (13.8%)
Agent profiling 1.245 s 251.134 ms (25.3%)
Total tracing 10.623 s -
Total appsec 10.77 s 147.438 ms (1.4%)
Total iast 10.85 s 227.338 ms (2.1%)
Total profiling 10.907 s 283.893 ms (2.7%) 
gantt
    title petclinic - break down per module: candidate=1.52.0-SNAPSHOT~02d23f8591, baseline=1.52.0-SNAPSHOT~b86f4f70d6

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (690.429 ms) : 0, 690429
BytebuddyAgent [candidate] (685.368 ms) : 0, 685368
GlobalTracer [baseline] (244.12 ms) : 0, 244120
GlobalTracer [candidate] (242.711 ms) : 0, 242711
AppSec [baseline] (30.74 ms) : 0, 30740
AppSec [candidate] (30.386 ms) : 0, 30386
Debugger [baseline] (6.058 ms) : 0, 6058
Debugger [candidate] (5.975 ms) : 0, 5975
Remote Config [baseline] (685.039 µs) : 0, 685
Remote Config [candidate] (673.213 µs) : 0, 673
Telemetry [baseline] (8.317 ms) : 0, 8317
Telemetry [candidate] (8.274 ms) : 0, 8274
section appsec
BytebuddyAgent [baseline] (708.324 ms) : 0, 708324
BytebuddyAgent [candidate] (708.984 ms) : 0, 708984
GlobalTracer [baseline] (235.199 ms) : 0, 235199
GlobalTracer [candidate] (235.731 ms) : 0, 235731
IAST [baseline] (23.533 ms) : 0, 23533
IAST [candidate] (23.579 ms) : 0, 23579
AppSec [baseline] (171.313 ms) : 0, 171313
AppSec [candidate] (171.754 ms) : 0, 171754
Debugger [baseline] (5.797 ms) : 0, 5797
Debugger [candidate] (5.737 ms) : 0, 5737
Remote Config [baseline] (607.257 µs) : 0, 607
Remote Config [candidate] (602.556 µs) : 0, 603
Telemetry [baseline] (8.117 ms) : 0, 8117
Telemetry [candidate] (7.998 ms) : 0, 7998
section iast
BytebuddyAgent [baseline] (805.264 ms) : 0, 805264
BytebuddyAgent [candidate] (805.32 ms) : 0, 805320
GlobalTracer [baseline] (232.695 ms) : 0, 232695
GlobalTracer [candidate] (232.974 ms) : 0, 232974
IAST [baseline] (25.692 ms) : 0, 25692
IAST [candidate] (27.297 ms) : 0, 27297
AppSec [baseline] (32.065 ms) : 0, 32065
AppSec [candidate] (30.055 ms) : 0, 30055
Debugger [baseline] (5.726 ms) : 0, 5726
Debugger [candidate] (6.606 ms) : 0, 6606
Remote Config [baseline] (577.557 µs) : 0, 578
Remote Config [candidate] (586.302 µs) : 0, 586
Telemetry [baseline] (7.928 ms) : 0, 7928
Telemetry [candidate] (7.937 ms) : 0, 7937
section profiling
BytebuddyAgent [baseline] (678.928 ms) : 0, 678928
BytebuddyAgent [candidate] (677.562 ms) : 0, 677562
GlobalTracer [baseline] (362.623 ms) : 0, 362623
GlobalTracer [candidate] (362.388 ms) : 0, 362388
AppSec [baseline] (32.131 ms) : 0, 32131
AppSec [candidate] (32.617 ms) : 0, 32617
Debugger [baseline] (12.186 ms) : 0, 12186
Debugger [candidate] (10.536 ms) : 0, 10536
Remote Config [baseline] (659.297 µs) : 0, 659
Remote Config [candidate] (665.461 µs) : 0, 665
Telemetry [baseline] (8.03 ms) : 0, 8030
Telemetry [candidate] (9.499 ms) : 0, 9499
ProfilingAgent [baseline] (103.802 ms) : 0, 103802
ProfilingAgent [candidate] (103.459 ms) : 0, 103459
Profiling [baseline] (103.826 ms) : 0, 103826
Profiling [candidate] (103.486 ms) : 0, 103486
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master zarir/apigw
git_commit_date 1752586391 1752593245
git_commit_sha b86f4f7 02d23f8
release_version 1.52.0-SNAPSHOT~b86f4f70d6 1.52.0-SNAPSHOT~02d23f8591
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1752594753 1752594753
ci_job_id 1029525232 1029525232
ci_pipeline_id 70596267 70596267
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-rsmxjfbc 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-rsmxjfbc 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 2 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 12 unstable metrics.

scenario Δ mean http_req_duration Δ mean throughput candidate mean http_req_duration candidate mean throughput baseline mean http_req_duration baseline mean throughput
scenario:load:insecure-bank:profiling:high_load better
[-554.912µs; -263.773µs] or [-6.350%; -3.019%]		 unstable
[-38.223op/s; +91.285op/s] or [-7.203%; +17.203%]		 8.329ms 557.156op/s 8.738ms 530.625op/s
scenario:load:insecure-bank:iast_FULL:high_load better
[-1064.508µs; -470.943µs] or [-7.376%; -3.263%]		 unstable
[-14.852op/s; +50.664op/s] or [-4.600%; +15.692%]		 13.665ms 340.781op/s 14.433ms 322.875op/s
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.52.0-SNAPSHOT~02d23f8591, baseline=1.52.0-SNAPSHOT~b86f4f70d6
    dateFormat X
    axisFormat %s
section baseline
no_agent (4.309 ms) : 4260, 4358
.   : milestone, 4309,
iast (9.341 ms) : 9189, 9493
.   : milestone, 9341,
iast_FULL (14.433 ms) : 14151, 14714
.   : milestone, 14433,
iast_GLOBAL (10.596 ms) : 10409, 10782
.   : milestone, 10596,
profiling (8.738 ms) : 8603, 8873
.   : milestone, 8738,
tracing (7.474 ms) : 7362, 7586
.   : milestone, 7474,
section candidate
no_agent (4.436 ms) : 4386, 4485
.   : milestone, 4436,
iast (9.149 ms) : 8996, 9301
.   : milestone, 9149,
iast_FULL (13.665 ms) : 13395, 13935
.   : milestone, 13665,
iast_GLOBAL (10.722 ms) : 10533, 10911
.   : milestone, 10722,
profiling (8.329 ms) : 8194, 8464
.   : milestone, 8329,
tracing (7.548 ms) : 7443, 7652
.   : milestone, 7548,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 4.309 ms [4.26 ms, 4.358 ms] -
iast 9.341 ms [9.189 ms, 9.493 ms] 5.032 ms (116.8%)
iast_FULL 14.433 ms [14.151 ms, 14.714 ms] 10.124 ms (235.0%)
iast_GLOBAL 10.596 ms [10.409 ms, 10.782 ms] 6.287 ms (145.9%)
profiling 8.738 ms [8.603 ms, 8.873 ms] 4.429 ms (102.8%)
tracing 7.474 ms [7.362 ms, 7.586 ms] 3.165 ms (73.5%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 4.436 ms [4.386 ms, 4.485 ms] -
iast 9.149 ms [8.996 ms, 9.301 ms] 4.713 ms (106.3%)
iast_FULL 13.665 ms [13.395 ms, 13.935 ms] 9.229 ms (208.1%)
iast_GLOBAL 10.722 ms [10.533 ms, 10.911 ms] 6.287 ms (141.7%)
profiling 8.329 ms [8.194 ms, 8.464 ms] 3.893 ms (87.8%)
tracing 7.548 ms [7.443 ms, 7.652 ms] 3.112 ms (70.2%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.52.0-SNAPSHOT~02d23f8591, baseline=1.52.0-SNAPSHOT~b86f4f70d6
    dateFormat X
    axisFormat %s
section baseline
no_agent (36.966 ms) : 36672, 37261
.   : milestone, 36966,
appsec (47.655 ms) : 47239, 48071
.   : milestone, 47655,
code_origins (46.087 ms) : 45686, 46488
.   : milestone, 46087,
iast (43.383 ms) : 43013, 43753
.   : milestone, 43383,
profiling (49.48 ms) : 49006, 49955
.   : milestone, 49480,
tracing (43.866 ms) : 43486, 44245
.   : milestone, 43866,
section candidate
no_agent (37.066 ms) : 36767, 37365
.   : milestone, 37066,
appsec (46.66 ms) : 46235, 47086
.   : milestone, 46660,
code_origins (45.317 ms) : 44931, 45702
.   : milestone, 45317,
iast (43.898 ms) : 43506, 44291
.   : milestone, 43898,
profiling (49.657 ms) : 49191, 50123
.   : milestone, 49657,
tracing (43.04 ms) : 42665, 43416
.   : milestone, 43040,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 36.966 ms [36.672 ms, 37.261 ms] -
appsec 47.655 ms [47.239 ms, 48.071 ms] 10.689 ms (28.9%)
code_origins 46.087 ms [45.686 ms, 46.488 ms] 9.121 ms (24.7%)
iast 43.383 ms [43.013 ms, 43.753 ms] 6.417 ms (17.4%)
profiling 49.48 ms [49.006 ms, 49.955 ms] 12.514 ms (33.9%)
tracing 43.866 ms [43.486 ms, 44.245 ms] 6.899 ms (18.7%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 37.066 ms [36.767 ms, 37.365 ms] -
appsec 46.66 ms [46.235 ms, 47.086 ms] 9.594 ms (25.9%)
code_origins 45.317 ms [44.931 ms, 45.702 ms] 8.251 ms (22.3%)
iast 43.898 ms [43.506 ms, 44.291 ms] 6.832 ms (18.4%)
profiling 49.657 ms [49.191 ms, 50.123 ms] 12.591 ms (34.0%)
tracing 43.04 ms [42.665 ms, 43.416 ms] 5.975 ms (16.1%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master zarir/apigw
git_commit_date 1752586391 1752593245
git_commit_sha b86f4f7 02d23f8
release_version 1.52.0-SNAPSHOT~b86f4f70d6 1.52.0-SNAPSHOT~02d23f8591
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1752595165 1752595165
ci_job_id 1029525233 1029525233
ci_pipeline_id 70596267 70596267
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-oxtfpc9p 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-oxtfpc9p 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.52.0-SNAPSHOT~02d23f8591, baseline=1.52.0-SNAPSHOT~b86f4f70d6
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.486 ms) : 1474, 1498
.   : milestone, 1486,
appsec (2.421 ms) : 2371, 2470
.   : milestone, 2421,
iast (2.208 ms) : 2145, 2271
.   : milestone, 2208,
iast_GLOBAL (2.243 ms) : 2180, 2306
.   : milestone, 2243,
profiling (2.521 ms) : 2346, 2697
.   : milestone, 2521,
tracing (2.015 ms) : 1967, 2064
.   : milestone, 2015,
section candidate
no_agent (1.478 ms) : 1467, 1490
.   : milestone, 1478,
appsec (2.427 ms) : 2377, 2477
.   : milestone, 2427,
iast (2.217 ms) : 2154, 2279
.   : milestone, 2217,
iast_GLOBAL (2.245 ms) : 2182, 2308
.   : milestone, 2245,
profiling (2.515 ms) : 2339, 2691
.   : milestone, 2515,
tracing (2.03 ms) : 1982, 2079
.   : milestone, 2030,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.486 ms [1.474 ms, 1.498 ms] -
appsec 2.421 ms [2.371 ms, 2.47 ms] 934.616 µs (62.9%)
iast 2.208 ms [2.145 ms, 2.271 ms] 722.035 µs (48.6%)
iast_GLOBAL 2.243 ms [2.18 ms, 2.306 ms] 756.836 µs (50.9%)
profiling 2.521 ms [2.346 ms, 2.697 ms] 1.035 ms (69.7%)
tracing 2.015 ms [1.967 ms, 2.064 ms] 529.303 µs (35.6%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.478 ms [1.467 ms, 1.49 ms] -
appsec 2.427 ms [2.377 ms, 2.477 ms] 948.563 µs (64.2%)
iast 2.217 ms [2.154 ms, 2.279 ms] 738.221 µs (49.9%)
iast_GLOBAL 2.245 ms [2.182 ms, 2.308 ms] 766.871 µs (51.9%)
profiling 2.515 ms [2.339 ms, 2.691 ms] 1.037 ms (70.1%)
tracing 2.03 ms [1.982 ms, 2.079 ms] 551.861 µs (37.3%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.52.0-SNAPSHOT~02d23f8591, baseline=1.52.0-SNAPSHOT~b86f4f70d6
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.955 s) : 14955000, 14955000
.   : milestone, 14955000,
appsec (14.657 s) : 14657000, 14657000
.   : milestone, 14657000,
iast (18.65 s) : 18650000, 18650000
.   : milestone, 18650000,
iast_GLOBAL (18.25 s) : 18250000, 18250000
.   : milestone, 18250000,
profiling (15.077 s) : 15077000, 15077000
.   : milestone, 15077000,
tracing (14.762 s) : 14762000, 14762000
.   : milestone, 14762000,
section candidate
no_agent (15.202 s) : 15202000, 15202000
.   : milestone, 15202000,
appsec (14.646 s) : 14646000, 14646000
.   : milestone, 14646000,
iast (18.554 s) : 18554000, 18554000
.   : milestone, 18554000,
iast_GLOBAL (17.914 s) : 17914000, 17914000
.   : milestone, 17914000,
profiling (14.776 s) : 14776000, 14776000
.   : milestone, 14776000,
tracing (14.628 s) : 14628000, 14628000
.   : milestone, 14628000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.955 s [14.955 s, 14.955 s] -
appsec 14.657 s [14.657 s, 14.657 s] -298.0 ms (-2.0%)
iast 18.65 s [18.65 s, 18.65 s] 3.695 s (24.7%)
iast_GLOBAL 18.25 s [18.25 s, 18.25 s] 3.295 s (22.0%)
profiling 15.077 s [15.077 s, 15.077 s] 122.0 ms (0.8%)
tracing 14.762 s [14.762 s, 14.762 s] -193.0 ms (-1.3%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.202 s [15.202 s, 15.202 s] -
appsec 14.646 s [14.646 s, 14.646 s] -556.0 ms (-3.7%)
iast 18.554 s [18.554 s, 18.554 s] 3.352 s (22.0%)
iast_GLOBAL 17.914 s [17.914 s, 17.914 s] 2.712 s (17.8%)
profiling 14.776 s [14.776 s, 14.776 s] -426.0 ms (-2.8%)
tracing 14.628 s [14.628 s, 14.628 s] -574.0 ms (-3.8%)

@PerfectSlayer PerfectSlayer requested review from PerfectSlayer and removed request for amarziali July 11, 2025 05:56
@PerfectSlayer PerfectSlayer removed this from the 1.52.0 milestone Jul 11, 2025
PerfectSlayer
PerfectSlayer reviewed Jul 11, 2025
View reviewed changes
Copy link
Contributor

@PerfectSlayer PerfectSlayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Taking review over @amarziali as I already made the original reviews and started fixes in #8801.
Next step is to get rid of InferredProxySpanGroupDecorator and use context instead (it's basically a context to store two spans…).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PerfectSlayer PerfectSlayer PerfectSlayer left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
comp: context propagation Trace context propagation type: feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zarirhamza @PerfectSlayer @mhlidd