-
Notifications
You must be signed in to change notification settings - Fork 311
Add new org to Weaver instrumentation #9195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for opening this PR @majk-p! From what I've gathered by locally testing, I think some additional changes will be necessary in order to support TypeLevel releases too, as currently the instrumentation will break with them. Will get back to you as soon as I take a look 👍
@majk-p the PR looks good to go! With the changes to the instrumentation the new typelevel versions will be supported moving forward. Could you please rebase and sign your initial commit to the PR in order to unblock the check? |
All done now! I accidentally overwrote your changes with the rebase, but cherry-picked them from #9235, I hope it's fine |
ad7bf27
to
45f4161
Compare
What Does This Do
Updates Weaver instrumentation to take into account changes to the organization following the recent migration
Motivation
Weaver has been migrated (typelevel/governance#114) from disneystreaming (https://github.com/disneystreaming/weaver-test) to typelevel (https://github.com/typelevel/weaver-test) organization. It has also got version updates in the meantime.
Additional Notes
Passing CI on #9235
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]