Skip to content

Add new org to Weaver instrumentation #9195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

majk-p
Copy link

@majk-p majk-p commented Jul 17, 2025

What Does This Do

Updates Weaver instrumentation to take into account changes to the organization following the recent migration

Motivation

Weaver has been migrated (typelevel/governance#114) from disneystreaming (https://github.com/disneystreaming/weaver-test) to typelevel (https://github.com/typelevel/weaver-test) organization. It has also got version updates in the meantime.

Additional Notes

Passing CI on #9235

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@majk-p majk-p requested a review from a team as a code owner July 17, 2025 10:49
@PerfectSlayer PerfectSlayer added tag: community Community contribution type: enhancement Enhancements and improvements inst: others All other instrumentations labels Jul 17, 2025
Copy link
Contributor

@daniel-mohedano daniel-mohedano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this PR @majk-p! From what I've gathered by locally testing, I think some additional changes will be necessary in order to support TypeLevel releases too, as currently the instrumentation will break with them. Will get back to you as soon as I take a look 👍

@daniel-mohedano daniel-mohedano added the comp: ci visibility Continuous Integration Visibility label Jul 21, 2025
@daniel-mohedano daniel-mohedano removed the inst: others All other instrumentations label Jul 24, 2025
@daniel-mohedano daniel-mohedano changed the title Switch to typelevel weaver Add new org to Weaver instrumentation Jul 24, 2025
@daniel-mohedano
Copy link
Contributor

@majk-p the PR looks good to go! With the changes to the instrumentation the new typelevel versions will be supported moving forward. Could you please rebase and sign your initial commit to the PR in order to unblock the check?

@majk-p majk-p force-pushed the typelevel-weaver branch from 98dffd0 to 2e0617c Compare July 24, 2025 13:30
@majk-p majk-p force-pushed the typelevel-weaver branch from 2e0617c to ad7bf27 Compare July 24, 2025 13:40
@majk-p
Copy link
Author

majk-p commented Jul 24, 2025

All done now! I accidentally overwrote your changes with the rebase, but cherry-picked them from #9235, I hope it's fine

@daniel-mohedano
Copy link
Contributor

@majk-p In the end it wasn't necessary due to this PR not being mergeable without CI checks 😅 . The changes have been merged through #9235 and will be available with v1.52 of the tracer. Thanks for taking the time of opening this PR and letting us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp: ci visibility Continuous Integration Visibility tag: community Community contribution type: enhancement Enhancements and improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants