-
Notifications
You must be signed in to change notification settings - Fork 310
Enhance Service Representation for Serverless #9203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
zarirhamza
wants to merge
7
commits into
master
Choose a base branch
from
zarir/ssr-aws-sdk
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 49 metrics, 10 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.51.1-SNAPSHOT~fccfcd9347, baseline=1.51.1-SNAPSHOT~bd88ddce7a
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.048 s) : 0, 1047581
Total [baseline] (10.767 s) : 0, 10766533
Agent [candidate] (1.046 s) : 0, 1046183
Total [candidate] (10.703 s) : 0, 10702997
section appsec
Agent [baseline] (1.214 s) : 0, 1213620
Total [baseline] (10.719 s) : 0, 10718869
Agent [candidate] (1.219 s) : 0, 1219127
Total [candidate] (10.771 s) : 0, 10771229
section iast
Agent [baseline] (1.172 s) : 0, 1171945
Total [baseline] (10.864 s) : 0, 10864157
Agent [candidate] (1.198 s) : 0, 1197994
Total [candidate] (10.889 s) : 0, 10888803
section profiling
Agent [baseline] (1.199 s) : 0, 1198996
Total [baseline] (10.914 s) : 0, 10914148
Agent [candidate] (1.188 s) : 0, 1188070
Total [candidate] (10.809 s) : 0, 10809028
gantt
title petclinic - break down per module: candidate=1.51.1-SNAPSHOT~fccfcd9347, baseline=1.51.1-SNAPSHOT~bd88ddce7a
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.46 ms) : 0, 1460
crashtracking [candidate] (1.433 ms) : 0, 1433
BytebuddyAgent [baseline] (734.23 ms) : 0, 734230
BytebuddyAgent [candidate] (731.873 ms) : 0, 731873
GlobalTracer [baseline] (241.276 ms) : 0, 241276
GlobalTracer [candidate] (242.604 ms) : 0, 242604
AppSec [baseline] (30.342 ms) : 0, 30342
AppSec [candidate] (30.541 ms) : 0, 30541
Debugger [baseline] (6.046 ms) : 0, 6046
Debugger [candidate] (6.059 ms) : 0, 6059
Remote Config [baseline] (647.46 µs) : 0, 647
Remote Config [candidate] (646.762 µs) : 0, 647
Telemetry [baseline] (12.468 ms) : 0, 12468
Telemetry [candidate] (12.029 ms) : 0, 12029
section appsec
crashtracking [baseline] (1.423 ms) : 0, 1423
crashtracking [candidate] (1.434 ms) : 0, 1434
BytebuddyAgent [baseline] (748.983 ms) : 0, 748983
BytebuddyAgent [candidate] (752.452 ms) : 0, 752452
GlobalTracer [baseline] (233.786 ms) : 0, 233786
GlobalTracer [candidate] (234.762 ms) : 0, 234762
IAST [baseline] (23.261 ms) : 0, 23261
IAST [candidate] (23.738 ms) : 0, 23738
AppSec [baseline] (168.077 ms) : 0, 168077
AppSec [candidate] (168.609 ms) : 0, 168609
Debugger [baseline] (8.002 ms) : 0, 8002
Debugger [candidate] (7.911 ms) : 0, 7911
Remote Config [baseline] (618.293 µs) : 0, 618
Remote Config [candidate] (612.506 µs) : 0, 613
Telemetry [baseline] (8.189 ms) : 0, 8189
Telemetry [candidate] (8.279 ms) : 0, 8279
section iast
crashtracking [baseline] (1.428 ms) : 0, 1428
crashtracking [candidate] (1.465 ms) : 0, 1465
BytebuddyAgent [baseline] (845.934 ms) : 0, 845934
BytebuddyAgent [candidate] (867.787 ms) : 0, 867787
GlobalTracer [baseline] (231.381 ms) : 0, 231381
GlobalTracer [candidate] (236.274 ms) : 0, 236274
IAST [baseline] (29.92 ms) : 0, 29920
IAST [candidate] (27.502 ms) : 0, 27502
AppSec [baseline] (27.903 ms) : 0, 27903
AppSec [candidate] (28.274 ms) : 0, 28274
Debugger [baseline] (5.772 ms) : 0, 5772
Debugger [candidate] (6.679 ms) : 0, 6679
Remote Config [baseline] (592.445 µs) : 0, 592
Remote Config [candidate] (593.87 µs) : 0, 594
Telemetry [baseline] (8.083 ms) : 0, 8083
Telemetry [candidate] (8.075 ms) : 0, 8075
section profiling
crashtracking [baseline] (1.413 ms) : 0, 1413
crashtracking [candidate] (1.391 ms) : 0, 1391
BytebuddyAgent [baseline] (764.716 ms) : 0, 764716
BytebuddyAgent [candidate] (756.965 ms) : 0, 756965
GlobalTracer [baseline] (221.12 ms) : 0, 221120
GlobalTracer [candidate] (219.775 ms) : 0, 219775
AppSec [baseline] (30.606 ms) : 0, 30606
AppSec [candidate] (30.119 ms) : 0, 30119
Debugger [baseline] (6.322 ms) : 0, 6322
Debugger [candidate] (6.281 ms) : 0, 6281
Remote Config [baseline] (682.729 µs) : 0, 683
Remote Config [candidate] (685.265 µs) : 0, 685
Telemetry [baseline] (16.122 ms) : 0, 16122
Telemetry [candidate] (16.059 ms) : 0, 16059
ProfilingAgent [baseline] (108.459 ms) : 0, 108459
ProfilingAgent [candidate] (107.815 ms) : 0, 107815
Profiling [baseline] (109.1 ms) : 0, 109100
Profiling [candidate] (108.482 ms) : 0, 108482
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.51.1-SNAPSHOT~fccfcd9347, baseline=1.51.1-SNAPSHOT~bd88ddce7a
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.053 s) : 0, 1053026
Total [baseline] (8.593 s) : 0, 8593293
Agent [candidate] (1.041 s) : 0, 1041426
Total [candidate] (8.571 s) : 0, 8570945
section iast
Agent [baseline] (1.178 s) : 0, 1177937
Total [baseline] (9.335 s) : 0, 9335286
Agent [candidate] (1.172 s) : 0, 1171883
Total [candidate] (9.3 s) : 0, 9299523
gantt
title insecure-bank - break down per module: candidate=1.51.1-SNAPSHOT~fccfcd9347, baseline=1.51.1-SNAPSHOT~bd88ddce7a
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.455 ms) : 0, 1455
crashtracking [candidate] (1.428 ms) : 0, 1428
BytebuddyAgent [baseline] (736.846 ms) : 0, 736846
BytebuddyAgent [candidate] (730.109 ms) : 0, 730109
GlobalTracer [baseline] (242.873 ms) : 0, 242873
GlobalTracer [candidate] (241.425 ms) : 0, 241425
AppSec [baseline] (30.56 ms) : 0, 30560
AppSec [candidate] (30.397 ms) : 0, 30397
Debugger [baseline] (6.143 ms) : 0, 6143
Debugger [candidate] (5.996 ms) : 0, 5996
Remote Config [baseline] (650.784 µs) : 0, 651
Remote Config [candidate] (643.936 µs) : 0, 644
Telemetry [baseline] (13.364 ms) : 0, 13364
Telemetry [candidate] (10.504 ms) : 0, 10504
section iast
crashtracking [baseline] (1.437 ms) : 0, 1437
crashtracking [candidate] (1.424 ms) : 0, 1424
BytebuddyAgent [baseline] (851.602 ms) : 0, 851602
BytebuddyAgent [candidate] (846.137 ms) : 0, 846137
GlobalTracer [baseline] (231.064 ms) : 0, 231064
GlobalTracer [candidate] (231.233 ms) : 0, 231233
IAST [baseline] (32.336 ms) : 0, 32336
IAST [candidate] (29.607 ms) : 0, 29607
AppSec [baseline] (25.88 ms) : 0, 25880
AppSec [candidate] (26.528 ms) : 0, 26528
Debugger [baseline] (5.864 ms) : 0, 5864
Debugger [candidate] (7.44 ms) : 0, 7440
Remote Config [baseline] (596.97 µs) : 0, 597
Remote Config [candidate] (581.117 µs) : 0, 581
Telemetry [baseline] (8.146 ms) : 0, 8146
Telemetry [candidate] (8.061 ms) : 0, 8061
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 12 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.51.1-SNAPSHOT~fccfcd9347, baseline=1.51.1-SNAPSHOT~bd88ddce7a
dateFormat X
axisFormat %s
section baseline
no_agent (36.847 ms) : 36558, 37137
. : milestone, 36847,
appsec (47.274 ms) : 46849, 47698
. : milestone, 47274,
code_origins (45.475 ms) : 45074, 45876
. : milestone, 45475,
iast (45.792 ms) : 45377, 46207
. : milestone, 45792,
profiling (47.624 ms) : 47180, 48068
. : milestone, 47624,
tracing (43.778 ms) : 43417, 44138
. : milestone, 43778,
section candidate
no_agent (37.293 ms) : 36984, 37603
. : milestone, 37293,
appsec (45.479 ms) : 45083, 45875
. : milestone, 45479,
code_origins (45.594 ms) : 45198, 45989
. : milestone, 45594,
iast (45.478 ms) : 45067, 45890
. : milestone, 45478,
profiling (48.883 ms) : 48411, 49355
. : milestone, 48883,
tracing (42.712 ms) : 42351, 43073
. : milestone, 42712,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.51.1-SNAPSHOT~fccfcd9347, baseline=1.51.1-SNAPSHOT~bd88ddce7a
dateFormat X
axisFormat %s
section baseline
no_agent (4.437 ms) : 4387, 4487
. : milestone, 4437,
iast (9.396 ms) : 9237, 9556
. : milestone, 9396,
iast_FULL (13.85 ms) : 13582, 14119
. : milestone, 13850,
iast_GLOBAL (11.148 ms) : 10951, 11345
. : milestone, 11148,
profiling (8.93 ms) : 8793, 9068
. : milestone, 8930,
tracing (7.525 ms) : 7405, 7645
. : milestone, 7525,
section candidate
no_agent (4.399 ms) : 4349, 4450
. : milestone, 4399,
iast (9.115 ms) : 8967, 9263
. : milestone, 9115,
iast_FULL (13.783 ms) : 13511, 14055
. : milestone, 13783,
iast_GLOBAL (10.371 ms) : 10182, 10559
. : milestone, 10371,
profiling (8.971 ms) : 8827, 9115
. : milestone, 8971,
tracing (7.457 ms) : 7345, 7570
. : milestone, 7457,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.51.1-SNAPSHOT~fccfcd9347, baseline=1.51.1-SNAPSHOT~bd88ddce7a
dateFormat X
axisFormat %s
section baseline
no_agent (1.471 ms) : 1459, 1483
. : milestone, 1471,
appsec (3.617 ms) : 3401, 3833
. : milestone, 3617,
iast (2.198 ms) : 2135, 2261
. : milestone, 2198,
iast_GLOBAL (2.236 ms) : 2174, 2299
. : milestone, 2236,
profiling (2.021 ms) : 1971, 2070
. : milestone, 2021,
tracing (2.02 ms) : 1972, 2069
. : milestone, 2020,
section candidate
no_agent (1.472 ms) : 1461, 1484
. : milestone, 1472,
appsec (3.626 ms) : 3411, 3841
. : milestone, 3626,
iast (2.195 ms) : 2133, 2257
. : milestone, 2195,
iast_GLOBAL (2.235 ms) : 2173, 2297
. : milestone, 2235,
profiling (2.053 ms) : 2002, 2104
. : milestone, 2053,
tracing (2.007 ms) : 1959, 2055
. : milestone, 2007,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.51.1-SNAPSHOT~fccfcd9347, baseline=1.51.1-SNAPSHOT~bd88ddce7a
dateFormat X
axisFormat %s
section baseline
no_agent (15.604 s) : 15604000, 15604000
. : milestone, 15604000,
appsec (14.713 s) : 14713000, 14713000
. : milestone, 14713000,
iast (18.111 s) : 18111000, 18111000
. : milestone, 18111000,
iast_GLOBAL (18.202 s) : 18202000, 18202000
. : milestone, 18202000,
profiling (15.922 s) : 15922000, 15922000
. : milestone, 15922000,
tracing (14.752 s) : 14752000, 14752000
. : milestone, 14752000,
section candidate
no_agent (15.201 s) : 15201000, 15201000
. : milestone, 15201000,
appsec (14.784 s) : 14784000, 14784000
. : milestone, 14784000,
iast (18.398 s) : 18398000, 18398000
. : milestone, 18398000,
iast_GLOBAL (18.284 s) : 18284000, 18284000
. : milestone, 18284000,
profiling (15.377 s) : 15377000, 15377000
. : milestone, 15377000,
tracing (15.181 s) : 15181000, 15181000
. : milestone, 15181000,
|
...ava-sdk-1.11.0/src/main/java/datadog/trace/instrumentation/aws/v0/AwsSdkClientDecorator.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Rollout of span naming changes to align tracer with serverless product to create streamlined Service Representation for Serverless
Key Changes:
Apply all changes ONLY in a Serverless scenario
Apply explicit peer.service tag equal to the hostname based on aws service type and region grouping all spans underneath one explicitly defined inferred service
Motivation
Improve Service Map for Serverless
Additional Notes
Only the sdk v1 and v2 need to be changed since those affect all spans before other instrumentation enriches based on service. This is a generic change so no need for specific instrumentation behavior
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]