-
Notifications
You must be signed in to change notification settings - Fork 311
Convert settings and main build to kotlin #9216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 48 metrics, 11 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.51.1-SNAPSHOT~0693cc1ead, baseline=1.51.1-SNAPSHOT~bf6c156e8c
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.056 s) : 0, 1055522
Total [baseline] (8.569 s) : 0, 8568623
Agent [candidate] (1.04 s) : 0, 1039780
Total [candidate] (8.559 s) : 0, 8558957
section iast
Agent [baseline] (1.182 s) : 0, 1182202
Total [baseline] (9.343 s) : 0, 9343378
Agent [candidate] (1.181 s) : 0, 1180981
Total [candidate] (9.312 s) : 0, 9311832
gantt
title insecure-bank - break down per module: candidate=1.51.1-SNAPSHOT~0693cc1ead, baseline=1.51.1-SNAPSHOT~bf6c156e8c
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.445 ms) : 0, 1445
crashtracking [candidate] (1.411 ms) : 0, 1411
BytebuddyAgent [baseline] (740.604 ms) : 0, 740604
BytebuddyAgent [candidate] (727.539 ms) : 0, 727539
GlobalTracer [baseline] (241.865 ms) : 0, 241865
GlobalTracer [candidate] (241.123 ms) : 0, 241123
AppSec [baseline] (30.345 ms) : 0, 30345
AppSec [candidate] (30.286 ms) : 0, 30286
Debugger [baseline] (5.999 ms) : 0, 5999
Debugger [candidate] (5.999 ms) : 0, 5999
Remote Config [baseline] (663.536 µs) : 0, 664
Remote Config [candidate] (643.016 µs) : 0, 643
Telemetry [baseline] (13.559 ms) : 0, 13559
Telemetry [candidate] (11.98 ms) : 0, 11980
section iast
crashtracking [baseline] (1.435 ms) : 0, 1435
crashtracking [candidate] (1.444 ms) : 0, 1444
BytebuddyAgent [baseline] (855.0 ms) : 0, 855000
BytebuddyAgent [candidate] (853.446 ms) : 0, 853446
GlobalTracer [baseline] (232.961 ms) : 0, 232961
GlobalTracer [candidate] (232.112 ms) : 0, 232112
IAST [baseline] (29.316 ms) : 0, 29316
IAST [candidate] (29.098 ms) : 0, 29098
AppSec [baseline] (28.158 ms) : 0, 28158
AppSec [candidate] (27.611 ms) : 0, 27611
Debugger [baseline] (5.741 ms) : 0, 5741
Debugger [candidate] (7.501 ms) : 0, 7501
Remote Config [baseline] (579.472 µs) : 0, 579
Remote Config [candidate] (592.253 µs) : 0, 592
Telemetry [baseline] (8.038 ms) : 0, 8038
Telemetry [candidate] (8.142 ms) : 0, 8142
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.51.1-SNAPSHOT~0693cc1ead, baseline=1.51.1-SNAPSHOT~bf6c156e8c
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.041 s) : 0, 1040682
Total [baseline] (10.686 s) : 0, 10685787
Agent [candidate] (1.047 s) : 0, 1047480
Total [candidate] (10.767 s) : 0, 10767278
section appsec
Agent [baseline] (1.214 s) : 0, 1214246
Total [baseline] (10.694 s) : 0, 10693879
Agent [candidate] (1.221 s) : 0, 1220730
Total [candidate] (10.75 s) : 0, 10750027
section iast
Agent [baseline] (1.17 s) : 0, 1170332
Total [baseline] (10.865 s) : 0, 10865094
Agent [candidate] (1.175 s) : 0, 1175015
Total [candidate] (10.853 s) : 0, 10852658
section profiling
Agent [baseline] (1.194 s) : 0, 1194486
Total [baseline] (10.919 s) : 0, 10918972
Agent [candidate] (1.19 s) : 0, 1189785
Total [candidate] (10.837 s) : 0, 10836707
gantt
title petclinic - break down per module: candidate=1.51.1-SNAPSHOT~0693cc1ead, baseline=1.51.1-SNAPSHOT~bf6c156e8c
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.419 ms) : 0, 1419
crashtracking [candidate] (1.442 ms) : 0, 1442
BytebuddyAgent [baseline] (729.813 ms) : 0, 729813
BytebuddyAgent [candidate] (735.068 ms) : 0, 735068
GlobalTracer [baseline] (241.092 ms) : 0, 241092
GlobalTracer [candidate] (241.683 ms) : 0, 241683
AppSec [baseline] (30.338 ms) : 0, 30338
AppSec [candidate] (30.383 ms) : 0, 30383
Debugger [baseline] (5.982 ms) : 0, 5982
Debugger [candidate] (6.0 ms) : 0, 6000
Remote Config [baseline] (639.264 µs) : 0, 639
Remote Config [candidate] (643.7 µs) : 0, 644
Telemetry [baseline] (10.439 ms) : 0, 10439
Telemetry [candidate] (11.223 ms) : 0, 11223
section appsec
crashtracking [baseline] (1.417 ms) : 0, 1417
crashtracking [candidate] (1.422 ms) : 0, 1422
BytebuddyAgent [baseline] (750.184 ms) : 0, 750184
BytebuddyAgent [candidate] (753.868 ms) : 0, 753868
GlobalTracer [baseline] (234.061 ms) : 0, 234061
GlobalTracer [candidate] (235.248 ms) : 0, 235248
IAST [baseline] (23.312 ms) : 0, 23312
IAST [candidate] (23.512 ms) : 0, 23512
AppSec [baseline] (169.992 ms) : 0, 169992
AppSec [candidate] (169.48 ms) : 0, 169480
Debugger [baseline] (5.612 ms) : 0, 5612
Debugger [candidate] (7.291 ms) : 0, 7291
Remote Config [baseline] (603.387 µs) : 0, 603
Remote Config [candidate] (618.184 µs) : 0, 618
Telemetry [baseline] (8.174 ms) : 0, 8174
Telemetry [candidate] (8.243 ms) : 0, 8243
section iast
crashtracking [baseline] (1.422 ms) : 0, 1422
crashtracking [candidate] (1.422 ms) : 0, 1422
BytebuddyAgent [baseline] (845.065 ms) : 0, 845065
BytebuddyAgent [candidate] (848.788 ms) : 0, 848788
GlobalTracer [baseline] (230.363 ms) : 0, 230363
GlobalTracer [candidate] (231.31 ms) : 0, 231310
IAST [baseline] (30.007 ms) : 0, 30007
IAST [candidate] (30.041 ms) : 0, 30041
AppSec [baseline] (27.214 ms) : 0, 27214
AppSec [candidate] (27.246 ms) : 0, 27246
Debugger [baseline] (5.829 ms) : 0, 5829
Debugger [candidate] (6.539 ms) : 0, 6539
Remote Config [baseline] (595.388 µs) : 0, 595
Remote Config [candidate] (579.171 µs) : 0, 579
Telemetry [baseline] (8.961 ms) : 0, 8961
Telemetry [candidate] (8.094 ms) : 0, 8094
section profiling
crashtracking [baseline] (1.394 ms) : 0, 1394
crashtracking [candidate] (1.402 ms) : 0, 1402
BytebuddyAgent [baseline] (760.597 ms) : 0, 760597
BytebuddyAgent [candidate] (758.766 ms) : 0, 758766
GlobalTracer [baseline] (221.969 ms) : 0, 221969
GlobalTracer [candidate] (220.857 ms) : 0, 220857
AppSec [baseline] (30.457 ms) : 0, 30457
AppSec [candidate] (30.187 ms) : 0, 30187
Debugger [baseline] (6.254 ms) : 0, 6254
Debugger [candidate] (6.248 ms) : 0, 6248
Remote Config [baseline] (703.061 µs) : 0, 703
Remote Config [candidate] (687.965 µs) : 0, 688
Telemetry [baseline] (15.857 ms) : 0, 15857
Telemetry [candidate] (15.505 ms) : 0, 15505
ProfilingAgent [baseline] (107.984 ms) : 0, 107984
ProfilingAgent [candidate] (106.92 ms) : 0, 106920
Profiling [baseline] (108.616 ms) : 0, 108616
Profiling [candidate] (107.55 ms) : 0, 107550
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 2 performance regressions! Performance is the same for 9 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.51.1-SNAPSHOT~0693cc1ead, baseline=1.51.1-SNAPSHOT~bf6c156e8c
dateFormat X
axisFormat %s
section baseline
no_agent (4.268 ms) : 4220, 4316
. : milestone, 4268,
iast (9.492 ms) : 9317, 9667
. : milestone, 9492,
iast_FULL (14.03 ms) : 13748, 14311
. : milestone, 14030,
iast_GLOBAL (10.006 ms) : 9833, 10180
. : milestone, 10006,
profiling (8.857 ms) : 8719, 8994
. : milestone, 8857,
tracing (7.534 ms) : 7421, 7646
. : milestone, 7534,
section candidate
no_agent (4.395 ms) : 4345, 4445
. : milestone, 4395,
iast (9.291 ms) : 9138, 9444
. : milestone, 9291,
iast_FULL (13.666 ms) : 13402, 13930
. : milestone, 13666,
iast_GLOBAL (10.45 ms) : 10266, 10633
. : milestone, 10450,
profiling (8.801 ms) : 8664, 8938
. : milestone, 8801,
tracing (7.737 ms) : 7625, 7850
. : milestone, 7737,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.51.1-SNAPSHOT~0693cc1ead, baseline=1.51.1-SNAPSHOT~bf6c156e8c
dateFormat X
axisFormat %s
section baseline
no_agent (36.375 ms) : 36082, 36668
. : milestone, 36375,
appsec (46.47 ms) : 46069, 46872
. : milestone, 46470,
code_origins (45.922 ms) : 45524, 46320
. : milestone, 45922,
iast (43.896 ms) : 43520, 44271
. : milestone, 43896,
profiling (49.165 ms) : 48659, 49671
. : milestone, 49165,
tracing (44.941 ms) : 44555, 45327
. : milestone, 44941,
section candidate
no_agent (35.978 ms) : 35694, 36262
. : milestone, 35978,
appsec (46.311 ms) : 45895, 46727
. : milestone, 46311,
code_origins (43.745 ms) : 43378, 44113
. : milestone, 43745,
iast (46.271 ms) : 45864, 46677
. : milestone, 46271,
profiling (48.028 ms) : 47562, 48495
. : milestone, 48028,
tracing (44.397 ms) : 44028, 44766
. : milestone, 44397,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.51.1-SNAPSHOT~0693cc1ead, baseline=1.51.1-SNAPSHOT~bf6c156e8c
dateFormat X
axisFormat %s
section baseline
no_agent (1.469 ms) : 1457, 1480
. : milestone, 1469,
appsec (3.622 ms) : 3407, 3837
. : milestone, 3622,
iast (2.179 ms) : 2118, 2241
. : milestone, 2179,
iast_GLOBAL (2.228 ms) : 2166, 2291
. : milestone, 2228,
profiling (2.055 ms) : 2004, 2106
. : milestone, 2055,
tracing (2.02 ms) : 1972, 2069
. : milestone, 2020,
section candidate
no_agent (1.471 ms) : 1460, 1483
. : milestone, 1471,
appsec (3.628 ms) : 3414, 3843
. : milestone, 3628,
iast (2.187 ms) : 2125, 2249
. : milestone, 2187,
iast_GLOBAL (2.221 ms) : 2159, 2283
. : milestone, 2221,
profiling (2.052 ms) : 2001, 2104
. : milestone, 2052,
tracing (2.007 ms) : 1959, 2056
. : milestone, 2007,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.51.1-SNAPSHOT~0693cc1ead, baseline=1.51.1-SNAPSHOT~bf6c156e8c
dateFormat X
axisFormat %s
section baseline
no_agent (15.613 s) : 15613000, 15613000
. : milestone, 15613000,
appsec (14.917 s) : 14917000, 14917000
. : milestone, 14917000,
iast (18.605 s) : 18605000, 18605000
. : milestone, 18605000,
iast_GLOBAL (18.065 s) : 18065000, 18065000
. : milestone, 18065000,
profiling (15.119 s) : 15119000, 15119000
. : milestone, 15119000,
tracing (15.05 s) : 15050000, 15050000
. : milestone, 15050000,
section candidate
no_agent (15.691 s) : 15691000, 15691000
. : milestone, 15691000,
appsec (15.029 s) : 15029000, 15029000
. : milestone, 15029000,
iast (18.625 s) : 18625000, 18625000
. : milestone, 18625000,
iast_GLOBAL (18.144 s) : 18144000, 18144000
. : milestone, 18144000,
profiling (15.728 s) : 15728000, 15728000
. : milestone, 15728000,
tracing (14.888 s) : 14888000, 14888000
. : milestone, 14888000,
|
6fff105
to
b02305d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, thanks for the refactoring.
Have you seen improvements in IDE sync or gradle command during by moving to Kotlin?
Not really noticeable, bigger gains are achievable via other means. However, it significantly improves the IDE experience with typed API. |
What Does This Do
Convert build script and settings to kotlin.
Motivation
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]