-
Notifications
You must be signed in to change notification settings - Fork 310
Adding Config Inversion Telemetry component #9244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 49 metrics, 10 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.51.1-SNAPSHOT~02311518d7, baseline=1.51.1-SNAPSHOT~ae34f27d9d
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.042 s) : 0, 1041793
Total [baseline] (8.573 s) : 0, 8573458
Agent [candidate] (1.043 s) : 0, 1042848
Total [candidate] (8.546 s) : 0, 8546296
section iast
Agent [baseline] (1.169 s) : 0, 1169107
Total [baseline] (9.332 s) : 0, 9332206
Agent [candidate] (1.173 s) : 0, 1173389
Total [candidate] (9.226 s) : 0, 9225607
gantt
title insecure-bank - break down per module: candidate=1.51.1-SNAPSHOT~02311518d7, baseline=1.51.1-SNAPSHOT~ae34f27d9d
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.425 ms) : 0, 1425
crashtracking [candidate] (1.414 ms) : 0, 1414
BytebuddyAgent [baseline] (729.467 ms) : 0, 729467
BytebuddyAgent [candidate] (729.484 ms) : 0, 729484
GlobalTracer [baseline] (241.099 ms) : 0, 241099
GlobalTracer [candidate] (241.297 ms) : 0, 241297
AppSec [baseline] (30.362 ms) : 0, 30362
AppSec [candidate] (30.419 ms) : 0, 30419
Debugger [baseline] (6.06 ms) : 0, 6060
Debugger [candidate] (6.036 ms) : 0, 6036
Remote Config [baseline] (653.435 µs) : 0, 653
Remote Config [candidate] (650.809 µs) : 0, 651
Telemetry [baseline] (11.846 ms) : 0, 11846
Telemetry [candidate] (12.689 ms) : 0, 12689
section iast
crashtracking [baseline] (1.415 ms) : 0, 1415
crashtracking [candidate] (1.418 ms) : 0, 1418
BytebuddyAgent [baseline] (844.366 ms) : 0, 844366
BytebuddyAgent [candidate] (846.932 ms) : 0, 846932
GlobalTracer [baseline] (230.485 ms) : 0, 230485
GlobalTracer [candidate] (231.58 ms) : 0, 231580
IAST [baseline] (28.086 ms) : 0, 28086
IAST [candidate] (29.959 ms) : 0, 29959
AppSec [baseline] (29.563 ms) : 0, 29563
AppSec [candidate] (27.068 ms) : 0, 27068
Debugger [baseline] (5.804 ms) : 0, 5804
Debugger [candidate] (6.689 ms) : 0, 6689
Remote Config [baseline] (586.647 µs) : 0, 587
Remote Config [candidate] (602.107 µs) : 0, 602
Telemetry [baseline] (8.026 ms) : 0, 8026
Telemetry [candidate] (8.224 ms) : 0, 8224
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.51.1-SNAPSHOT~02311518d7, baseline=1.51.1-SNAPSHOT~ae34f27d9d
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.047 s) : 0, 1047465
Total [baseline] (10.67 s) : 0, 10670078
Agent [candidate] (1.041 s) : 0, 1040552
Total [candidate] (10.633 s) : 0, 10632944
section appsec
Agent [baseline] (1.214 s) : 0, 1214188
Total [baseline] (10.724 s) : 0, 10724374
Agent [candidate] (1.217 s) : 0, 1216544
Total [candidate] (10.725 s) : 0, 10725057
section iast
Agent [baseline] (1.167 s) : 0, 1166918
Total [baseline] (10.884 s) : 0, 10884374
Agent [candidate] (1.172 s) : 0, 1172126
Total [candidate] (10.865 s) : 0, 10865028
section profiling
Agent [baseline] (1.189 s) : 0, 1189103
Total [baseline] (10.807 s) : 0, 10807404
Agent [candidate] (1.191 s) : 0, 1191484
Total [candidate] (10.831 s) : 0, 10830788
gantt
title petclinic - break down per module: candidate=1.51.1-SNAPSHOT~02311518d7, baseline=1.51.1-SNAPSHOT~ae34f27d9d
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.433 ms) : 0, 1433
crashtracking [candidate] (1.431 ms) : 0, 1431
BytebuddyAgent [baseline] (732.855 ms) : 0, 732855
BytebuddyAgent [candidate] (728.197 ms) : 0, 728197
GlobalTracer [baseline] (242.031 ms) : 0, 242031
GlobalTracer [candidate] (240.877 ms) : 0, 240877
AppSec [baseline] (30.657 ms) : 0, 30657
AppSec [candidate] (30.372 ms) : 0, 30372
Debugger [baseline] (6.088 ms) : 0, 6088
Debugger [candidate] (6.049 ms) : 0, 6049
Remote Config [baseline] (661.539 µs) : 0, 662
Remote Config [candidate] (644.039 µs) : 0, 644
Telemetry [baseline] (12.676 ms) : 0, 12676
Telemetry [candidate] (12.014 ms) : 0, 12014
section appsec
crashtracking [baseline] (1.415 ms) : 0, 1415
crashtracking [candidate] (1.434 ms) : 0, 1434
BytebuddyAgent [baseline] (748.958 ms) : 0, 748958
BytebuddyAgent [candidate] (750.439 ms) : 0, 750439
GlobalTracer [baseline] (233.78 ms) : 0, 233780
GlobalTracer [candidate] (234.378 ms) : 0, 234378
IAST [baseline] (23.413 ms) : 0, 23413
IAST [candidate] (23.558 ms) : 0, 23558
AppSec [baseline] (168.006 ms) : 0, 168006
AppSec [candidate] (167.78 ms) : 0, 167780
Debugger [baseline] (8.615 ms) : 0, 8615
Debugger [candidate] (8.725 ms) : 0, 8725
Remote Config [baseline] (600.532 µs) : 0, 601
Remote Config [candidate] (621.188 µs) : 0, 621
Telemetry [baseline] (8.214 ms) : 0, 8214
Telemetry [candidate] (8.333 ms) : 0, 8333
section iast
crashtracking [baseline] (1.417 ms) : 0, 1417
crashtracking [candidate] (1.424 ms) : 0, 1424
BytebuddyAgent [baseline] (842.194 ms) : 0, 842194
BytebuddyAgent [candidate] (846.256 ms) : 0, 846256
GlobalTracer [baseline] (231.044 ms) : 0, 231044
GlobalTracer [candidate] (230.836 ms) : 0, 230836
IAST [baseline] (28.963 ms) : 0, 28963
IAST [candidate] (27.476 ms) : 0, 27476
AppSec [baseline] (27.984 ms) : 0, 27984
AppSec [candidate] (29.685 ms) : 0, 29685
Debugger [baseline] (5.744 ms) : 0, 5744
Debugger [candidate] (6.648 ms) : 0, 6648
Remote Config [baseline] (595.633 µs) : 0, 596
Remote Config [candidate] (595.497 µs) : 0, 595
Telemetry [baseline] (8.123 ms) : 0, 8123
Telemetry [candidate] (8.266 ms) : 0, 8266
section profiling
crashtracking [baseline] (1.399 ms) : 0, 1399
crashtracking [candidate] (1.4 ms) : 0, 1400
BytebuddyAgent [baseline] (758.812 ms) : 0, 758812
BytebuddyAgent [candidate] (761.234 ms) : 0, 761234
GlobalTracer [baseline] (219.696 ms) : 0, 219696
GlobalTracer [candidate] (219.569 ms) : 0, 219569
AppSec [baseline] (30.205 ms) : 0, 30205
AppSec [candidate] (30.064 ms) : 0, 30064
Debugger [baseline] (6.266 ms) : 0, 6266
Debugger [candidate] (6.248 ms) : 0, 6248
Remote Config [baseline] (687.233 µs) : 0, 687
Remote Config [candidate] (675.067 µs) : 0, 675
Telemetry [baseline] (15.958 ms) : 0, 15958
Telemetry [candidate] (15.96 ms) : 0, 15960
ProfilingAgent [baseline] (107.142 ms) : 0, 107142
ProfilingAgent [candidate] (107.142 ms) : 0, 107142
Profiling [baseline] (107.759 ms) : 0, 107759
Profiling [candidate] (107.787 ms) : 0, 107787
LoadParameters
See matching parameters
SummaryFound 5 performance improvements and 0 performance regressions! Performance is the same for 7 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.51.1-SNAPSHOT~02311518d7, baseline=1.51.1-SNAPSHOT~ae34f27d9d
dateFormat X
axisFormat %s
section baseline
no_agent (4.306 ms) : 4258, 4354
. : milestone, 4306,
iast (9.32 ms) : 9169, 9470
. : milestone, 9320,
iast_FULL (13.879 ms) : 13602, 14157
. : milestone, 13879,
iast_GLOBAL (10.35 ms) : 10169, 10530
. : milestone, 10350,
profiling (9.434 ms) : 9284, 9584
. : milestone, 9434,
tracing (7.93 ms) : 7817, 8043
. : milestone, 7930,
section candidate
no_agent (4.286 ms) : 4239, 4333
. : milestone, 4286,
iast (9.453 ms) : 9296, 9610
. : milestone, 9453,
iast_FULL (13.85 ms) : 13577, 14123
. : milestone, 13850,
iast_GLOBAL (10.222 ms) : 10036, 10408
. : milestone, 10222,
profiling (8.855 ms) : 8719, 8990
. : milestone, 8855,
tracing (7.542 ms) : 7438, 7645
. : milestone, 7542,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.51.1-SNAPSHOT~02311518d7, baseline=1.51.1-SNAPSHOT~ae34f27d9d
dateFormat X
axisFormat %s
section baseline
no_agent (36.753 ms) : 36451, 37056
. : milestone, 36753,
appsec (48.201 ms) : 47779, 48624
. : milestone, 48201,
code_origins (45.807 ms) : 45419, 46195
. : milestone, 45807,
iast (44.433 ms) : 44058, 44809
. : milestone, 44433,
profiling (49.316 ms) : 48851, 49781
. : milestone, 49316,
tracing (46.083 ms) : 45698, 46467
. : milestone, 46083,
section candidate
no_agent (36.873 ms) : 36580, 37166
. : milestone, 36873,
appsec (45.529 ms) : 45127, 45931
. : milestone, 45529,
code_origins (45.003 ms) : 44615, 45391
. : milestone, 45003,
iast (44.895 ms) : 44501, 45289
. : milestone, 44895,
profiling (47.025 ms) : 46574, 47475
. : milestone, 47025,
tracing (44.384 ms) : 44002, 44767
. : milestone, 44384,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.51.1-SNAPSHOT~02311518d7, baseline=1.51.1-SNAPSHOT~ae34f27d9d
dateFormat X
axisFormat %s
section baseline
no_agent (1.472 ms) : 1460, 1483
. : milestone, 1472,
appsec (3.645 ms) : 3429, 3862
. : milestone, 3645,
iast (2.186 ms) : 2123, 2248
. : milestone, 2186,
iast_GLOBAL (2.235 ms) : 2172, 2298
. : milestone, 2235,
profiling (2.038 ms) : 1988, 2089
. : milestone, 2038,
tracing (2.015 ms) : 1966, 2064
. : milestone, 2015,
section candidate
no_agent (1.468 ms) : 1456, 1479
. : milestone, 1468,
appsec (3.617 ms) : 3402, 3832
. : milestone, 3617,
iast (2.19 ms) : 2127, 2252
. : milestone, 2190,
iast_GLOBAL (2.231 ms) : 2168, 2294
. : milestone, 2231,
profiling (2.041 ms) : 1989, 2092
. : milestone, 2041,
tracing (2.014 ms) : 1965, 2063
. : milestone, 2014,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.51.1-SNAPSHOT~02311518d7, baseline=1.51.1-SNAPSHOT~ae34f27d9d
dateFormat X
axisFormat %s
section baseline
no_agent (15.495 s) : 15495000, 15495000
. : milestone, 15495000,
appsec (14.833 s) : 14833000, 14833000
. : milestone, 14833000,
iast (18.573 s) : 18573000, 18573000
. : milestone, 18573000,
iast_GLOBAL (18.146 s) : 18146000, 18146000
. : milestone, 18146000,
profiling (15.289 s) : 15289000, 15289000
. : milestone, 15289000,
tracing (15.02 s) : 15020000, 15020000
. : milestone, 15020000,
section candidate
no_agent (14.773 s) : 14773000, 14773000
. : milestone, 14773000,
appsec (15.019 s) : 15019000, 15019000
. : milestone, 15019000,
iast (18.452 s) : 18452000, 18452000
. : milestone, 18452000,
iast_GLOBAL (17.872 s) : 17872000, 17872000
. : milestone, 17872000,
profiling (15.228 s) : 15228000, 15228000
. : milestone, 15228000,
tracing (15.273 s) : 15273000, 15273000
. : milestone, 15273000,
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
What Does This Do
As part of Config Inversion, we want to emit Telemetry metrics for all environment variables set that are DD related but not documented in the
supported-configurations.json
file. This PR introduces the Telemetry metrics component for Config Inversion. Given that theConfigHelper
andsupported-configurations.json
file do not exist yet, testing is done with a lightweight "Mock" helper that has a list of "supported configurations", and emits a telemetry metric if an environment variable is passed in that is not "supported".Motivation
Config Inversion RFC
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]