-
Notifications
You must be signed in to change notification settings - Fork 311
Only report ASM_DD, ASM_DATA and ASM capabilities when AppSec is enabled #9260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only report ASM_DD, ASM_DATA and ASM capabilities when AppSec is enabled #9260
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 48 metrics, 11 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.51.1-SNAPSHOT~311bc7b180, baseline=1.51.1-SNAPSHOT~1b40197b5c
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.044 s) : 0, 1044151
Total [baseline] (8.555 s) : 0, 8554573
Agent [candidate] (1.042 s) : 0, 1041526
Total [candidate] (8.563 s) : 0, 8562808
section iast
Agent [baseline] (1.169 s) : 0, 1168660
Total [baseline] (9.269 s) : 0, 9269464
Agent [candidate] (1.169 s) : 0, 1169451
Total [candidate] (9.284 s) : 0, 9283681
gantt
title insecure-bank - break down per module: candidate=1.51.1-SNAPSHOT~311bc7b180, baseline=1.51.1-SNAPSHOT~1b40197b5c
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.445 ms) : 0, 1445
crashtracking [candidate] (1.437 ms) : 0, 1437
BytebuddyAgent [baseline] (733.572 ms) : 0, 733572
BytebuddyAgent [candidate] (729.142 ms) : 0, 729142
GlobalTracer [baseline] (241.215 ms) : 0, 241215
GlobalTracer [candidate] (241.303 ms) : 0, 241303
AppSec [baseline] (30.344 ms) : 0, 30344
AppSec [candidate] (30.047 ms) : 0, 30047
Debugger [baseline] (6.032 ms) : 0, 6032
Debugger [candidate] (6.042 ms) : 0, 6042
Remote Config [baseline] (647.234 µs) : 0, 647
Remote Config [candidate] (643.652 µs) : 0, 644
Telemetry [baseline] (9.88 ms) : 0, 9880
Telemetry [candidate] (11.969 ms) : 0, 11969
section iast
crashtracking [baseline] (1.418 ms) : 0, 1418
crashtracking [candidate] (1.428 ms) : 0, 1428
BytebuddyAgent [baseline] (843.666 ms) : 0, 843666
BytebuddyAgent [candidate] (844.449 ms) : 0, 844449
GlobalTracer [baseline] (230.193 ms) : 0, 230193
GlobalTracer [candidate] (231.3 ms) : 0, 231300
IAST [baseline] (28.313 ms) : 0, 28313
IAST [candidate] (30.67 ms) : 0, 30670
AppSec [baseline] (27.98 ms) : 0, 27980
AppSec [candidate] (26.211 ms) : 0, 26211
Debugger [baseline] (7.437 ms) : 0, 7437
Debugger [candidate] (5.815 ms) : 0, 5815
Remote Config [baseline] (587.756 µs) : 0, 588
Remote Config [candidate] (575.245 µs) : 0, 575
Telemetry [baseline] (8.098 ms) : 0, 8098
Telemetry [candidate] (8.12 ms) : 0, 8120
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.51.1-SNAPSHOT~311bc7b180, baseline=1.51.1-SNAPSHOT~1b40197b5c
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.048 s) : 0, 1048433
Total [baseline] (10.629 s) : 0, 10629081
Agent [candidate] (1.048 s) : 0, 1048475
Total [candidate] (10.659 s) : 0, 10658880
section appsec
Agent [baseline] (1.223 s) : 0, 1223252
Total [baseline] (10.799 s) : 0, 10798823
Agent [candidate] (1.217 s) : 0, 1216792
Total [candidate] (10.713 s) : 0, 10713250
section iast
Agent [baseline] (1.173 s) : 0, 1172657
Total [baseline] (10.825 s) : 0, 10825099
Agent [candidate] (1.182 s) : 0, 1182130
Total [candidate] (10.88 s) : 0, 10879953
section profiling
Agent [baseline] (1.189 s) : 0, 1189408
Total [baseline] (10.791 s) : 0, 10790865
Agent [candidate] (1.192 s) : 0, 1191886
Total [candidate] (10.89 s) : 0, 10889984
gantt
title petclinic - break down per module: candidate=1.51.1-SNAPSHOT~311bc7b180, baseline=1.51.1-SNAPSHOT~1b40197b5c
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.441 ms) : 0, 1441
crashtracking [candidate] (1.443 ms) : 0, 1443
BytebuddyAgent [baseline] (735.738 ms) : 0, 735738
BytebuddyAgent [candidate] (735.052 ms) : 0, 735052
GlobalTracer [baseline] (242.811 ms) : 0, 242811
GlobalTracer [candidate] (242.672 ms) : 0, 242672
AppSec [baseline] (30.633 ms) : 0, 30633
AppSec [candidate] (30.2 ms) : 0, 30200
Debugger [baseline] (6.065 ms) : 0, 6065
Debugger [candidate] (6.053 ms) : 0, 6053
Remote Config [baseline] (663.914 µs) : 0, 664
Remote Config [candidate] (651.813 µs) : 0, 652
Telemetry [baseline] (9.988 ms) : 0, 9988
Telemetry [candidate] (11.266 ms) : 0, 11266
section appsec
crashtracking [baseline] (1.433 ms) : 0, 1433
crashtracking [candidate] (1.42 ms) : 0, 1420
BytebuddyAgent [baseline] (755.605 ms) : 0, 755605
BytebuddyAgent [candidate] (751.456 ms) : 0, 751456
GlobalTracer [baseline] (235.253 ms) : 0, 235253
GlobalTracer [candidate] (234.046 ms) : 0, 234046
AppSec [baseline] (169.94 ms) : 0, 169940
AppSec [candidate] (167.78 ms) : 0, 167780
Debugger [baseline] (7.178 ms) : 0, 7178
Debugger [candidate] (7.897 ms) : 0, 7897
Remote Config [baseline] (617.224 µs) : 0, 617
Remote Config [candidate] (618.995 µs) : 0, 619
Telemetry [baseline] (8.279 ms) : 0, 8279
Telemetry [candidate] (8.965 ms) : 0, 8965
IAST [baseline] (23.832 ms) : 0, 23832
IAST [candidate] (23.626 ms) : 0, 23626
section iast
crashtracking [baseline] (1.424 ms) : 0, 1424
crashtracking [candidate] (1.437 ms) : 0, 1437
BytebuddyAgent [baseline] (846.08 ms) : 0, 846080
BytebuddyAgent [candidate] (854.036 ms) : 0, 854036
GlobalTracer [baseline] (231.462 ms) : 0, 231462
GlobalTracer [candidate] (232.62 ms) : 0, 232620
AppSec [baseline] (28.964 ms) : 0, 28964
AppSec [candidate] (28.144 ms) : 0, 28144
Debugger [baseline] (7.605 ms) : 0, 7605
Debugger [candidate] (8.23 ms) : 0, 8230
Remote Config [baseline] (583.448 µs) : 0, 583
Remote Config [candidate] (601.409 µs) : 0, 601
Telemetry [baseline] (8.155 ms) : 0, 8155
Telemetry [candidate] (8.14 ms) : 0, 8140
IAST [baseline] (27.356 ms) : 0, 27356
IAST [candidate] (27.738 ms) : 0, 27738
section profiling
ProfilingAgent [baseline] (107.708 ms) : 0, 107708
ProfilingAgent [candidate] (108.687 ms) : 0, 108687
crashtracking [baseline] (1.398 ms) : 0, 1398
crashtracking [candidate] (1.397 ms) : 0, 1397
BytebuddyAgent [baseline] (757.5 ms) : 0, 757500
BytebuddyAgent [candidate] (758.572 ms) : 0, 758572
GlobalTracer [baseline] (220.677 ms) : 0, 220677
GlobalTracer [candidate] (220.811 ms) : 0, 220811
AppSec [baseline] (30.168 ms) : 0, 30168
AppSec [candidate] (29.924 ms) : 0, 29924
Debugger [baseline] (6.18 ms) : 0, 6180
Debugger [candidate] (6.282 ms) : 0, 6282
Remote Config [baseline] (678.107 µs) : 0, 678
Remote Config [candidate] (677.577 µs) : 0, 678
Telemetry [baseline] (15.877 ms) : 0, 15877
Telemetry [candidate] (16.127 ms) : 0, 16127
Profiling [baseline] (108.372 ms) : 0, 108372
Profiling [candidate] (109.343 ms) : 0, 109343
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 3 performance regressions! Performance is the same for 9 metrics, 12 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.51.1-SNAPSHOT~311bc7b180, baseline=1.51.1-SNAPSHOT~1b40197b5c
dateFormat X
axisFormat %s
section baseline
no_agent (36.31 ms) : 36000, 36619
. : milestone, 36310,
appsec (47.134 ms) : 46719, 47549
. : milestone, 47134,
code_origins (46.575 ms) : 46168, 46982
. : milestone, 46575,
iast (45.455 ms) : 45077, 45832
. : milestone, 45455,
profiling (49.015 ms) : 48542, 49487
. : milestone, 49015,
tracing (45.728 ms) : 45335, 46121
. : milestone, 45728,
section candidate
no_agent (37.629 ms) : 37321, 37937
. : milestone, 37629,
appsec (47.757 ms) : 47330, 48184
. : milestone, 47757,
code_origins (45.258 ms) : 44864, 45652
. : milestone, 45258,
iast (44.368 ms) : 43992, 44745
. : milestone, 44368,
profiling (50.093 ms) : 49608, 50578
. : milestone, 50093,
tracing (45.139 ms) : 44754, 45524
. : milestone, 45139,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.51.1-SNAPSHOT~311bc7b180, baseline=1.51.1-SNAPSHOT~1b40197b5c
dateFormat X
axisFormat %s
section baseline
no_agent (4.354 ms) : 4305, 4403
. : milestone, 4354,
iast (9.297 ms) : 9146, 9449
. : milestone, 9297,
iast_FULL (13.669 ms) : 13397, 13940
. : milestone, 13669,
iast_GLOBAL (10.51 ms) : 10326, 10695
. : milestone, 10510,
profiling (8.513 ms) : 8383, 8644
. : milestone, 8513,
tracing (7.529 ms) : 7419, 7638
. : milestone, 7529,
section candidate
no_agent (4.393 ms) : 4344, 4442
. : milestone, 4393,
iast (9.32 ms) : 9166, 9473
. : milestone, 9320,
iast_FULL (13.849 ms) : 13571, 14126
. : milestone, 13849,
iast_GLOBAL (10.394 ms) : 10211, 10576
. : milestone, 10394,
profiling (9.51 ms) : 9357, 9663
. : milestone, 9510,
tracing (7.89 ms) : 7770, 8011
. : milestone, 7890,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.51.1-SNAPSHOT~311bc7b180, baseline=1.51.1-SNAPSHOT~1b40197b5c
dateFormat X
axisFormat %s
section baseline
no_agent (1.479 ms) : 1467, 1490
. : milestone, 1479,
appsec (3.561 ms) : 3351, 3771
. : milestone, 3561,
iast (2.212 ms) : 2149, 2275
. : milestone, 2212,
iast_GLOBAL (2.249 ms) : 2186, 2311
. : milestone, 2249,
profiling (2.039 ms) : 1989, 2089
. : milestone, 2039,
tracing (2.019 ms) : 1971, 2068
. : milestone, 2019,
section candidate
no_agent (1.484 ms) : 1472, 1496
. : milestone, 1484,
appsec (3.674 ms) : 3456, 3892
. : milestone, 3674,
iast (2.198 ms) : 2135, 2261
. : milestone, 2198,
iast_GLOBAL (2.243 ms) : 2180, 2306
. : milestone, 2243,
profiling (2.065 ms) : 2013, 2117
. : milestone, 2065,
tracing (2.031 ms) : 1982, 2080
. : milestone, 2031,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.51.1-SNAPSHOT~311bc7b180, baseline=1.51.1-SNAPSHOT~1b40197b5c
dateFormat X
axisFormat %s
section baseline
no_agent (15.539 s) : 15539000, 15539000
. : milestone, 15539000,
appsec (14.979 s) : 14979000, 14979000
. : milestone, 14979000,
iast (18.364 s) : 18364000, 18364000
. : milestone, 18364000,
iast_GLOBAL (18.167 s) : 18167000, 18167000
. : milestone, 18167000,
profiling (15.235 s) : 15235000, 15235000
. : milestone, 15235000,
tracing (15.093 s) : 15093000, 15093000
. : milestone, 15093000,
section candidate
no_agent (15.04 s) : 15040000, 15040000
. : milestone, 15040000,
appsec (14.753 s) : 14753000, 14753000
. : milestone, 14753000,
iast (18.42 s) : 18420000, 18420000
. : milestone, 18420000,
iast_GLOBAL (18.109 s) : 18109000, 18109000
. : milestone, 18109000,
profiling (15.577 s) : 15577000, 15577000
. : milestone, 15577000,
tracing (14.89 s) : 14890000, 14890000
. : milestone, 14890000,
|
0071606
to
596b462
Compare
@@ -820,6 +711,41 @@ class AppSecConfigServiceImplSpecification extends DDSpecification { | |||
service.usedDDWafConfigKeys.empty | |||
} | |||
|
|||
void 'test that empty configurations are acknowledged'() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a suggestion, I feel that something like 'are not sent' is more accurate than 'are acknowledged'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It refers to the RC status, before they were reported as ERROR
as the WAF failed to accept the config, now they will be reported as ACKNOWLEDGED
@@ -4,7 +4,7 @@ | |||
|
|||
public class AppSecApplication { | |||
|
|||
public static final long TIMEOUT_IN_SECONDS = 10; | |||
public static final long TIMEOUT_IN_SECONDS = 15; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to fix the flakiness?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's just to give us a little bit of extra room.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test should be passing after the latest commits
@@ -820,6 +711,41 @@ class AppSecConfigServiceImplSpecification extends DDSpecification { | |||
service.usedDDWafConfigKeys.empty | |||
} | |||
|
|||
void 'test that empty configurations are acknowledged'() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It refers to the RC status, before they were reported as ERROR
as the WAF failed to accept the config, now they will be reported as ACKNOWLEDGED
@@ -4,7 +4,7 @@ | |||
|
|||
public class AppSecApplication { | |||
|
|||
public static final long TIMEOUT_IN_SECONDS = 10; | |||
public static final long TIMEOUT_IN_SECONDS = 15; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's just to give us a little bit of extra room.
c019ea7
to
311bc7b
Compare
…led (#9260) Only report ASM_DD, ASM_DATA and ASM capabilities when AppSec is enabled Signed-off-by: Nayeem Kamal <nayeem.kamal@datadoghq.com>
| Package | Type | Package file | Manager | Update | Change | |---|---|---|---|---|---| | [redis.clients:jedis](https://github.com/redis/jedis) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `6.0.0` -> `6.1.0` | | [com.google.api.grpc:proto-google-common-protos](https://github.com/googleapis/sdk-platform-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `2.59.2` -> `2.60.0` | | [com.google.cloud:google-cloud-core-http](https://github.com/googleapis/sdk-platform-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `2.58.2` -> `2.59.0` | | [com.google.cloud:google-cloud-core](https://github.com/googleapis/sdk-platform-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `2.58.2` -> `2.59.0` | | [com.google.api:gax](https://github.com/googleapis/sdk-platform-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `2.68.2` -> `2.69.0` | | [com.squareup.wire](https://github.com/square/wire) | plugin | misk/gradle/libs.versions.toml | gradle | patch | `5.3.5` -> `5.3.6` | | [com.squareup.wire:wire-schema](https://github.com/square/wire) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `5.3.5` -> `5.3.6` | | [com.squareup.wire:wire-runtime](https://github.com/square/wire) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `5.3.5` -> `5.3.6` | | [com.squareup.wire:wire-reflector](https://github.com/square/wire) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `5.3.5` -> `5.3.6` | | [com.squareup.wire:wire-moshi-adapter](https://github.com/square/wire) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `5.3.5` -> `5.3.6` | | [com.squareup.wire:wire-grpc-client](https://github.com/square/wire) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `5.3.5` -> `5.3.6` | | [com.squareup.wire:wire-bom](https://github.com/square/wire) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `5.3.5` -> `5.3.6` | | [com.datadoghq:dd-trace-api](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.51.2` -> `1.52.0` | | [software.amazon.awssdk:sdk-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.32.14` -> `2.32.15` | | [software.amazon.awssdk:sqs](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.32.14` -> `2.32.15` | | [software.amazon.awssdk:regions](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.32.14` -> `2.32.15` | | [software.amazon.awssdk:dynamodb-enhanced](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.32.14` -> `2.32.15` | | [software.amazon.awssdk:dynamodb](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.32.14` -> `2.32.15` | | [software.amazon.awssdk:aws-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.32.14` -> `2.32.15` | | [software.amazon.awssdk:bom](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.32.14` -> `2.32.15` | | [software.amazon.awssdk:auth](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.32.14` -> `2.32.15` | --- ### Release Notes <details> <summary>redis/jedis (redis.clients:jedis)</summary> ### [`v6.1.0`](https://github.com/redis/jedis/releases/tag/v6.1.0): 6.1.0 ### Changes #### 🚀 New Features - Add support for SVS-VAMANA vector indexing ([#​4222](redis/jedis#4222)) - Clarify why new stream entries aren't deleted with XDELEX ([#​4218](redis/jedis#4218)) - Add support for new stream commands ([#​4211](redis/jedis#4211)) - Add Support for New BITOP Operations in Redis 8.2 ([#​4188](redis/jedis#4188)) ([#​4190](redis/jedis#4190)) - Add binary stream support for XREAD and XREADGROUP ([#​3566](redis/jedis#3566)) ([#​4152](redis/jedis#4152)) - Run pipeline in current thread if all the keys on same node ([#​4149](redis/jedis#4149)) #### 🐛 Bug Fixes - Restore binary compatibility of SetParams ([#​4225](redis/jedis#4225)) - Fix memory leak in JedisClusterInfoCache - replica nodes not cleared ([#​4205](redis/jedis#4205)) - Fix:JedisCluster throws NullPointerException when maxAttempts is set to 0 ([#​4186](redis/jedis#4186)) #### 🧰 Maintenance - DOC-5471 time series doc examples ([#​4210](redis/jedis#4210)) - Bump jackson.version from 2.19.1 to 2.19.2 ([#​4208](redis/jedis#4208)) - Fix flaky test ClientCommandsTest.killSkipmeYesNo ([#​4206](redis/jedis#4206)) - Bump org.junit:junit-bom from 5.13.2 to 5.13.3 ([#​4198](redis/jedis#4198)) - Migrate publishing to Maven Central Portal ([#​4199](redis/jedis#4199)) - Bump org.apache.maven.plugins:maven-gpg-plugin from 3.2.7 to 3.2.8 ([#​4197](redis/jedis#4197)) - Bump org.junit:junit-bom from 5.13.1 to 5.13.2 ([#​4192](redis/jedis#4192)) - DOC-5227 added probabilistic data type examples ([#​4184](redis/jedis#4184)) - Bump jackson.version from 2.19.0 to 2.19.1 ([#​4180](redis/jedis#4180)) - Update test infra to use latest Redis ([#​4179](redis/jedis#4179)) - Bump org.junit:junit-bom from 5.13.0-RC1 to 5.13.1 ([#​4174](redis/jedis#4174)) - Bump org.json:json from [`2025010`](redis/jedis@20250107) to [`2025051`](redis/jedis@20250517) ([#​4171](redis/jedis#4171)) - Bump org.apache.httpcomponents.client5:httpclient5-fluent from 5.4.4 to 5.5 ([#​4170](redis/jedis#4170)) - Fix flaky tests in DocumentTest ([#​3617](redis/jedis#3617)) - Add retryable command execution example ([#​3780](redis/jedis#3780)) - Bump jackson.version from 2.18.3 to 2.19.0 ([#​4160](redis/jedis#4160)) - Bump com.google.code.gson:gson from 2.12.1 to 2.13.1 ([#​4161](redis/jedis#4161)) #### Contributors We'd like to thank all the contributors who worked on this release! [@​219sansim](https://github.com/219sansim), [@​YoHanKi](https://github.com/YoHanKi), [@​andy-stark-redis](https://github.com/andy-stark-redis), [@​ggivo](https://github.com/ggivo), [@​jujn](https://github.com/jujn), [@​thachlp](https://github.com/thachlp), [@​uglide](https://github.com/uglide) and [@​xrayw](https://github.com/xrayw) </details> <details> <summary>googleapis/sdk-platform-java (com.google.api.grpc:proto-google-common-protos)</summary> ### [`v2.60.0`](https://github.com/googleapis/sdk-platform-java/blob/HEAD/CHANGELOG.md#2600-2025-06-23) ##### Features - handle auto pagination for BigQuery v2 ([#​3829](googleapis/sdk-platform-java#3829)) ([025c84c](googleapis/sdk-platform-java@025c84c)) ##### Dependencies - update google auth library dependencies to v1.37.1 ([#​3846](googleapis/sdk-platform-java#3846)) ([ea1d9e5](googleapis/sdk-platform-java@ea1d9e5)) - update google http client dependencies to v1.47.1 ([#​3848](googleapis/sdk-platform-java#3848)) ([a9a39d7](googleapis/sdk-platform-java@a9a39d7)) </details> <details> <summary>square/wire (com.squareup.wire)</summary> ### [`v5.3.6`](https://github.com/square/wire/blob/HEAD/CHANGELOG.md#Version-536) [Compare Source](square/wire@5.3.5...5.3.6) *2025-08-05* ##### CLI - New CLI option `--ignore_unused_roots_and_prunes` ([#​3354](square/wire#3354)) ##### JVM - Fix: Handle negative hexadecimal in default values ([#​3355](square/wire#3355)) - Optimization: Avoid copying of repeated and map types when mutableTypes are being used ([#​3352](square/wire#3352) by \[Rahul Ravikumar]\[tikurahul]) ##### Swift - Fix: Properly disambiguate OneOf enum if it has the same name as enclosing type ([#​3350](square/wire#3350) by \[Dimitris Koutsogiorgas]\[dnkoutso]) </details> <details> <summary>datadog/dd-trace-java (com.datadoghq:dd-trace-api)</summary> ### [`v1.52.0`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.52.0): 1.52.0 ### Components #### Application Security Management (WAF) - ✨ Only report ASM\_DD, ASM\_DATA and ASM capabilities when AppSec is enabled ([#​9260](DataDog/dd-trace-java#9260) - [@​manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - 🐛 Fix NPE in AppSecConfigServiceImpl ([#​9165](DataDog/dd-trace-java#9165) - [@​manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - 🐛 Fix AppSec play.mvc.StatusHeader instrumentation for play 2.6 ([#​9160](DataDog/dd-trace-java#9160) - [@​manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) #### Build & Tooling - ✨📖 Automatically register crashtracking via native extensions ([#​8851](DataDog/dd-trace-java#8851) - [@​MattAlp](https://github.com/MattAlp)) #### Configuration at Runtime - ✨ Create activation origin config for telemetry ([#​9064](DataDog/dd-trace-java#9064) - [@​sezen-datadog](https://github.com/sezen-datadog)) #### Continuous Integration Visibility - ✨ Update GitLab provided tags ([#​9275](DataDog/dd-trace-java#9275) - [@​daniel-mohedano](https://github.com/daniel-mohedano)) - 🐛 Fix base branch SHA usage in GitHub Actions ([#​9257](DataDog/dd-trace-java#9257) - [@​daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Add `ci.job.id` tag ([#​9256](DataDog/dd-trace-java#9256) - [@​daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Add new org to Weaver instrumentation ([#​9235](DataDog/dd-trace-java#9235) - [@​daniel-mohedano](https://github.com/daniel-mohedano) - thanks for the contribution!) - ✨ Improve Git commit info building ([#​9210](DataDog/dd-trace-java#9210) - [@​daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Update Attempt to Fix to v5 ([#​9145](DataDog/dd-trace-java#9145) - [@​daniel-mohedano](https://github.com/daniel-mohedano)) #### Crash tracking - ✨📖 Automatically register crashtracking via native extensions ([#​8851](DataDog/dd-trace-java#8851) - [@​MattAlp](https://github.com/MattAlp)) #### Data Streams Monitoring - ✨ Reduce DSM CPU overheard ([#​9151](DataDog/dd-trace-java#9151) - [@​kr-igor](https://github.com/kr-igor)) - ✨⚡ DSM optimizations for high throughput scenarios ([#​9137](DataDog/dd-trace-java#9137) - [@​kr-igor](https://github.com/kr-igor)) #### Database Monitoring - 🐛 Fix duplicate trace injection for SQL Server and Oracle DBM full propagation mode ([#​9224](DataDog/dd-trace-java#9224) - [@​lu-zhengda](https://github.com/lu-zhengda)) #### Dynamic Instrumentation - 🐛 Add URI in string primitives ([#​9285](DataDog/dd-trace-java#9285) - [@​jpbempel](https://github.com/jpbempel)) - ✨ Increase SourceFile tracking max queue size ([#​9271](DataDog/dd-trace-java#9271) - [@​jpbempel](https://github.com/jpbempel)) - ✨ Add capping on SourceFile tracking queue ([#​9245](DataDog/dd-trace-java#9245) - [@​jpbempel](https://github.com/jpbempel)) - ✨ Add third-party filtering in SourceFile tracking ([#​9205](DataDog/dd-trace-java#9205) - [@​jpbempel](https://github.com/jpbempel)) #### ML Observability (LLMObs) - ✨ Add methods to capture embedding and retrieval spans ([#​9297](DataDog/dd-trace-java#9297) - [@​nayeem-kamal](https://github.com/nayeem-kamal)) #### Metrics - ✨ Change primary client stats configuration key ([#​9196](DataDog/dd-trace-java#9196) - [@​amarziali](https://github.com/amarziali)) - ✨ Calculate client stats also if the span kind is eligible ([#​9157](DataDog/dd-trace-java#9157) - [@​amarziali](https://github.com/amarziali)) - ✨ Backpropagate peer tags ([#​9144](DataDog/dd-trace-java#9144) - [@​bric3](https://github.com/bric3)) - 🐛 Make client stats reliable in case of downgrade ([#​9136](DataDog/dd-trace-java#9136) - [@​amarziali](https://github.com/amarziali)) #### Platform components - 🐛 Fix VM options parsing from /proc/fs ([#​9255](DataDog/dd-trace-java#9255) - [@​PerfectSlayer](https://github.com/PerfectSlayer)) #### Profiling - ✨ Switch profile compression to zstd default ([#​9293](DataDog/dd-trace-java#9293) - [@​jbachorik](https://github.com/jbachorik)) - ✨ Bump ddprof to 1.29.0 ([#​9262](DataDog/dd-trace-java#9262) - [@​zhengyu123](https://github.com/zhengyu123)) - Potential memory leak and race with the JVMTI wallclock sampler by [@​zhengyu123](https://github.com/zhengyu123) in DataDog/java-profiler#234 - Downport async-profiler no-allocation changes by [@​zhengyu123](https://github.com/zhengyu123) in DataDog/java-profiler#245 - Adopt openjdk safefetch by [@​zhengyu123](https://github.com/zhengyu123) in DataDog/java-profiler#246 - Safe fetch 64-bit value and pointer by [@​zhengyu123](https://github.com/zhengyu123) in DataDog/java-profiler#247 - Rebase on Async-Profiler 4.1 by [@​jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#252 - Patch upstream stackWalker.cpp not to fail on unaligned access by [@​jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#218 - Remap thread id to avoid bitmap contention by [@​zhengyu123](https://github.com/zhengyu123) in DataDog/java-profiler#229 - Improve performance using Unsafe to activate/deactivate thread filter by [@​zhengyu123](https://github.com/zhengyu123) in DataDog/java-profiler#230 - Unify context propagation by [@​zhengyu123](https://github.com/zhengyu123) in DataDog/java-profiler#231 - 🐛 Fix the profiler stackdepth setting propagation in recent (22+) Java versions ([#​9130](DataDog/dd-trace-java#9130) - [@​jbachorik](https://github.com/jbachorik)) #### Realtime User Monitoring - ✨ Wrap servlet original PrintWriter on rum injector ([#​9146](DataDog/dd-trace-java#9146) - [@​amarziali](https://github.com/amarziali)) #### Telemetry - ✨ Create activation origin config for telemetry ([#​9064](DataDog/dd-trace-java#9064) - [@​sezen-datadog](https://github.com/sezen-datadog)) #### Tracer core - ✨⚡ Reduce span construction overhead by switching to optimized TagMap ([#​8589](DataDog/dd-trace-java#8589) - [@​dougqh](https://github.com/dougqh)) - 🐛 Match Hands Off Config selectors on process\_arguments value ([#​9201](DataDog/dd-trace-java#9201) - [@​paullegranddc](https://github.com/paullegranddc)) - ✨ Move JSON generation to sender thread to improve startup time. ([#​9197](DataDog/dd-trace-java#9197) - [@​AlexeyKuznetsov-DD](https://github.com/AlexeyKuznetsov-DD)) - ✨ Improve agent to avoid loading global config on main thread ([#​9190](DataDog/dd-trace-java#9190) - [@​PerfectSlayer](https://github.com/PerfectSlayer)) - ✨ add injection metadata fields to telemetry forwarder ([#​9185](DataDog/dd-trace-java#9185) - [@​sydney-tung](https://github.com/sydney-tung)) - 🐛 Avoid race conditions on feature discovery during Writer creation ([#​9173](DataDog/dd-trace-java#9173) - [@​daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Surface potential root cause when agent initialization errors ([#​9170](DataDog/dd-trace-java#9170) - [@​AlexeyKuznetsov-DD](https://github.com/AlexeyKuznetsov-DD)) - 💡 Support adding W3C baggage as span tags ([#​9169](DataDog/dd-trace-java#9169) - [@​rachelyangdog](https://github.com/rachelyangdog)) - ✨⚡ Align our default classloader excludes with OTel ([#​9161](DataDog/dd-trace-java#9161) - [@​mcculls](https://github.com/mcculls)) - ✨ Backpropagate container tags hash coming from the info endpoint ([#​9156](DataDog/dd-trace-java#9156) - [@​amarziali](https://github.com/amarziali)) - 🐛 Avoid race conditions and multiple agent discovery feature states ([#​9135](DataDog/dd-trace-java#9135) - [@​amarziali](https://github.com/amarziali)) ### Instrumentations #### AWS SDK instrumentation - ✨ Enhance Service Representation for Serverless ([#​9203](DataDog/dd-trace-java#9203) - [@​zarirhamza](https://github.com/zarirhamza)) #### gRPC instrumentation - 🐛 Add check to prevent injection of repeated GRPC headers ([#​9246](DataDog/dd-trace-java#9246) - [@​mhlidd](https://github.com/mhlidd)) #### JDBC instrumentation - 🐛 Fix duplicate trace injection for SQL Server and Oracle DBM full propagation mode ([#​9224](DataDog/dd-trace-java#9224) - [@​lu-zhengda](https://github.com/lu-zhengda)) #### Play Framework instrumentation - 🐛 Fix AppSec play.mvc.StatusHeader instrumentation for play 2.6 ([#​9160](DataDog/dd-trace-java#9160) - [@​manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am every weekday" in timezone Australia/Melbourne, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Never, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). GitOrigin-RevId: 9da36329ffa552291a640381780b608ef6513e29
What Does This Do
This change ensures that AppSec does not subscribe to the remote_config products
ASM
,ASM_DD
, andASM_DATA
by default when initialized in the defaultENABLED_INACTIVE
state.In this default state, it will only subscribe to the
ASM_FEATURES
product, enabling the system to support remote activation/deactivation. Once AppSec is actually activated, it will then subscribe to the remaining channels.The reverse also applies: when AppSec becomes inactive again, it will unsubscribe from
ASM
,ASM_DD
, andASM_DATA
, while continuing to listen toASM_FEATURES
to allow for potential reactivation.It will also silently acknowledge empty configurations
{}
that are currently being rejected by the WAF causing noise around remote config.Motivation
The primary goal is to avoid initializing the WAF (Web Application Firewall) for customers who do not have AppSec enabled. This helps reduce unnecessary resource usage and ensures that security components are only activated for relevant customers.
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]