-
Notifications
You must be signed in to change notification settings - Fork 311
Do not rely on timeout when testing smap entry cache #9265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
try (BufferedReader br = | ||
new BufferedReader(new InputStreamReader(Files.newInputStream(SMAPS_PATH)), 64 * 1024)) { | ||
new BufferedReader(new InputStreamReader(Files.newInputStream(smapsPath)), 64 * 1024)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch!
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 46 metrics, 13 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.51.1-SNAPSHOT~a88d630ff4, baseline=1.51.1-SNAPSHOT~8604e61da2
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.043 s) : 0, 1043101
Total [baseline] (10.768 s) : 0, 10767902
Agent [candidate] (1.053 s) : 0, 1053193
Total [candidate] (10.706 s) : 0, 10706273
section appsec
Agent [baseline] (1.214 s) : 0, 1213857
Total [baseline] (10.758 s) : 0, 10758288
Agent [candidate] (1.216 s) : 0, 1216083
Total [candidate] (10.784 s) : 0, 10784485
section iast
Agent [baseline] (1.181 s) : 0, 1180554
Total [baseline] (11.022 s) : 0, 11021741
Agent [candidate] (1.175 s) : 0, 1174951
Total [candidate] (10.913 s) : 0, 10913320
section profiling
Agent [baseline] (1.2 s) : 0, 1200126
Total [baseline] (10.915 s) : 0, 10914541
Agent [candidate] (1.19 s) : 0, 1190177
Total [candidate] (10.796 s) : 0, 10796368
gantt
title petclinic - break down per module: candidate=1.51.1-SNAPSHOT~a88d630ff4, baseline=1.51.1-SNAPSHOT~8604e61da2
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.423 ms) : 0, 1423
crashtracking [candidate] (1.432 ms) : 0, 1432
BytebuddyAgent [baseline] (730.846 ms) : 0, 730846
BytebuddyAgent [candidate] (736.927 ms) : 0, 736927
GlobalTracer [baseline] (241.632 ms) : 0, 241632
GlobalTracer [candidate] (243.654 ms) : 0, 243654
AppSec [baseline] (30.381 ms) : 0, 30381
AppSec [candidate] (30.587 ms) : 0, 30587
Debugger [baseline] (6.037 ms) : 0, 6037
Debugger [candidate] (6.079 ms) : 0, 6079
Remote Config [baseline] (648.611 µs) : 0, 649
Remote Config [candidate] (668.266 µs) : 0, 668
Telemetry [baseline] (11.232 ms) : 0, 11232
Telemetry [candidate] (12.754 ms) : 0, 12754
section appsec
crashtracking [baseline] (1.42 ms) : 0, 1420
crashtracking [candidate] (1.419 ms) : 0, 1419
BytebuddyAgent [baseline] (749.696 ms) : 0, 749696
BytebuddyAgent [candidate] (750.154 ms) : 0, 750154
GlobalTracer [baseline] (233.833 ms) : 0, 233833
GlobalTracer [candidate] (234.337 ms) : 0, 234337
AppSec [baseline] (168.285 ms) : 0, 168285
AppSec [candidate] (167.775 ms) : 0, 167775
Debugger [baseline] (7.106 ms) : 0, 7106
Debugger [candidate] (8.623 ms) : 0, 8623
Remote Config [baseline] (610.824 µs) : 0, 611
Remote Config [candidate] (619.832 µs) : 0, 620
Telemetry [baseline] (8.223 ms) : 0, 8223
Telemetry [candidate] (8.278 ms) : 0, 8278
IAST [baseline] (23.432 ms) : 0, 23432
IAST [candidate] (23.63 ms) : 0, 23630
section iast
crashtracking [baseline] (1.431 ms) : 0, 1431
crashtracking [candidate] (1.433 ms) : 0, 1433
BytebuddyAgent [baseline] (853.23 ms) : 0, 853230
BytebuddyAgent [candidate] (847.514 ms) : 0, 847514
GlobalTracer [baseline] (231.959 ms) : 0, 231959
GlobalTracer [candidate] (232.112 ms) : 0, 232112
AppSec [baseline] (27.478 ms) : 0, 27478
AppSec [candidate] (28.398 ms) : 0, 28398
Debugger [baseline] (7.676 ms) : 0, 7676
Debugger [candidate] (7.533 ms) : 0, 7533
Remote Config [baseline] (598.312 µs) : 0, 598
Remote Config [candidate] (602.437 µs) : 0, 602
Telemetry [baseline] (8.25 ms) : 0, 8250
Telemetry [candidate] (8.255 ms) : 0, 8255
IAST [baseline] (29.0 ms) : 0, 29000
IAST [candidate] (28.089 ms) : 0, 28089
section profiling
crashtracking [baseline] (1.407 ms) : 0, 1407
crashtracking [candidate] (1.392 ms) : 0, 1392
BytebuddyAgent [baseline] (765.325 ms) : 0, 765325
BytebuddyAgent [candidate] (758.688 ms) : 0, 758688
GlobalTracer [baseline] (221.883 ms) : 0, 221883
GlobalTracer [candidate] (220.552 ms) : 0, 220552
AppSec [baseline] (30.563 ms) : 0, 30563
AppSec [candidate] (30.196 ms) : 0, 30196
Debugger [baseline] (7.032 ms) : 0, 7032
Debugger [candidate] (6.28 ms) : 0, 6280
Remote Config [baseline] (709.053 µs) : 0, 709
Remote Config [candidate] (679.975 µs) : 0, 680
Telemetry [baseline] (15.181 ms) : 0, 15181
Telemetry [candidate] (15.893 ms) : 0, 15893
ProfilingAgent [baseline] (108.642 ms) : 0, 108642
ProfilingAgent [candidate] (107.381 ms) : 0, 107381
Profiling [baseline] (109.274 ms) : 0, 109274
Profiling [candidate] (108.024 ms) : 0, 108024
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.51.1-SNAPSHOT~a88d630ff4, baseline=1.51.1-SNAPSHOT~8604e61da2
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.042 s) : 0, 1042493
Total [baseline] (8.572 s) : 0, 8571722
Agent [candidate] (1.045 s) : 0, 1045305
Total [candidate] (8.621 s) : 0, 8620775
section iast
Agent [baseline] (1.177 s) : 0, 1177076
Total [baseline] (9.258 s) : 0, 9257522
Agent [candidate] (1.176 s) : 0, 1175691
Total [candidate] (9.297 s) : 0, 9296547
gantt
title insecure-bank - break down per module: candidate=1.51.1-SNAPSHOT~a88d630ff4, baseline=1.51.1-SNAPSHOT~8604e61da2
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.424 ms) : 0, 1424
crashtracking [candidate] (1.436 ms) : 0, 1436
BytebuddyAgent [baseline] (729.959 ms) : 0, 729959
BytebuddyAgent [candidate] (730.773 ms) : 0, 730773
GlobalTracer [baseline] (241.065 ms) : 0, 241065
GlobalTracer [candidate] (241.686 ms) : 0, 241686
AppSec [baseline] (30.528 ms) : 0, 30528
AppSec [candidate] (30.529 ms) : 0, 30529
Debugger [baseline] (6.051 ms) : 0, 6051
Debugger [candidate] (6.045 ms) : 0, 6045
Remote Config [baseline] (662.76 µs) : 0, 663
Remote Config [candidate] (659.102 µs) : 0, 659
Telemetry [baseline] (11.874 ms) : 0, 11874
Telemetry [candidate] (13.245 ms) : 0, 13245
section iast
crashtracking [baseline] (1.444 ms) : 0, 1444
crashtracking [candidate] (1.44 ms) : 0, 1440
BytebuddyAgent [baseline] (851.37 ms) : 0, 851370
BytebuddyAgent [candidate] (848.798 ms) : 0, 848798
GlobalTracer [baseline] (231.152 ms) : 0, 231152
GlobalTracer [candidate] (231.764 ms) : 0, 231764
AppSec [baseline] (27.07 ms) : 0, 27070
AppSec [candidate] (27.424 ms) : 0, 27424
Debugger [baseline] (5.776 ms) : 0, 5776
Debugger [candidate] (7.517 ms) : 0, 7517
Remote Config [baseline] (596.218 µs) : 0, 596
Remote Config [candidate] (590.976 µs) : 0, 591
Telemetry [baseline] (8.13 ms) : 0, 8130
Telemetry [candidate] (8.065 ms) : 0, 8065
IAST [baseline] (30.609 ms) : 0, 30609
IAST [candidate] (29.193 ms) : 0, 29193
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 12 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.51.1-SNAPSHOT~a88d630ff4, baseline=1.51.1-SNAPSHOT~8604e61da2
dateFormat X
axisFormat %s
section baseline
no_agent (36.156 ms) : 35863, 36450
. : milestone, 36156,
appsec (48.162 ms) : 47740, 48583
. : milestone, 48162,
code_origins (45.444 ms) : 45039, 45849
. : milestone, 45444,
iast (45.594 ms) : 45194, 45995
. : milestone, 45594,
profiling (49.614 ms) : 49148, 50080
. : milestone, 49614,
tracing (44.169 ms) : 43781, 44556
. : milestone, 44169,
section candidate
no_agent (36.517 ms) : 36222, 36813
. : milestone, 36517,
appsec (47.561 ms) : 47144, 47977
. : milestone, 47561,
code_origins (46.609 ms) : 46201, 47016
. : milestone, 46609,
iast (46.607 ms) : 46199, 47014
. : milestone, 46607,
profiling (50.259 ms) : 49776, 50742
. : milestone, 50259,
tracing (45.393 ms) : 45002, 45784
. : milestone, 45393,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.51.1-SNAPSHOT~a88d630ff4, baseline=1.51.1-SNAPSHOT~8604e61da2
dateFormat X
axisFormat %s
section baseline
no_agent (4.252 ms) : 4204, 4299
. : milestone, 4252,
iast (9.523 ms) : 9354, 9693
. : milestone, 9523,
iast_FULL (13.829 ms) : 13547, 14111
. : milestone, 13829,
iast_GLOBAL (10.283 ms) : 10093, 10472
. : milestone, 10283,
profiling (9.406 ms) : 9250, 9562
. : milestone, 9406,
tracing (7.635 ms) : 7528, 7741
. : milestone, 7635,
section candidate
no_agent (4.381 ms) : 4327, 4434
. : milestone, 4381,
iast (9.114 ms) : 8967, 9261
. : milestone, 9114,
iast_FULL (14.075 ms) : 13800, 14350
. : milestone, 14075,
iast_GLOBAL (10.327 ms) : 10131, 10522
. : milestone, 10327,
profiling (8.956 ms) : 8806, 9106
. : milestone, 8956,
tracing (7.535 ms) : 7430, 7640
. : milestone, 7535,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.51.1-SNAPSHOT~a88d630ff4, baseline=1.51.1-SNAPSHOT~8604e61da2
dateFormat X
axisFormat %s
section baseline
no_agent (1.477 ms) : 1466, 1489
. : milestone, 1477,
appsec (3.652 ms) : 3435, 3869
. : milestone, 3652,
iast (2.207 ms) : 2144, 2270
. : milestone, 2207,
iast_GLOBAL (2.248 ms) : 2184, 2311
. : milestone, 2248,
profiling (2.047 ms) : 1996, 2098
. : milestone, 2047,
tracing (2.013 ms) : 1964, 2061
. : milestone, 2013,
section candidate
no_agent (1.478 ms) : 1466, 1490
. : milestone, 1478,
appsec (3.647 ms) : 3432, 3862
. : milestone, 3647,
iast (2.199 ms) : 2137, 2261
. : milestone, 2199,
iast_GLOBAL (2.247 ms) : 2184, 2310
. : milestone, 2247,
profiling (2.062 ms) : 2010, 2113
. : milestone, 2062,
tracing (2.017 ms) : 1968, 2065
. : milestone, 2017,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.51.1-SNAPSHOT~a88d630ff4, baseline=1.51.1-SNAPSHOT~8604e61da2
dateFormat X
axisFormat %s
section baseline
no_agent (14.944 s) : 14944000, 14944000
. : milestone, 14944000,
appsec (14.798 s) : 14798000, 14798000
. : milestone, 14798000,
iast (18.699 s) : 18699000, 18699000
. : milestone, 18699000,
iast_GLOBAL (18.056 s) : 18056000, 18056000
. : milestone, 18056000,
profiling (15.803 s) : 15803000, 15803000
. : milestone, 15803000,
tracing (15.006 s) : 15006000, 15006000
. : milestone, 15006000,
section candidate
no_agent (14.991 s) : 14991000, 14991000
. : milestone, 14991000,
appsec (15.048 s) : 15048000, 15048000
. : milestone, 15048000,
iast (18.071 s) : 18071000, 18071000
. : milestone, 18071000,
iast_GLOBAL (18.145 s) : 18145000, 18145000
. : milestone, 18145000,
profiling (15.469 s) : 15469000, 15469000
. : milestone, 15469000,
tracing (14.876 s) : 14876000, 14876000
. : milestone, 14876000,
|
Signed-off-by: Nayeem Kamal <nayeem.kamal@datadoghq.com>
What Does This Do
Adds support to explicitly invalidate the smap entry cache for testing.
Motivation
Stop flaky test. Relying on exact timing is always troublesome.
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issue