v5.55.0 proposal #5841
Merged
v5.55.0 proposal #5841
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dd-trace-js[bot]](https://avatars.githubusercontent.com/in/1216021?s=60&v=4){kind=small}
remove flaky test
No need to install dependencies in the sandbox that isn't required.
* Going with TESTING_NO_INTEGRATION_SANDBOX
#5825) This check was added to allow running transforms for bindings when the current store has noop: true so that the previous store (without noop) would be restored. The current store being undefined was not considered at that point.
Closed
Overall package sizeSelf size: 9.61 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.6.0 | 30.47 MB | 30.47 MB | | @datadog/native-appsec | 8.5.2 | 19.33 MB | 19.34 MB | | @datadog/pprof | 5.8.0 | 12.55 MB | 12.92 MB | | @datadog/native-iast-taint-tracking | 4.0.0 | 11.72 MB | 11.73 MB | | @opentelemetry/core | 1.30.1 | 908.66 kB | 7.16 MB | | protobufjs | 7.5.3 | 2.95 MB | 5.6 MB | | @datadog/wasm-js-rewriter | 4.0.1 | 2.85 MB | 3.58 MB | | @datadog/native-metrics | 3.1.1 | 1.02 MB | 1.43 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.14.0 | 120.58 kB | 841.68 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.1 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.2 | 53.63 kB | 53.63 kB | | istanbul-lib-coverage | 3.2.2 | 34.37 kB | 34.37 kB | | rfdc | 1.4.1 | 27.15 kB | 27.15 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | dc-polyfill | 0.1.9 | 25.11 kB | 25.11 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | shell-quote | 1.8.2 | 23.54 kB | 23.54 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | mutexify | 1.4.0 | 5.71 kB | 8.74 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.4 | 3.96 kB | 3.96 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v5.x #5841 +/- ##
=======================================
Coverage ? 80.71%
=======================================
Files ? 464
Lines ? 19884
Branches ? 0
=======================================
Hits ? 16049
Misses ? 3835
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
BenchmarksBenchmark execution time: 2025-06-06 16:21:14 Comparing candidate commit 2414f40 in PR branch Found 0 performance improvements and 13 performance regressions! Performance is the same for 1253 metrics, 57 unstable metrics. scenario:log-skip-log-22
scenario:log-with-debug-22
scenario:log-with-error-22
scenario:log-without-log-22
scenario:spans-finish-immediately-18
scenario:spans-finish-immediately-20
scenario:startup-with-tracer-22
|
Datadog ReportBranch report: ✅ 0 Failed, 1070 Passed, 0 Skipped, 22m 7.2s Total Time |
* Add appsec.enabled origin gauge metric * Fix tests * Fix test * Restore gauge metric to original * Tiny improvements * Clean * Fix lint * Add unit test in config.spec.js * Send origin=unknown when origin is not supported by the metric * Use Set instead of Array
* Activate prefer-object-spread eslint rule * Activate prefer-object-has-own eslint rule * Activate no-useless-assignment eslint rule * Activate no-await-in-loop eslint rule * Activate operator-assignment eslint rule * Activate prefer-exponentiation-operator eslint rule * Activate no-else-return eslint rule * Activate no-implicit-coercion eslint rule * Fix potential race condition The assignment here could alter the id in a way that is conflicting with another iteration. * Activate unicorn/prefer-string-replace-all eslint rule * Update comma-dongle eslint rule The comma-dongle rule is deprecated and will be removed soon. Instead, use the @stylistic/comma-dangle eslint rule. This also allows comma dongles instead of prohibiting them. That way diffs are potentially smaller in the future. * Deactivate no-mixed-operators eslint rule The rule often resulted in less readable code due to the added brackets. The order of and and or should be well known and this is therefore not needed. * Multiple manuel small refactorings These add JSDoc, improve readability, and simplify code. * Revert "Activate no-await-in-loop eslint rule" This reverts commit d3596bf. * Reapply "Activate no-await-in-loop eslint rule" This reverts commit e3f810b. * Manuel edits for performance * Optimistically undo priority sampler changes * Test hotfix for changed behavior This is not a proper test fix and should be changed again * Optimistic reapply and perf regression fix * Fixup * Refactor DatadogSpan for readability and performance This is a very small performance improvement by now having to recreate a method and by directly adding a tag. It should also make it easier to read the code overall. It also becomes a tad safer by now iterating over the object using in anymore. * Activate unicorn/prefer-array-flat eslint rule * Refactor some code for readability and/or performance * Refactor telemetry handling for performance and simplicity * Activate unicorn/prefer-spread eslint rule * Revert "Refactor some code for readability and/or performance" This reverts commit f94f269. * Reapply "Refactor some code for readability and/or performance" This reverts commit 26a7b9b. * Revert "Refactor DatadogSpan for readability and performance" This reverts commit d8aff68. * Address comments * Fixup comments and conflicts * Fixup lint error * Test --------- Co-authored-by: Thomas Watson <thomas.watson@datadoghq.com>
Instead of sending the top 8 user frames in entry spans, this reduces the limit to just one.
* Fix startuplog crashing by serializing bigint Instead, handle bigint and symbols in the future. Also make the bigint which caused it private and use a getter for tests instead. * Drive-by cleanup * Improve tests and limit sampling rate * Add regression test * Fixup * Address comments
* Initial central configuration inversion draft * initial supported config file * updating versions * updating config-helper, replacing process.env in applyEnv, adding linter * adding new linter for process.env * updating supported configs * removing aliases from supportedConfigurations and adding all configs * removing process.env from config.js * updating handling of aliases * updating supported-configurations to only include DD_ env * Migrate process.env to getConfiguration * fixing ci tests * updating config-helper * Use proxy on process.env as temporary solution to setting envs This is needed to set environment variables during runtime. We likely have to think of alternatives. * Log missing ones * Add a few missing envs * Add many more missing configurations * Better process.env handling * Minor config improvements and throw instead of log for missing * Add many missing configurations to enable plugins * Enable many more configurations and improve alias overrides * Last missing hooks enabled configurations * Finish rough implementation * Simplify implementation and add first steps to move to alternative * Use runtime implementation to be on the safe side Using the proxy and the getter/setter pair was more complex and the user could theoretically have written code that would have worked around it. This also prevents the additional proxy overhead when using process.env. * Use json file and use stricter linters This also addresses issues found with the stricter linter * Remove unused import * Add CI validation and missing configuration * Check for missing configuration in getConfigurations() * Add JSDoc and switch back to logging missing entries * Add missing aws-sdk configurations * Remove unused configurations and fix lint error * Address comments and update CI job * Fixup missing rewrites * Stricter linter, add new envs, fixup rebase issues, more aliases * Add missing new environment variables * Add missing configuration * Add two more missing new environment variables * Simplify linter rule * Fix gitlab script * Deactivate gitlab ci for now * Simplify version to single char by default * Address comments and improve deprecation logging and alias detection This adds more tests as well to fully test the functionality. * Address additional comment --------- Co-authored-by: Matthew Li <matthew.li@datadoghq.com>
* Remove Header Injection vulnerability detection * Remove header sensitive analyzer * Remove set-header-fn helper
dd-trace-js
bot
force-pushed
the
v5.55.0-proposal
branch
from
e4feb70 to
2414f40
Compare
sabrenner
approved these changes
Jun 6, 2025
tlhunter
approved these changes
Jun 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
9c58aefabc] - (SEMVER-PATCH) [test optimization] Fix test optimization tests in v5 release line (Juan Antonio Fernández de Alba) #5844b9375e96f4] - (SEMVER-MINOR) Remove Header Injection vulnerability detection (Carles Capell) #58362fd2bcb301] - (SEMVER-PATCH) Initial central configuration inversion (Ruben Bridgewater) #5603e7bb334853] - (SEMVER-PATCH) Allow for reordering of files in the upload (Attila Szegedi) #58458045409ef6] - (SEMVER-PATCH) Fix startuplog crashing by serializing bigint (Ruben Bridgewater) #5842d9f0d7e414] - (SEMVER-PATCH) split ci jobs by team workflows (Roch Devost) #5817f1f87830b3] - (SEMVER-PATCH) [Code Origin for Spans] Only send top user frame in entry spans (Thomas Watson) #5763b4b18e3f6f] - (SEMVER-PATCH) [test optimization] Remove async resource usage from playwright (Juan Antonio Fernández de Alba) #5835c43be9ce5b] - (SEMVER-PATCH) [test optimization] Remove async resource usage from vitest (Juan Antonio Fernández de Alba) #583475c5a45758] - (SEMVER-PATCH) [test optimization] Remove async resource usage from cucumber (Juan Antonio Fernández de Alba) #5833d88c81e789] - (SEMVER-PATCH) [test optimization] Remove usage of async resource from jest (Juan Antonio Fernández de Alba) #5811429f0df6bc] - (SEMVER-PATCH) Update eslint rules and activate multiple more (Ruben Bridgewater) #5800c21e73b19a] - (SEMVER-MINOR) Add appsec.enabled origin gauge metric (Ugaitz Urien) #5794ccc1d32822] - (SEMVER-MINOR) feat(llmobs): propagatemlAppfor LLM proxy or gateway services (Sam Brenner) #5553634aad27e5] - (SEMVER-PATCH) fix remaining mysql/mariadb async resource usage (Roch Devost) #58401df163a69d] - (SEMVER-PATCH) [test optimization] Remove deprecated async resource from mocha (Juan Antonio Fernández de Alba) #5830aea6872e4d] - (SEMVER-PATCH) bump multer (Ilyas Shabi) #58282531473c11] - (SEMVER-PATCH) fix store binding transform not executing with undefined current store (Roch Devost) #58255d7a7f1899] - (SEMVER-PATCH) Fix overhead controller test flakyness (Ugaitz Urien) #5824f099f66fcb] - (SEMVER-PATCH) Don't use DD_ prefix on test-only env var (Attila Szegedi) #574200efd03830] - (SEMVER-PATCH) test: speed up DI integration tests (Thomas Watson) #5823cc2b8a6306] - (SEMVER-PATCH) ci(openai): remove flaky configuration test (Sam Brenner) #5822