refactor(di): rename upload_flush_interval to upload_interval_seconds (#13645)

Rename `upload_flush_interval` to `upload_interval_seconds`

- Rename upload_flush_interval config to upload_interval_seconds
- Add deprecation support for old upload.flush_interval config key
- Update uploader to use new config attribute name
- Deprecated config will be removed in version 4.0
- Add a release note documenting the change

Using the old option will raise the following warning:

> DeprecationWarning: DD_DYNAMIC_INSTRUMENTATION_UPLOAD_FLUSH_INTERVAL
has been deprecated and will be removed in version 4.0. Use
DD_DYNAMIC_INSTRUMENTATION_UPLOAD_INTERVAL_SECONDS instead

Refs: DEBUG-3997

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met 
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

Author: tylfin

ddtrace/debugging/_uploader.py

@@ -45,7 +45,7 @@ class LogsIntakeUploaderV1(ForksafeAwakeablePeriodicService):
     RETRY_ATTEMPTS = 3
 
     def __init__(self, interval: Optional[float] = None) -> None:
-        super().__init__(interval if interval is not None else di_config.upload_flush_interval)
+        super().__init__(interval if interval is not None else di_config.upload_interval_seconds)
 
         self._queue = self.__queue__(encoder=LogSignalJsonEncoder(di_config.service_name), on_full=self._on_buffer_full)
         self._collector = self.__collector__(self._queue)

ddtrace/settings/dynamic_instrumentation.py

@@ -86,12 +86,13 @@ class DynamicInstrumentationConfig(DDConfig):
         help="Timeout in seconds for uploading Dynamic Instrumentation payloads",
     )
 
-    upload_flush_interval = DDConfig.v(
+    upload_interval_seconds = DDConfig.v(
         float,
-        "upload.flush_interval",
+        "upload.interval_seconds",
         default=1.0,  # seconds
         help_type="Float",
         help="Interval in seconds for flushing the dynamic logs upload queue",
+        deprecations=[("upload.flush_interval", None, "4.0")],
     )
 
     diagnostics_interval = DDConfig.v(

releasenotes/notes/refactor-di-upload-interval-env-var-fea1f3a2d6ba6e52.yaml

@@ -0,0 +1,6 @@
+---
+deprecations:
+  - |
+    dynamic instrumentation: The ``DD_DYNAMIC_INSTRUMENTATION_UPLOAD_FLUSH_INTERVAL`` environment variable has been
+    deprecated in favor of ``DD_DYNAMIC_INSTRUMENTATION_UPLOAD_INTERVAL_SECONDS``. The old environment variable will be
+    removed in a future major release.

tests/telemetry/test_writer.py

@@ -366,7 +366,7 @@ def test_app_started_event_configuration_override(test_agent_session, run_python
         {"name": "DD_DYNAMIC_INSTRUMENTATION_REDACTED_IDENTIFIERS", "origin": "default", "value": "set()"},
         {"name": "DD_DYNAMIC_INSTRUMENTATION_REDACTED_TYPES", "origin": "default", "value": "set()"},
         {"name": "DD_DYNAMIC_INSTRUMENTATION_REDACTION_EXCLUDED_IDENTIFIERS", "origin": "default", "value": "set()"},
-        {"name": "DD_DYNAMIC_INSTRUMENTATION_UPLOAD_FLUSH_INTERVAL", "origin": "default", "value": 1.0},
+        {"name": "DD_DYNAMIC_INSTRUMENTATION_UPLOAD_INTERVAL_SECONDS", "origin": "default", "value": 1.0},
         {"name": "DD_DYNAMIC_INSTRUMENTATION_UPLOAD_TIMEOUT", "origin": "default", "value": 30},
         {"name": "DD_ENV", "origin": "default", "value": None},
         {"name": "DD_ERROR_TRACKING_HANDLED_ERRORS", "origin": "default", "value": ""},