Skip to content

Commit 28b010f

Browse files
mabdinuremmettbutlerwconti27
authored andcommitted
ci: skip flaky gunicorn, botocore and freezegun tests (#13662)
Recent Failures on main: - Freezegun: https://gitlab.ddbuild.io/DataDog/apm-reliability/dd-trace-py/-/jobs/980088085 - gunicorn: https://gitlab.ddbuild.io/DataDog/apm-reliability/dd-trace-py/-/jobs/977203066 - botocore: https://gitlab.ddbuild.io/DataDog/apm-reliability/dd-trace-py/-/jobs/980093469 ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) --------- Co-authored-by: Emmett Butler <723615+emmettbutler@users.noreply.github.com> Co-authored-by: William Conti <58711692+wconti27@users.noreply.github.com> (cherry picked from commit 9df7110)
1 parent 7615f42 commit 28b010f

File tree

3 files changed

+7
-0
lines changed

3 files changed

+7
-0
lines changed

tests/contrib/botocore/test.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1199,6 +1199,7 @@ def test_schematized_unspecified_service_sqs_client_v1(self):
11991199
assert spans[2].name == "aws.sqs.receive"
12001200

12011201
@mock_stepfunctions
1202+
@pytest.mark.xfail(reason="Failed to start or connect to state machine")
12021203
def test_stepfunctions_send_start_execution_trace_injection(self):
12031204
sf = self.session.create_client("stepfunctions", region_name="us-west-2", endpoint_url="http://localhost:4566")
12041205
sf.create_state_machine(
@@ -1220,6 +1221,7 @@ def test_stepfunctions_send_start_execution_trace_injection(self):
12201221
sf.delete_state_machine(stateMachineArn="arn:aws:states:us-west-2:000000000000:stateMachine:lincoln")
12211222

12221223
@mock_stepfunctions
1224+
@pytest.mark.xfail(reason="Failed to start or connect to state machine")
12231225
def test_stepfunctions_send_start_execution_trace_injection_with_array_input(self):
12241226
sf = self.session.create_client("stepfunctions", region_name="us-west-2", endpoint_url="http://localhost:4566")
12251227
sf.create_state_machine(
@@ -1239,6 +1241,7 @@ def test_stepfunctions_send_start_execution_trace_injection_with_array_input(sel
12391241
sf.delete_state_machine(stateMachineArn="arn:aws:states:us-west-2:000000000000:stateMachine:miller")
12401242

12411243
@mock_stepfunctions
1244+
@pytest.mark.xfail(reason="Failed to start or connect to state machine")
12421245
def test_stepfunctions_send_start_execution_trace_injection_with_true_input(self):
12431246
sf = self.session.create_client("stepfunctions", region_name="us-west-2", endpoint_url="http://localhost:4566")
12441247
sf.create_state_machine(

tests/contrib/freezegun/test_freezegun.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
from ddtrace.internal.utils.time import StopWatch
88
from ddtrace.trace import tracer as dd_tracer
99
from tests.contrib.pytest.test_pytest import PytestTestCaseBase
10+
from tests.utils import flaky
1011

1112

1213
class TestFreezegunTestCase:
@@ -71,6 +72,7 @@ def test_freezegun_configure_default_ignore_list_continues_to_ignore_ddtrace(sel
7172

7273

7374
class PytestFreezegunTestCase(PytestTestCaseBase):
75+
@flaky(1759346444)
7476
def test_freezegun_pytest_plugin(self):
7577
"""Tests that pytest's patching of freezegun in the v1 plugin version works"""
7678
import sys

tests/contrib/gunicorn/test_gunicorn.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
import pytest
1212

1313
from ddtrace.internal.utils.retry import RetryError # noqa:F401
14+
from tests.utils import flaky
1415
from tests.utils import snapshot_context
1516
from tests.webclient import Client
1617

@@ -165,6 +166,7 @@ def gunicorn_server(gunicorn_server_settings, tmp_path):
165166
)
166167

167168

169+
@flaky(1759346444, reason="Server startup is flaky in CI. It is unclear whether the server fails to start or shutdown.")
168170
@pytest.mark.skipif(sys.version_info >= (3, 11), reason="Gunicorn is only supported up to 3.10")
169171
def test_no_known_errors_occur(tmp_path):
170172
for gunicorn_server_settings in [

0 commit comments

Comments
 (0)