-
Notifications
You must be signed in to change notification settings - Fork 442
Merge profiling and libnative libraries. #13603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
ebe5c5a
to
61dd601
Compare
d77a90c
to
ef5d308
Compare
* Add new cmake file to find libnative components. * Modify dd_wrapper cmake in order to link against libnative. * Modify ddup cmake in order to link against libnative. * Change crashtracker compilation so it links agains libnative. Link to python runtime as a workaround to solve secondary dependencies from libnative.so (temporary until the crashtracker PyO3 bindings are ready).
ef5d308
to
96a1446
Compare
…uild_standalone.sh
96a1446
to
b48d766
Compare
* Call build_libnative from project's root folder. * Fix FindLibNative in order not to include libnative whole folder structure. * Workaround test linking.
07c8bb9
to
5659b91
Compare
cce59ac
to
adebc6d
Compare
While investigating the root cause of slow builds, we discovered that the main culprit is our current usage of CMake. In the long-run, we would want to migrate away from CMake, at least when building Python native extensions. IIUC here we go in the opposite direction as we remove the rust extension from setup.py and move the heavy-lifting to CMake + more custom scripts. My concern is that this would contribute to the build time, while also giving us even more code to maintain. |
adebc6d
to
7a4b2c1
Compare
7a4b2c1
to
7458185
Compare
Consolidate profiling a libnative dependencies in order to save some binary size due to duplicated symbols:
Checklist
Reviewer Checklist