Skip to content

chore(ci): remove freezegun from hatch since it's in riot #13632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 11, 2025

Conversation

juanjux
Copy link
Collaborator

@juanjux juanjux commented Jun 10, 2025

On #13612 I added freezegun to riot but forgot to remove it from hatch. This fixes it.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

Signed-off-by: Juanjo Alvarez <juanjo.alvarezmartinez@datadoghq.com>
@juanjux juanjux self-assigned this Jun 10, 2025
@juanjux juanjux requested a review from a team as a code owner June 10, 2025 08:40
@juanjux juanjux added changelog/no-changelog A changelog entry is not required for this PR. CI labels Jun 10, 2025
@juanjux juanjux requested a review from avara1986 June 10, 2025 08:40
Copy link
Contributor

github-actions bot commented Jun 10, 2025

CODEOWNERS have been resolved as:

hatch.toml                                                              @DataDog/python-guild
tests/contrib/suitespec.yml                                             @DataDog/apm-core-python @DataDog/apm-idm-python

Copy link
Contributor

github-actions bot commented Jun 10, 2025

Bootstrap import analysis

Comparison of import times between this PR and base.

Summary

The average import time from this PR is: 279 ± 4 ms.

The average import time from base is: 281 ± 3 ms.

The import time difference between this PR and base is: -2.4 ± 0.2 ms.

Import time breakdown

The following import paths have shrunk:

ddtrace.auto 2.039 ms (0.73%)
ddtrace.bootstrap.sitecustomize 1.382 ms (0.50%)
ddtrace.bootstrap.preload 1.382 ms (0.50%)
ddtrace.internal.remoteconfig.client 0.644 ms (0.23%)
ddtrace 0.657 ms (0.24%)

@pr-commenter
Copy link

pr-commenter bot commented Jun 10, 2025

Benchmarks

Benchmark execution time: 2025-06-10 09:30:40

Comparing candidate commit 0bbe6bd in PR branch juanjux/remote-freezegun-from-hatch with baseline commit e8f98ef in branch main.

Found 0 performance improvements and 2 performance regressions! Performance is the same for 551 metrics, 3 unstable metrics.

scenario:iastaspectsospath-ospathnormcase_aspect

  • 🟥 execution_time [+407.258ns; +454.689ns] or [+11.778%; +13.150%]

scenario:telemetryaddmetric-1-distribution-metric-1-times

  • 🟥 execution_time [+365.263ns; +417.834ns] or [+12.524%; +14.326%]

@emmettbutler emmettbutler requested review from a team as code owners June 10, 2025 13:30
@emmettbutler emmettbutler enabled auto-merge (squash) June 10, 2025 13:30
@emmettbutler emmettbutler merged commit 1ed307e into main Jun 11, 2025
817 of 818 checks passed
@emmettbutler emmettbutler deleted the juanjux/remote-freezegun-from-hatch branch June 11, 2025 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR. CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants