Skip to content

chore(profiling): delete set_max_nframes and its references #13641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 24 commits into
base: main
Choose a base branch
from

Conversation

alyshawang
Copy link
Contributor

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@alyshawang alyshawang requested a review from a team as a code owner June 10, 2025 18:57
Copy link
Contributor

github-actions bot commented Jun 10, 2025

CODEOWNERS have been resolved as:

ddtrace/internal/datadog/profiling/dd_wrapper/include/ddup_interface.hpp  @DataDog/profiling-python
ddtrace/internal/datadog/profiling/dd_wrapper/include/sample_manager.hpp  @DataDog/profiling-python
ddtrace/internal/datadog/profiling/dd_wrapper/src/ddup_interface.cpp    @DataDog/profiling-python
ddtrace/internal/datadog/profiling/dd_wrapper/src/sample_manager.cpp    @DataDog/profiling-python
ddtrace/internal/datadog/profiling/dd_wrapper/test/test_api.cpp         @DataDog/profiling-python
ddtrace/internal/datadog/profiling/dd_wrapper/test/test_forking.cpp     @DataDog/profiling-python
ddtrace/internal/datadog/profiling/dd_wrapper/test/test_initialization.cpp  @DataDog/profiling-python
ddtrace/internal/datadog/profiling/dd_wrapper/test/test_threading.cpp   @DataDog/profiling-python
ddtrace/internal/datadog/profiling/dd_wrapper/test/test_utils.hpp       @DataDog/profiling-python
ddtrace/internal/datadog/profiling/ddup/_ddup.pyi                       @DataDog/profiling-python
ddtrace/internal/datadog/profiling/ddup/_ddup.pyx                       @DataDog/profiling-python
ddtrace/profiling/profiler.py                                           @DataDog/profiling-python

@alyshawang alyshawang changed the title chore(profiling): delete set_max_nframes and referencesl chore(profiling): delete set_max_nframes and references Jun 10, 2025
@alyshawang alyshawang changed the title chore(profiling): delete set_max_nframes and references chore(profiling): delete set_max_nframes and its references Jun 10, 2025
@alyshawang alyshawang requested review from a team as code owners June 10, 2025 19:04
Copy link
Contributor

github-actions bot commented Jun 10, 2025

Bootstrap import analysis

Comparison of import times between this PR and base.

Summary

The average import time from this PR is: 284 ± 6 ms.

The average import time from base is: 284 ± 5 ms.

The import time difference between this PR and base is: 0.2 ± 0.2 ms.

The difference is not statistically significant (z = 0.61).

Import time breakdown

The following import paths have shrunk:

ddtrace.auto 1.859 ms (0.65%)
ddtrace.bootstrap.sitecustomize 1.184 ms (0.42%)
ddtrace.bootstrap.preload 1.184 ms (0.42%)
ddtrace.internal.remoteconfig.client 0.596 ms (0.21%)
ddtrace 0.675 ms (0.24%)
ddtrace.internal._unpatched 0.028 ms (0.01%)
json 0.028 ms (0.01%)
json.decoder 0.028 ms (0.01%)
re 0.028 ms (0.01%)
enum 0.028 ms (0.01%)
types 0.028 ms (0.01%)

@pr-commenter
Copy link

pr-commenter bot commented Jun 12, 2025

Benchmarks

Benchmark execution time: 2025-06-12 18:42:08

Comparing candidate commit 5bdfccf in PR branch alysha.wang/max_stack_frames with baseline commit 1b249e1 in branch main.

Found 0 performance improvements and 1 performance regressions! Performance is the same for 563 metrics, 6 unstable metrics.

scenario:iastaspects-format_map_aspect

  • 🟥 execution_time [+425.774ns; +507.000ns] or [+13.274%; +15.806%]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants