-
Notifications
You must be signed in to change notification settings - Fork 441
perf(rc): improve performance of subprocess service sharing #13651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This change will only write service names to the shared file queue only if we have not shared that service name yet. This improvement avoids locking and writing to disk every time we call Pin.onto which can happen a lot when database connections are cycled/recreated frequently. It also helps ensure that the same process doesn't continually write the same service name to the same file over and over again.
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 282 ± 5 ms. The average import time from base is: 286 ± 7 ms. The import time difference between this PR and base is: -3.4 ± 0.3 ms. Import time breakdownThe following import paths have shrunk:
|
BenchmarksBenchmark execution time: 2025-06-16 19:21:19 Comparing candidate commit 4848444 in PR branch Found 0 performance improvements and 4 performance regressions! Performance is the same for 474 metrics, 2 unstable metrics. scenario:iastaspectsospath-ospathnormcase_aspect
scenario:iastaspectsospath-ospathsplit_aspect
scenario:iastaspectsospath-ospathsplitdrive_aspect
scenario:telemetryaddmetric-flush-1-metric
|
I have to fix up the multiple_os_tests which use this test. |
This change will only write service names to the shared file queue only if we have not shared that service name yet. This improvement avoids locking and writing to disk every time we call Pin.onto which can happen a lot when database connections are cycled/recreated frequently. It also helps ensure that the same process doesn't continually write the same service name to the same file over and over again. I also updated the tests to use subprocesses/forking as is expected with it's behavior for RC. ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) (cherry picked from commit b686305)
… 3.9] (#13685) Backport b686305 from #13651 to 3.9. This change will only write service names to the shared file queue only if we have not shared that service name yet. This improvement avoids locking and writing to disk every time we call Pin.onto which can happen a lot when database connections are cycled/recreated frequently. It also helps ensure that the same process doesn't continually write the same service name to the same file over and over again. I also updated the tests to use subprocesses/forking as is expected with it's behavior for RC. ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) Co-authored-by: Brett Langdon <brett.langdon@datadoghq.com> Co-authored-by: Christophe Papazian <114495376+christophe-papazian@users.noreply.github.com>
This change will only write service names to the shared file queue only if we have not shared that service name yet.
This improvement avoids locking and writing to disk every time we call Pin.onto which can happen a lot when database connections are cycled/recreated frequently.
It also helps ensure that the same process doesn't continually write the same service name to the same file over and over again.
I also updated the tests to use subprocesses/forking as is expected with it's behavior for RC.
Checklist
Reviewer Checklist