Skip to content

chore(ci): remove duplicated functions #13706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 18, 2025

Conversation

avara1986
Copy link
Member

Cherry pick some refactor that I made in security controls: #13655

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@avara1986 avara1986 added the ASM Application Security Monitoring label Jun 18, 2025
Copy link
Contributor

CODEOWNERS have been resolved as:

tests/appsec/integrations/django_tests/utils.py                         @DataDog/asm-python
tests/appsec/iast/_ast/conftest.py                                      @DataDog/asm-python
tests/appsec/iast/aspects/conftest.py                                   @DataDog/asm-python
tests/appsec/iast/aspects/test_add_aspect.py                            @DataDog/asm-python
tests/appsec/iast/conftest.py                                           @DataDog/asm-python
tests/appsec/iast/iast_utils.py                                         @DataDog/asm-python
tests/appsec/iast/secure_marks/conftest.py                              @DataDog/asm-python
tests/appsec/iast/taint_sinks/test_command_injection.py                 @DataDog/asm-python
tests/appsec/iast/taint_sinks/test_insecure_cookie.py                   @DataDog/asm-python
tests/appsec/iast/taint_sinks/test_ssrf.py                              @DataDog/asm-python
tests/appsec/iast/taint_sinks/test_stacktrace_leak.py                   @DataDog/asm-python
tests/appsec/iast/taint_sinks/test_vulnerability_detection.py           @DataDog/asm-python
tests/appsec/iast/taint_sinks/test_weak_cipher.py                       @DataDog/asm-python
tests/appsec/iast/taint_tracking/conftest.py                            @DataDog/asm-python
tests/appsec/integrations/django_tests/conftest.py                      @DataDog/asm-python
tests/appsec/integrations/django_tests/test_appsec_django.py            @DataDog/asm-python
tests/appsec/integrations/django_tests/test_iast_django.py              @DataDog/asm-python
tests/appsec/integrations/packages_tests/conftest.py                    @DataDog/asm-python
tests/contrib/dbapi/test_dbapi_appsec.py                                @DataDog/asm-python

@avara1986 avara1986 added changelog/no-changelog A changelog entry is not required for this PR. and removed backport 2.21 labels Jun 18, 2025
Copy link
Contributor

github-actions bot commented Jun 18, 2025

Bootstrap import analysis

Comparison of import times between this PR and base.

Summary

The average import time from this PR is: 275 ± 2 ms.

The average import time from base is: 276 ± 2 ms.

The import time difference between this PR and base is: -1.58 ± 0.09 ms.

Import time breakdown

The following import paths have shrunk:

ddtrace.auto 1.976 ms (0.72%)
ddtrace.bootstrap.sitecustomize 1.309 ms (0.48%)
ddtrace.bootstrap.preload 1.309 ms (0.48%)
ddtrace.internal.remoteconfig.client 0.623 ms (0.23%)
ddtrace 0.668 ms (0.24%)
ddtrace.internal._unpatched 0.029 ms (0.01%)
json 0.029 ms (0.01%)
json.decoder 0.029 ms (0.01%)
re 0.029 ms (0.01%)
enum 0.029 ms (0.01%)
types 0.029 ms (0.01%)

@avara1986 avara1986 marked this pull request as ready for review June 18, 2025 11:58
@avara1986 avara1986 requested a review from a team as a code owner June 18, 2025 11:58
@pr-commenter
Copy link

pr-commenter bot commented Jun 18, 2025

Benchmarks

Benchmark execution time: 2025-06-18 12:20:23

Comparing candidate commit 0452394 in PR branch avara1986/APPSEC-56901-iast_security_controls_2 with baseline commit ff35f5b in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 561 metrics, 3 unstable metrics.

@avara1986 avara1986 merged commit b80973a into main Jun 18, 2025
514 of 520 checks passed
@avara1986 avara1986 deleted the avara1986/APPSEC-56901-iast_security_controls_2 branch June 18, 2025 13:43
sydney-tung pushed a commit that referenced this pull request Jun 24, 2025
Cherry pick some refactor that I made in security controls:
#13655

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met 
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASM Application Security Monitoring changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants