Add support for ActiveRecord async queries #4872
Draft
+90
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**What does this PR do?** Adds support for Rails load_async feature by implementing the publish method and enhancing the ActiveSupport notifications subscription system with proper callback handling and error management. **Motivation:** Rails load_async feature requires support for the publish method in ActiveSupport notifications to handle asynchronous event processing. The existing subscription system needed enhancements to properly support this Rails feature. **Change log entry** Added support for Rails load_async feature in ActiveSupport notifications subscription **Additional Notes:** - Implements publish method for complete event lifecycle handling - Adds robust error handling for callbacks and handlers - Includes comprehensive test coverage (38 examples, 0 failures) - Ensures system continues functioning when individual callbacks fail **How to test the change?** Run: bundle exec rspec spec/datadog/tracing/contrib/active_support/notifications/subscription_spec.rb Tests verify load_async functionality including: - publish method event lifecycle - Handler and Callbacks error handling - Integration with Rails async event processing
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3465
Async query execution, introduced in Rails 7.0.0 and expanded in Rails 7.1.0, now correctly parents the async spans to the context where the query resolution happens.
This context is the place where the results from the async query were consumed. For example:
async_relation = Model.load_asyncschedules the async query, but the query span is only attached to the active trace atrelation.loadtime). This only affects parenting, as the execution time of the async span is always accurate.The active trace, started in a thread, will now see spans from a background async thread attached to it.
Change log entry
Yes. Add support for ActiveRecord async queries
Additional Notes:
How to test the change?