-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add bar chart widget file #30739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add bar chart widget file #30739
Conversation
Add bar chart widget Add relative links to bar chart widget
✅ Documentation Team ReviewThe documentation team has approved this pull request. Thank you for your contribution! |
Preview links (active after the
|
Created an editorial review card: DOCS-11652 |
quick question: is there reasoning behind excluding the API section? it seems like most other widgets have one, with the model and example (ref from toplist). it would be nice if it were included directly on the page so users can have an idea of what the schema looks like. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, Esther! I made some comments about some steps that I'm sure make sense in context or with more experience, but that I worried might leave a newer user feeling a bit lost. Nothing that isn't already in other related pages, though, so I'm approving it if the level of detail was a conscious decision 🙂
|
||
### Configuration | ||
|
||
1. Select from the available data sources. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe this makes more sense in the context of creating dashboards (I can see that this isn't the only page it's on), but this had me confused about what the user is supposed to select or where. Usually we orient the user on where they're supposed to be in the app and something along the lines of adding the widget to the dashboard before getting into the configuration settings. Is there a reason we skip over that here? Even if there is, can we add some more context?
* Metrics: See the [querying ][1] documentation to configure a metric query. | ||
* Events: See the [log search][2] documentation to configure a log event query. | ||
3. (Optional) Modify query with a [formula][3]. | ||
4. Customize your graph. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what this means or how you would do it...does this mean the graph title? Or the time span maybe? And then I imagine you probably have to click Save or something?
Co-authored-by: Janine Chan <64388808+janine-c@users.noreply.github.com>
Thanks so much for your feedback @janine-c! I created a tasker to reevaluate the setup for Widgets and update the docs en masse. These could use an audit! |
What does this PR do? What is the motivation?
Merge instructions
Merge readiness:
Pending PM review