-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[Cloud Run] Split up In-Process docs #30742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Documentation Team ReviewThe documentation team has approved this pull request. Thank you for your contribution! |
0f697fe
to
c1241d7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i like that we're pulling the language docs apart. is this the standard way to do it in the docs repo?
i do have some concerns about the serverless init setup docs and the environment variables, though.
content/en/serverless/google_cloud_run/containers/in_process/nodejs.md
Outdated
Show resolved
Hide resolved
content/en/serverless/google_cloud_run/containers/in_process/nodejs.md
Outdated
Show resolved
Hide resolved
content/en/serverless/google_cloud_run/containers/in_process/nodejs.md
Outdated
Show resolved
Hide resolved
content/en/serverless/google_cloud_run/containers/in_process/nodejs.md
Outdated
Show resolved
Hide resolved
@apiarian-datadog |
…tion more clear; add more logs information; clarify that `winston` and `structlog` are external packages
Created a DOCS card for a more in-depth review. |
content/en/serverless/google_cloud_run/containers/in_process/_index.md
Outdated
Show resolved
Hide resolved
content/en/serverless/google_cloud_run/containers/in_process/dotnet.md
Outdated
Show resolved
Hide resolved
text: 'Correlating .NET Logs and Traces' | ||
--- | ||
|
||
## 1. Install the Tracer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we have public sample apps we can link to?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought we decided not to link to sample apps? I will ask Piyali
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay got confirmation, we can link them!
f78669a
to
1302b66
Compare
content/en/serverless/google_cloud_run/containers/in_process/dotnet.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking good.
|
||
For more information, see [Correlating .NET Logs and Traces][3]. | ||
|
||
4. **Configure your application**. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we include some a note in here or somewhere else about the service label thing in cloud run?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can always improve further! but since this PR touches a lot of files and has a high potential of running into merge conflicts if we keep it open much longer, I'd like to merge this and tackle further changes in a new PR.
What does this PR do? What is the motivation?
https://datadoghq.atlassian.net/browse/SVLS-7302
Merge instructions
Merge readiness:
Additional notes
Will get to Sidecar Containers in a future PR. Then, Gen 2 functions