Skip to content

Conversation

@yuandesu
Copy link
Contributor

@yuandesu yuandesu commented Feb 10, 2026

What does this PR do? What is the motivation?

Adds a note to the Ingestion Controls doc stating that on short timeframes (e.g. 1h or 4h), the Effective Sampling Rate may show below 100% even when set to 100% because total traces are estimated—and that this does not mean traces are missing or the actual rate is below 100%.

Per APMS-18460 and Slack: the rate is computed from an estimated total trace count (we can’t get an exact count from how trace data is stored). That estimation can make the displayed value slightly under 100% on short timeframes. This PR documents that so customers know it’s expected and not missing data.

Merge instructions

Merge readiness:

  • Ready for merge

For Datadog employees:

Your branch name MUST follow the <name>/<description> convention and include the forward slash (/). Without this format, your pull request will not pass CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.

If your branch doesn't follow this format, rename it or create a new branch and PR.

[6/5/2025] Merge queue has been disabled on the documentation repo. If you have write access to the repo, the PR has been reviewed by a Documentation team member, and all of the required checks have passed, you can use the Squash and Merge button to merge the PR. If you don't have write access, or you need help, reach out in the #documentation channel in Slack.

Additional notes

@yuandesu yuandesu requested a review from a team as a code owner February 10, 2026 05:28
@yuandesu yuandesu changed the title Yuandesu/ingestion control sampling rate note Ingestion control sampling rate note Feb 10, 2026
@github-actions
Copy link
Contributor

Preview links (active after the build_preview check completes)

Modified Files

Copy link
Contributor

@rtrieu rtrieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi yuan, thanks for the PR! made a suggestion that uses the active voice and simplifies the statements a bit. please request re-review when ready and i'll see it automatically.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
**Note**: On short time frames (such as 1 hour or 4 hours), the Effective Sampling Rate may display below `100%` even when set to `100%`, because the calculation estimates total traces. This does not mean traces are missing or that the actual rate is below 100%.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants