[PLINT-524] Sending data from vSAN using Resource Metadata #19070

rahulkaukuntla · 2024-11-15T16:16:26Z

What does this PR do?

This PR enables sending vSAN cluster data using Resource Metadata, so that vSAN clusters can be viewed in the Resource Catalog. Changes to the backend had to be enabled in order for this new data to be written to the correct table, so that the Resource Catalog can pick it up correctly.

Motivation

Review checklist (to be filled by reviewers)

Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

codecov · 2024-11-15T16:29:10Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.10%. Comparing base (19e46a8) to head (1d07d6a).
Report is 1018 commits behind head on master.

Additional details and impacted files

Flag	Coverage Δ
activemq	`?`
cassandra	`?`
hive	`?`
hivemq	`?`
hudi	`?`
ignite	`?`
jboss_wildfly	`?`
kafka	`?`
presto	`?`
solr	`?`
vsphere	`∅ <100.00%> (∅)`

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

NouemanKHAL · 2024-12-18T09:43:39Z

vsphere/datadog_checks/vsphere/api.py

@@ -439,9 +440,12 @@ def get_vsan_metrics(self, cluster_nested_elts, entity_ref_ids, id_to_tags, star
                )
            health_metrics.append(processed_health_metrics)

+            redapl_cluster_data = {'name': cluster_reference.name, 'vcenter_server': self.config.hostname}
            vsan_perf_query_spec = []
            for nested_id in nested_ids:
                for entity_type in entity_ref_ids[id_to_tags[nested_id][0]]:


... entity_ref_ids[id_to_tags[nested_id][0]]:

is this access completely safe?

Yes, I create all of these dictionaries: entity_ref_ids,id_to_tags,nested_id in this method. I define that every collected resource be included in id_to_tags by their id, and I define that their "0" value be the type of the resource. Basically, I just want to see, for each resource within a given cluster, what type of resource it is (either a host or the cluster itself, for now), and then depending on the type of the resource, choose the entities (list of metrics) that are appropriate to find for it.

vsphere/datadog_checks/vsphere/vsphere.py

vsphere/tests/test_unit.py

vsphere/datadog_checks/vsphere/api.py

vsphere/datadog_checks/vsphere/vsphere.py

vsphere/tests/test_unit.py

vsphere/datadog_checks/vsphere/api.py

…into rahul/vsphere-to-evp

rtrieu

Minor feedback to comply with our style guide.

vsphere/README.md

vsphere/assets/configuration/spec.yaml

Co-authored-by: Rosa Trieu <107086888+rtrieu@users.noreply.github.com>

adding script to send data to redapl

b6c59f3

datadog-assets bot added agent/review-requested ecosystems/review-requested product/review-requested labels Nov 15, 2024

datadog-agent-integrations-bot bot added the integration/vsphere label Nov 15, 2024

added a changelog

03be133

rahulkaukuntla added 2 commits November 15, 2024 13:19

not sending performance metrics to redapl anymore

76871d1

blacklisting folder from license header validation

0747c50

datadog-agent-integrations-bot bot added dev/tooling dev_package labels Nov 19, 2024

rahulkaukuntla added the changelog/no-changelog label Nov 19, 2024

rahulkaukuntla changed the title ~~[PLINT-524] Sending data from vSAN to EvP intake~~ [PLINT-524] Sending data from vSAN to REDAPL Dec 9, 2024

rahulkaukuntla added 4 commits December 9, 2024 11:11

using agent metadata pipeline

2ff59e6

adding testing coverage for relabel map

e47ff39

removing last comma

b098424

small updates

58b8111

rahulkaukuntla removed the dev/tooling label Dec 12, 2024

rahulkaukuntla marked this pull request as ready for review December 17, 2024 17:56

rahulkaukuntla requested a review from a team December 17, 2024 17:56

rahulkaukuntla requested a review from a team as a code owner December 17, 2024 17:56

NouemanKHAL reviewed Dec 18, 2024

View reviewed changes

rahulkaukuntla requested a review from NouemanKHAL December 18, 2024 15:43

sarah-witt reviewed Dec 18, 2024

View reviewed changes

rahulkaukuntla changed the title ~~[PLINT-524] Sending data from vSAN to REDAPL~~ [PLINT-524] Sending data from vSAN using Resource Metadata Dec 18, 2024

addressing comments

21cab22

rahulkaukuntla requested a review from a team as a code owner December 18, 2024 21:15

datadog-assets bot added the docs/review-requested label Dec 18, 2024

Merge branch 'master' of https://github.com/DataDog/integrations-core …

6aaded6

…into rahul/vsphere-to-evp

rtrieu previously approved these changes Dec 18, 2024

View reviewed changes

vsphere/README.md Outdated Show resolved Hide resolved

vsphere/assets/configuration/spec.yaml Outdated Show resolved Hide resolved

datadog-assets bot added docs/approved and removed docs/review-requested labels Dec 18, 2024

Update vsphere/README.md

b35a057

Co-authored-by: Rosa Trieu <107086888+rtrieu@users.noreply.github.com>

rahulkaukuntla dismissed rtrieu’s stale review via b35a057 December 18, 2024 21:30

datadog-assets bot added docs/review-requested and removed docs/approved labels Dec 18, 2024

grammar fix

a558a25

rahulkaukuntla requested a review from rtrieu December 18, 2024 21:37

rtrieu previously approved these changes Dec 18, 2024

View reviewed changes

datadog-assets bot added docs/approved and removed docs/review-requested labels Dec 18, 2024

rahulkaukuntla requested a review from sarah-witt December 18, 2024 21:42

including the cost multiplier

b638de1

rahulkaukuntla dismissed rtrieu’s stale review via b638de1 January 14, 2025 15:14

temporal-github-worker-1 bot added docs/review-requested and removed docs/approved labels Jan 14, 2025

fixing cost test

1d07d6a

rahulkaukuntla marked this pull request as draft February 20, 2025 16:26

NouemanKHAL removed their request for review June 25, 2025 09:07

dd-devflow bot closed this Jul 17, 2025

dd-devflow bot deleted the rahul/vsphere-to-evp branch July 17, 2025 00:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[PLINT-524] Sending data from vSAN using Resource Metadata #19070

[PLINT-524] Sending data from vSAN using Resource Metadata #19070

Uh oh!

rahulkaukuntla commented Nov 15, 2024 •

edited

Loading

Uh oh!

codecov bot commented Nov 15, 2024 •

edited

Loading

Uh oh!

NouemanKHAL Dec 18, 2024

Uh oh!

rahulkaukuntla Dec 18, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rtrieu left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

[PLINT-524] Sending data from vSAN using Resource Metadata #19070

[PLINT-524] Sending data from vSAN using Resource Metadata #19070

Uh oh!

Conversation

rahulkaukuntla commented Nov 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Motivation

Review checklist (to be filled by reviewers)

Uh oh!

codecov bot commented Nov 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

NouemanKHAL Dec 18, 2024

Choose a reason for hiding this comment

Uh oh!

rahulkaukuntla Dec 18, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rtrieu left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rahulkaukuntla commented Nov 15, 2024 •

edited

Loading

codecov bot commented Nov 15, 2024 •

edited

Loading