Auto-activate nodejs manifest tests #5510
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dd-octo-sts[bot]](https://avatars.githubusercontent.com/in/1157446?s=80&v=4){kind=small}
This commit was created from the local commit with hash 1be97c096c0a392803c992301e734d446fac50d1.
|
|
simon-id
reviewed
Oct 21, 2025
Comment on lines
+102
to
+105
| Test_API_Security_Custom_Data_Classification_Multiple_Scanners: v6.0.0-pre # auto activation: might not be the earliest working version | ||
| Test_API_Security_Custom_Data_Classification_Negative: v6.0.0-pre # auto activation: might not be the earliest working version | ||
| Test_API_Security_Custom_Data_Classification_Processor_Override: v6.0.0-pre # auto activation: might not be the earliest working version | ||
| Test_API_Security_Custom_Data_Classification_Scanner: v6.0.0-pre # auto activation: might not be the earliest working version |
There was a problem hiding this comment.
@nccatoni hahaha you fell into the trap, v6.0.0-pre doesn't actually exists. It's the version we have in our master branch, but we never release it. Currently the latest version is 5.72.0, thus these tests won't run correctly.
Also your parser replace inline comments by comments above, but here you're adding inline comments, which mean they'll be reformated at the next pass 😆
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automated activation of easy-win tests for nodejs