Auto-activate java manifest tests #5511
Conversation
![dd-octo-sts[bot]](https://avatars.githubusercontent.com/in/1157446?s=80&v=4){kind=small}
This commit was created from the local commit with hash d61ea40e66aaa9d6f613cbd4115d53508981be9d.
|
|
| resteasy-netty3: incomplete_test_app (endpoint does not support fetching headers injected to downstream call) | ||
| spring-boot: v1.50.0 | ||
| spring-boot-3-native: incomplete_test_app (endpoint does not support fetching headers injected to downstream call) | ||
| Test_Baggage_Headers_Malformed: |
There was a problem hiding this comment.
The following baggage tests should not be enabled. They pass by chance, but as the comments say, the weblog applications are not configured properly to propagate HTTP Headers.
I see that this is auto-enabled. Is there a way to have an exclude list? This isn't the first time Baggage tests have been incorrectly enabled in a PR.
There was a problem hiding this comment.
Hi @mhlidd,
It's a use case of negative assertion. The issue is not in the activation, but inside the : it test must not pass if it shouldn't. The reason is that, when the test will be activated, if for some unwanted reason, we broke the feature it in a way it get back to the state before its implementation, the test won't complain. So it's not achieving its goal.
We must add in those test an assertion that check the presence of something, either in the data sent by the tracer, or in the logs. Do you see any good candidate for that ?
There was a problem hiding this comment.
The issue here is with the make_distant_call of weblog applications not properly sending injected headers into the downstream request. Coincidentally, with malformed baggage headers, we expect no headers coming out in our assertions and the test will pass by chance. This explains why the malformed tests XPass, but the basic test fails.
We do have debug logs for the malformed header scenarios, but the log messages are Java specific. Do you think this is something worth including as an edge case for Java here? (We would have to include DD_TRACE_DEBUG=true as part of the env for this test scenario for this to work).
2 participants
Automated activation of easy-win tests for java