Skip to content

Auto-activate java manifest tests #5511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −9
Open

Auto-activate java manifest tests #5511

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions manifests/java.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1035,7 +1035,7 @@ tests/:
Test_Ssrf_Telemetry:
'*': v1.39.0
spring-boot-3-native: irrelevant (GraalVM. Tracing support only)
vertx3: missing_feature (APPSEC-55781)
vertx3: v1.55.0-SNAPSHOT+2a7ceb65fb # auto activation: might not be the earliest working version
vertx4: missing_feature (APPSEC-55781)
Test_Ssrf_Telemetry_V2: missing_feature
Test_Ssrf_UrlQuery:
Expand Down Expand Up @@ -2193,22 +2193,22 @@ tests/:
spring-boot-3-native: incomplete_test_app (endpoint does not support fetching headers injected to downstream call)
Test_Baggage_Headers_Malformed:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The following baggage tests should not be enabled. They pass by chance, but as the comments say, the weblog applications are not configured properly to propagate HTTP Headers.

I see that this is auto-enabled. Is there a way to have an exclude list? This isn't the first time Baggage tests have been incorrectly enabled in a PR.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mhlidd,

It's a use case of negative assertion. The issue is not in the activation, but inside the : it test must not pass if it shouldn't. The reason is that, when the test will be activated, if for some unwanted reason, we broke the feature it in a way it get back to the state before its implementation, the test won't complain. So it's not achieving its goal.

We must add in those test an assertion that check the presence of something, either in the data sent by the tracer, or in the logs. Do you see any good candidate for that ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue here is with the make_distant_call of weblog applications not properly sending injected headers into the downstream request. Coincidentally, with malformed baggage headers, we expect no headers coming out in our assertions and the test will pass by chance. This explains why the malformed tests XPass, but the basic test fails.

We do have debug logs for the malformed header scenarios, but the log messages are Java specific. Do you think this is something worth including as an edge case for Java here? (We would have to include DD_TRACE_DEBUG=true as part of the env for this test scenario for this to work).

'*': v1.53.0
akka-http: incomplete_test_app (endpoint does not support fetching headers injected to downstream call)
akka-http: v1.55.0-SNAPSHOT+2a7ceb65fb # auto activation: might not be the earliest working version
jersey-grizzly2: incomplete_test_app (endpoint does not support fetching headers injected to downstream call)
play: incomplete_test_app (endpoint does not support fetching headers injected to downstream call)
ratpack: incomplete_test_app (endpoint does not support fetching headers injected to downstream call)
play: v1.55.0-SNAPSHOT+2a7ceb65fb # auto activation: might not be the earliest working version
ratpack: v1.55.0-SNAPSHOT+2a7ceb65fb # auto activation: might not be the earliest working version
resteasy-netty3: incomplete_test_app (endpoint does not support fetching headers injected to downstream call)
spring-boot: v1.50.0
spring-boot-3-native: incomplete_test_app (endpoint does not support fetching headers injected to downstream call)
spring-boot-3-native: v1.55.0-SNAPSHOT+2a7ceb65fb # auto activation: might not be the earliest working version
Test_Baggage_Headers_Malformed2:
'*': v1.53.0
akka-http: incomplete_test_app (endpoint does not support fetching headers injected to downstream call)
akka-http: v1.55.0-SNAPSHOT+2a7ceb65fb # auto activation: might not be the earliest working version
jersey-grizzly2: incomplete_test_app (endpoint does not support fetching headers injected to downstream call)
play: incomplete_test_app (endpoint does not support fetching headers injected to downstream call)
ratpack: incomplete_test_app (endpoint does not support fetching headers injected to downstream call)
play: v1.55.0-SNAPSHOT+2a7ceb65fb # auto activation: might not be the earliest working version
ratpack: v1.55.0-SNAPSHOT+2a7ceb65fb # auto activation: might not be the earliest working version
resteasy-netty3: incomplete_test_app (endpoint does not support fetching headers injected to downstream call)
spring-boot: v1.50.0
spring-boot-3-native: incomplete_test_app (endpoint does not support fetching headers injected to downstream call)
spring-boot-3-native: v1.55.0-SNAPSHOT+2a7ceb65fb # auto activation: might not be the earliest working version
Test_Baggage_Headers_Max_Bytes:
'*': incomplete_test_app (endpoint does not support fetching headers injected to downstream call)
spring-boot: v1.50.0
Expand Down
Loading