Skip to content

enforce memfd name format #5545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 21, 2025
Merged

enforce memfd name format #5545

merged 4 commits into from
Oct 21, 2025

Conversation

@raphaelgavache
Copy link
Member

@raphaelgavache raphaelgavache commented Oct 17, 2025 •
edited
Loading

Enforce memfd to have a suffix of 8 bytes with an ID. This was on spec, and is about to be used on datadog-agent
Matching java tracer fix: DataDog/dd-trace-java#9796

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@github-actions
Copy link
Contributor

github-actions bot commented Oct 17, 2025

CODEOWNERS have been resolved as:

tests/parametric/test_process_discovery.py                              @DataDog/system-tests-core @DataDog/apm-sdk-capabilities

@raphaelgavache raphaelgavache mentioned this pull request Oct 17, 2025
Merged
@raphaelgavache raphaelgavache marked this pull request as ready for review October 20, 2025 13:53
@raphaelgavache raphaelgavache requested review from a team as code owners October 20, 2025 13:53
@raphaelgavache raphaelgavache requested review from zacharycmontoya and removed request for a team October 20, 2025 13:53
pawelchcki
pawelchcki approved these changes Oct 20, 2025
View reviewed changes
Copy link
Collaborator

@pawelchcki pawelchcki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good 🙇

@raphaelgavache raphaelgavache enabled auto-merge (squash) October 20, 2025 21:31
@raphaelgavache raphaelgavache merged commit 24b97a7 into main Oct 21, 2025
788 of 790 checks passed
@raphaelgavache raphaelgavache deleted the raphael/enforce_memfdformat branch October 21, 2025 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pawelchcki pawelchcki pawelchcki approved these changes

@zacharycmontoya zacharycmontoya Awaiting requested review from zacharycmontoya zacharycmontoya is a code owner automatically assigned from DataDog/apm-sdk-capabilities

Assignees

No one assigned

Labels

run-all-scenarios

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@raphaelgavache @pawelchcki