Skip to content

Conversation

@zacharycmontoya
Copy link
Contributor

Motivation

The OTLP exporter accepts general configurations that apply to all signals (traces, metrics, logs) and it also accepts signal-specific configurations. We want to test both for configurations we recognize.

Changes

Adds two test cases to assert that OTEL_EXPORTER_OTLP_METRICS_PROTOCOL is respected, inside the Test_Otel_Metrics_Configuration_OTLP_Exporter_Metrics_Protocol test class.

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

…CS_PROTOCOL is tested in the Test_Otel_Metrics_Configuration_OTLP_Exporter_Metrics_Protocol test class
@github-actions
Copy link
Contributor

CODEOWNERS have been resolved as:

tests/parametric/test_otel_metrics.py                                   @DataDog/system-tests-core @DataDog/apm-sdk-capabilities

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants