Skip to content

Commit f6f3f78

Browse files
committed
fix(ci): preserve apex CNAME on Pages deploy to keep custom domain
peaceiris wipes the target with keep_files=false and the built site has no root CNAME, so each deploy unbound datalab-platform.com (site 404). Assisted-by: Claude Opus 4.8
1 parent ab70440 commit f6f3f78

1 file changed

Lines changed: 8 additions & 0 deletions

File tree

.github/workflows/pages.yml

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -156,6 +156,10 @@ jobs:
156156
publish_branch: main
157157
publish_dir: ./site
158158
keep_files: false
159+
# Re-write the apex CNAME on every deploy: peaceiris wipes the target
160+
# with keep_files=false, and the built site has no root CNAME, so
161+
# without this the custom domain binding is lost (site 404s).
162+
cname: datalab-platform.com
159163
commit_message: "Update documentation from ${{ github.repository }}@${{ github.sha }}"
160164

161165
- name: Deploy to DataLab-Platform.github.io (via SSH deploy key)
@@ -167,4 +171,8 @@ jobs:
167171
publish_branch: main
168172
publish_dir: ./site
169173
keep_files: false
174+
# Re-write the apex CNAME on every deploy: peaceiris wipes the target
175+
# with keep_files=false, and the built site has no root CNAME, so
176+
# without this the custom domain binding is lost (site 404s).
177+
cname: datalab-platform.com
170178
commit_message: "Update documentation from ${{ github.repository }}@${{ github.sha }}"

0 commit comments

Comments
 (0)