Skip to content

Commit f809fd9

Browse files
committed
Fix: resolve issue with dialog box parameters not displaying during arithmetic operations and signal interpolation
Fix #137
1 parent b8ece3d commit f809fd9

File tree

2 files changed

+4
-0
lines changed

2 files changed

+4
-0
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ See DataLab [roadmap page](https://datalab-platform.com/en/contributing/roadmap.
1616

1717
🛠️ Bug fixes:
1818

19+
* Fixed [Issue #137](https://github.com/DataLab-Platform/DataLab/issues/137) - Arithmetic operations and signal interpolation: dialog box with parameters is not displayed
1920
* Fixed [Issue #136](https://github.com/DataLab-Platform/DataLab/issues/136) - When processing a signal or an image, the analysis result is kept from original object
2021
* Before this fix, when processing a signal or an image (e.g. when applying a filter, a threshold, etc.), the analysis result was kept from the original object, and was not updated with the new data. Thus the analysis result was not meaningful anymore, and was misleading the user.
2122
* This is now fixed: the analysis result is now removed when processing a signal or an image. However it is not recalculated automatically, because there is no way to know which analysis result should be recalculated (e.g. if the user has applied a filter, should the FWHM be recalculated?) - besides, the current implementation of the analysis features does not allow to recalculate the analysis results automatically when the data is modified. The user has to recalculate the analysis results manually if needed.

cdl/core/gui/processor/base.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -756,6 +756,9 @@ def compute_n1n(
756756
"""
757757
if (edit is None or param is None) and paramclass is not None:
758758
edit, param = self.init_param(param, paramclass, title, comment)
759+
if param is not None:
760+
if edit and not param.edit(parent=self.panel.parent()):
761+
return
759762

760763
objs = self.panel.objview.get_sel_objects(include_groups=True)
761764
objmodel = self.panel.objmodel

0 commit comments

Comments
 (0)