Revert sqrl functions #61
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marvin Froeder <marvin@datasqrl.com>
This reverts commit 0c2370f.
Signed-off-by: Marvin Froeder <marvin@datasqrl.com>
Signed-off-by: Marvin Froeder <marvin@datasqrl.com>
There was a problem hiding this comment.
Pull Request Overview
This PR reverts SQRL functions by removing all SQRL dependencies and SQRL‑specific files while introducing AutoRegisterSystemFunction.
- Removed SQRL‑related files from multiple modules (JDBC, H2, flexible JSON, flexible CSV).
- Updated the Uber-jar build workflow to adjust the working directory configuration.
Reviewed Changes
Copilot reviewed 185 out of 193 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| sqrl-jdbc-1.16/README.md | Removed outdated note about SQRL requirements. |
| sqrl-h2-1.16/H2RowConverter.java | Removed SQRL‑specific H2 row converter implementation. |
| sqrl-h2-1.16/H2DialectFactory.java | Removed SQRL‑specific H2 dialect factory implementation. |
| sqrl-h2-1.16/H2Dialect.java | Removed SQRL‑specific H2 dialect implementation. |
| sqrl-flexible-json/SqrlRowDataToJsonConverters.java | Removed SQRL‑specific JSON row data converters. |
| sqrl-flexible-json/SqrlJsonRowDataSerializationSchema.java | Removed SQRL‑specific JSON serialization schema class. |
| sqrl-flexible-json/FlexibleJsonFormat.java | Removed SQRL‑specific flexible JSON format changes. |
| sqrl-flexible-json/README.md | Removed outdated SQRL‑specific notes. |
| sqrl-flexible-csv/FlexibleCsv.java | Removed SQRL‑specific flexible CSV implementation. |
| .github/workflows/uber-jar.yml | Updated Maven working directory from ./flink-jar-runner/target/ to ./target/. |
Files not reviewed (8)
- pom.xml: Language not supported
- sqrl-flexible-csv/pom.xml: Language not supported
- sqrl-flexible-csv/src/main/resources/META-INF/services/org.apache.flink.table.factories.Factory: Language not supported
- sqrl-flexible-json/pom.xml: Language not supported
- sqrl-flexible-json/src/main/resources/META-INF/services/org.apache.flink.table.factories.Factory: Language not supported
- sqrl-h2-1.16/pom.xml: Language not supported
- sqrl-h2-1.16/src/main/resources/META-INF/services/org.apache.flink.connector.jdbc.dialect.JdbcDialectFactory: Language not supported
- sqrl-jdbc-1.16/pom.xml: Language not supported
Signed-off-by: Marvin Froeder <marvin@datasqrl.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created AutoRegisterSystemFunction and removed all sqrl dependencies