Skip to content

Test system function service discovery #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 2, 2025
Merged

Test system function service discovery #63

merged 3 commits into from
Apr 2, 2025

Conversation

velo
Copy link
Collaborator

@velo velo commented Apr 2, 2025

No description provided.

Signed-off-by: Marvin Froeder <marvin@datasqrl.com>
@velo velo requested review from mbroecheler and Copilot April 2, 2025 16:23
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

The PR introduces a test system function along with updates to docker-compose configurations and system function setup in the SQL executor.

  • Added a new system function (Upper) to convert strings to uppercase.
  • Updated docker-compose volume mounts for test classes and added jar mappings.
  • Introduced additional logging and exception handling around automatic system function registration.

Reviewed Changes

Copilot reviewed 4 out of 7 changed files in this pull request and generated 2 comments.

File Description
src/test/resources/systemfunction/src/main/java/sample/Upper.java Added system function implementation with a doc comment that needs to be updated to reflect functionality.
src/test/docker/docker-compose.yml Updated volume mounts for schema, libraries, and jar files to support test configurations.
src/main/java/com/datasqrl/SqlExecutor.java Added logging for system function registration and enhanced exception handling.
Files not reviewed (3)
  • pom.xml: Language not supported
  • src/test/resources/sql/flink.sql: Language not supported
  • src/test/resources/systemfunction/pom.xml: Language not supported
Comments suppressed due to low confidence (2)

src/test/docker/docker-compose.yml:33

  • The path to the Postgres schema file has been changed to './test-classes/sqrl/postgres-schema.sql'. Please verify that this update aligns with your project structure and test environment configuration.
- ./sqrl/postgres-schema.sql:/docker-entrypoint-initdb.d/database-schema.sql:ro

src/test/docker/docker-compose.yml:67

  • New volume mounts for jar files have been added. Please ensure that the paths and jar versions are correct and consistent with the deployment environment.
- ./flink-sql-runner-1.0.0-SNAPSHOT-service.jar:/opt/flink/lib/flink-sql-runner-service.jar

velo and others added 2 commits April 2, 2025 13:41
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Marvin Froeder <marvin@datasqrl.com>
@velo velo merged commit b59aac9 into main Apr 2, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant