Skip to content

Precarious test coverage #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 10, 2025
Merged

Precarious test coverage #70

merged 3 commits into from
Apr 10, 2025

Conversation

velo
Copy link
Collaborator

@velo velo commented Apr 10, 2025

Managed to instrument our jar so we can extract test coverage from FlinkMainIT

As is, this is unmaintainable, FlinkMainIT depends on TouchTest running to create a accessible jacoco.exec seed

And the configuration is spread across all the files on this PR.

Bettet than nothing, but very fragile.

Signed-off-by: Marvin Froeder <marvin@datasqrl.com>
@velo
Copy link
Collaborator Author

velo commented Apr 10, 2025

Coverage before this change:
image

After:
image

81% coverage, not bad, not bad at all

@velo velo requested review from Copilot and mbroecheler April 10, 2025 01:39
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.

Files not reviewed (1)
  • flink-sql-runner/pom.xml: Language not supported
Comments suppressed due to low confidence (2)

flink-sql-runner/src/test/java/com/datasqrl/FlinkMainIT.java:254

  • Returning 0 when the destination file exists may skip necessary re-instrumentation, potentially leading to outdated coverage data. Consider re-instrumenting or validating whether the source jar has changed before skipping.
if (dest.exists()) {

flink-sql-runner/src/main/docker/docker-compose.yml:69

  • The docker-compose file mounts './jacoco.job.exec' while TouchTest creates the file in the 'target' directory; please confirm that the mounted path accurately reflects the location of the generated file.
- ./jacoco.job.exec:/opt/flink/jacoco.exec

velo and others added 2 commits April 9, 2025 22:41
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Marvin Froeder <marvin@datasqrl.com>
@velo velo merged commit 9221fd5 into main Apr 10, 2025
3 checks passed
@velo velo deleted the coverage branch April 10, 2025 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant