Fix JavaScript variable dartPdfJsBaseUrl access from Dart#1707
Open
yorifuji wants to merge 1 commit into
Open
Conversation
|
Is there any news about merge this fix? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title
Fix JavaScript variable
dartPdfJsBaseUrlaccess from DartDescription
Thank you for maintaining such an excellent library.
This pull request addresses an issue with how the
dartPdfJsBaseUrlJavaScript variable is accessed from Dart code. The previous implementation did not correctly handle the conversion from the JavaScript string to Dart, leading to potential exceptions during runtime when retrieving it.Changes
Updated the Dart code to correctly convert the
dartPdfJsBaseUrlvariable from JavaScript to Dart’s string type.