feat: reject ip_stub with trailing dot across all entry points #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add ValueError in zebra_day.__init__.scan() - Add CLI error+exit(1) in bootstrap and printer scan commands - Add HTTP 400 in web scan routes (scan + scan/stream) - Core print_mgr already had validation; now all 6 entry points covered - Fix test mock: use http.client instead of subprocess.Popen - 13 new tests (317 total passing)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reject any
ip_stub/ip-stubparameter ending with.at all 6 entry points:zebra_day.__init__.scan()→ValueErrorzday bootstrap --ip-stub→ error + exit 1zday printer scan --ip-stub→ error + exit 1GET /config/scan→ HTTP 400GET /config/scan/stream→ HTTP 400print_mgr.probe_zebra_printers_add_to_printers_json()(already existed)Also fixed test mock: was mocking
subprocess.Popenbut scan useshttp.client— caused infinite hang.317 tests passing.
Pull Request opened by Augment Code with guidance from the PR author