fix: Resolve ruff B904 errors + cleanup unused imports#35
Merged
Conversation
- Add 'from exc' to Exception raises in except blocks (cli/dynamo, web/api) - Add 'from None' to ImportError raises (intentional suppression) - Add 'from None' to VersionConflictError raises (backends/dynamo) - Remove unused imports in test files (os, Path, boto3, platform, pytest, PropertyMock) - Fix unsorted imports in web/app.py - Reformat 7 files via ruff format - All 334 tests pass, ruff check + format clean
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix all 26 B904 ruff errors (exception chaining) plus auto-fix unused imports and formatting.
Changes
B904 Exception Chaining (25 fixes)
zebra_day/backends/dynamo.py(2):from NoneonVersionConflictErrorraiseszebra_day/cli/dynamo.py(13):from excontyper.Exit(1)raiseszebra_day/web/routers/api.py(10):from exc/from NoneonHTTPExceptionraisesAuto-fixes (13)
os,Path,boto3,platform,pytest,PropertyMock)web/app.pytest_cli_dynamo.pystsinbackends/dynamo.pyFormatting
ruff formatVerification
ruff check zebra_day tests✅ruff format --check zebra_day tests✅pytest tests/ -v --tb=short→ 334/334 pass ✅Pull Request opened by Augment Code with guidance from the PR author