Merge pull request #68 from Debashis08/feature-update-to-mingw

core: clang-tidy added, cmake updated

Author: Debashis08

.clang-tidy

@@ -0,0 +1,27 @@
+Checks: >
+  readability-identifier-naming
+
+WarningsAsErrors: '*'
+
+HeaderFilterRegex: '(Headers/.*|SourceCodes/.*)'
+
+CheckOptions:
+  # Private member variables
+  - key: readability-identifier-naming.PrivateMemberPrefix
+    value: _
+  - key: readability-identifier-naming.PrivateMemberCase
+    value: camelBack
+
+  # Member function (non-static, non-const, non-virtual)
+  - key: readability-identifier-naming.MethodCase
+    value: CamelCase
+
+  # Class names
+  - key: readability-identifier-naming.ClassCase
+    value: CamelCase
+
+  # Optional, but ensures errors are reported instead of silently skipped
+  - key: readability-identifier-naming.IgnoreFailures
+    value: false
+  - key: readability-identifier-naming.IgnoreFailedSplit
+    value: false

.github/workflows/datastructures-algorithms-ci-cd.yaml

@@ -0,0 +1,34 @@
+name: datastructures-algorithms-ci-cd
+
+on:
+  push:
+    branches: [ main, release ]
+  pull_request:
+    branches: [ main, release ]
+
+jobs:
+  lint-build-test:
+    runs-on: ubuntu-latest
+
+    steps:
+    - name: Checkout code
+      uses: actions/checkout@v3
+
+    - name: Install dependencies
+      run: |
+        sudo apt-get update
+        sudo apt-get install -y cmake libgtest-dev clang-tidy
+
+    - name: Configure CMake
+      run: cmake -S . -B build -DCMAKE_EXPORT_COMPILE_COMMANDS=ON
+
+    - name: Run clang-tidy
+      run: |
+        find Headers -name '*.h' -o -name '*.hpp' ; find SourceCodes -name '*.cpp' -o -name '*.cc' -o -name '*.cxx' | \
+        xargs clang-tidy -p build --warnings-as-errors=*
+
+    - name: Build
+      run: cmake --build build
+
+    - name: Run tests
+      run: ctest --test-dir build --output-on-failure

.github/workflows/dsa-ci.yaml

@@ -1,11 +1,24 @@
-# CMakeList.txt : CMake project for DataStructures_Algorithms, include source and define
-# project specific logic here.
-#
+# CMakeList.txt : CMake for datastructures-algorithms
 cmake_minimum_required (VERSION 3.10)
 project ("datastructures-algorithms")
 
 set(CMAKE_CXX_STANDARD 14)
 set(CMAKE_CXX_STANDARD_REQUIRED ON)
+set(CMAKE_EXPORT_COMPILE_COMMANDS ON)
+
+
+# .clang-tidy settp
+find_program(CLANG_TIDY_EXE NAMES "clang-tidy")
+if(CLANG_TIDY_EXE)
+    message(STATUS "clang-tidy found: ${CLANG_TIDY_EXE}")
+    set(CMAKE_CXX_CLANG_TIDY
+        "${CLANG_TIDY_EXE}"
+        "--config-file=${CMAKE_SOURCE_DIR}/.clang-tidy"
+        "--extra-arg-before=-Wno-unknown-warning-option"
+        "--extra-arg-before=-Wno-c++98-compat-pedantic"
+        "--quiet"
+    )
+endif()
 
 include_directories(${CMAKE_SOURCE_DIR}/Headers)
 
@@ -17,9 +30,10 @@ FetchContent_Declare(
   googletest
   URL https://github.com/google/googletest/archive/03597a01ee50ed33e9dfd640b249b4be3799d395.zip
 )
+
 # For Windows: Prevent overriding the parent project's compiler/linker settings
 set(gtest_force_shared_crt ON CACHE BOOL "" FORCE)
 
 enable_testing()
 
-add_subdirectory(Tests)
+add_subdirectory(Tests)

CMakeLists.txt

@@ -21,20 +21,20 @@ namespace BinarySearchTree
 	{
 	private:
 		Node* _root;
-		void _InsertNode(Node* node);
-		Node* _FindNode(int value);
-		Node* _FindMinimumValueNode(Node* node);
-		Node* _FindMaximumValueNode(Node* node);
-		Node* _FindSuccessorNode(Node* node);
-		Node* _FindPredecessorNode(Node* node);
-		void _Transplant(Node* nodeU, Node* nodeV);
-		void _DeleteNode(Node* node);
-		void _RecursiveInorderTraversal(Node* node, vector<int>& result);
-		void _RecursivePreorderTraversal(Node* node, vector<int>& result);
-		void _RecursivePostorderTraversal(Node* node, vector<int>& result);
-		void _MorrisInorderTraversal(Node* node, vector<int>& result);
-		void _MorrisPreorderTraversal(Node* node, vector<int>& result);
-		void _MorrisPostorderTraversal(Node* node, vector<int>& result);
+		void InsertBinarySearchTreeNode(Node* node);
+		Node* FindBinarySearchTreeNode(int value);
+		Node* FindBinarySearchTreeMinimumValueNode(Node* node);
+		Node* FindBinarySearchTreeMaximumValueNode(Node* node);
+		Node* FindSuccessorBinarySearchTreeNode(Node* node);
+		Node* FindPredecessorBinarySearchTreeNode(Node* node);
+		void TransplantBinarySearchTreeNode(Node* nodeU, Node* nodeV);
+		void DeleteBinarySearchTreeNode(Node* node);
+		void RecursiveInorderTraversal(Node* node, vector<int>& result);
+		void RecursivePreorderTraversal(Node* node, vector<int>& result);
+		void RecursivePostorderTraversal(Node* node, vector<int>& result);
+		void MorrisInorderTraversal(Node* node, vector<int>& result);
+		void MorrisPreorderTraversal(Node* node, vector<int>& result);
+		void MorrisPostorderTraversal(Node* node, vector<int>& result);
 	public:
 		BinarySearchTree();
 		void InsertNode(int value);

Headers/0002_Tree/0001_BinarySearchTree.h

@@ -24,7 +24,7 @@ namespace DepthFirstSearch
     class Graph
     {
     private:
-        int time;
+        int _time;
         map<Node*, list<Node*>> _adjlist;
         map<int, Node*> _nodeMap;
         Node* MakeOrFindNode(int value);

Headers/0003_Graph/0002_DepthFirstSearch.h

@@ -25,8 +25,8 @@ namespace TopologicalSort
     class Graph
     {
     private:
-        int time;
-        bool hasCycle;
+        int _time;
+        bool _hasCycle;
         map<Node*, list<Node*>> _adjlist;
         map<int, Node*> _nodeMap;
         list<Node*> _topologicalSortedNodeList;

Headers/0003_Graph/0003_TopologicalSort.h

@@ -24,7 +24,7 @@ namespace StronglyConnectedComponents
     class Graph
     {
     private:
-        int time;
+        int _time;
         map<Node*, list<Node*>> _adjlistG;
         map<Node*, list<Node*>> _adjlistT;
         map<int, Node*> _nodeMap;

Headers/0003_Graph/0004_StronglyConnectedComponents.h

@@ -1,5 +1,4 @@
 #include "../Headers/0001_Basics/Node.h"
-using namespace std;
 
 Node::Node()
 {