Improvements on some strings. #109
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this typo is actually intentional. Naming objects "Placement" used to make expression engine crash, most likely because of ambiguity with object's Placement property. |
|
Ah, ok. Since you said name, I am guessing the label can have this typo fixed. Am I right? If yes, then I could fix the label them, if you are interested. What about the other changes removing colon from the menu items? Are they good? |
|
labels are treated as names by the expression engine, aren't they? I don't remember if there is a story behind the colons. Could be to make it obvious that it's a group command in the customization dialog (where one can customize toolbars and bind keyboard shortcuts). I don't have any strong opinions about them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @DeepSOIC this PR removes extra colon from some menus stated here, #108 and also fix a typo on the "Placement" that was "Placment" before.