Add types for react-dual-listbox#58390
Add types for react-dual-listbox#58390gabritto merged 2 commits intoDefinitelyTyped:masterfrom wKovacs64:react-dual-listbox
Conversation
|
@wKovacs64 Thank you for submitting this PR! This is a live comment which I will keep updated. 1 package in this PR
Code ReviewsThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged. You can test the changes of this PR in the Playground. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 58390,
"author": "wKovacs64",
"headCommitOid": "1a44ed967abb32a9e8bb9e2bf705349b7a2cf7cc",
"mergeBaseOid": "298fc85b03091e075bff1ab5776d577b25f93b3f",
"lastPushDate": "2022-01-25T19:18:35.000Z",
"lastActivityDate": "2022-01-25T19:26:01.000Z",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": "react-dual-listbox",
"kind": "add",
"files": [
{
"path": "types/react-dual-listbox/index.d.ts",
"kind": "definition"
},
{
"path": "types/react-dual-listbox/react-dual-listbox-tests.tsx",
"kind": "test"
},
{
"path": "types/react-dual-listbox/tsconfig.json",
"kind": "package-meta-ok"
},
{
"path": "types/react-dual-listbox/tslint.json",
"kind": "package-meta-ok"
}
],
"owners": [],
"addedOwners": [
"wKovacs64"
],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [
{
"type": "stale",
"reviewer": "martin-badin",
"date": "2022-01-25T18:55:30.000Z",
"abbrOid": "1799f20"
}
],
"mainBotCommentID": 1019563428,
"ciResult": "pass"
} |
|
🔔 @wKovacs64 — you're the only owner, but it would still be good if you find someone to review this PR in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...) |
|
@martin-badin Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review? |
* Add types for react-dual-listbox * Remove examples and reformat comments for consistency
Please fill in this template.
npm test <package to test>.If adding a new definition:
.d.tsfiles generated via--declarationdts-gen --dt, not by basing it on an existing project.tslint.jsonshould contain{ "extends": "@definitelytyped/dtslint/dt.json" }, and no additional rules.tsconfig.jsonshould havenoImplicitAny,noImplicitThis,strictNullChecks, andstrictFunctionTypesset totrue.Most of the credit goes to @jmfirth for the initial work done in jakezatecky/react-dual-listbox#37 a few years ago.