added audio recorder - onStop doesn't pick up#20
added audio recorder - onStop doesn't pick up#20urosran wants to merge 2 commits intoDeltaCircuit:masterfrom
Conversation
|
Hello! Thank @0x006F you for this library and @urosran for collaborating in it 👏 I know it's not my business, but a couple of things makes me think that this PR should not be merged in its current state:
My two cents. |
|
Besides the console.logs and alerts (we can clean up at any time), I guess @danigb has a valid point in this case. As we discussed in #19 , even though this polyfill kinda work, it doesn't support video capturing yet. So, we're losing one of our key features in here. I sincerely apologize for this delayed replies. I'm having numerous meetings / plannings at my full-time + work. Sorry! |
| mediaRecorderOptions = null, | ||
| }: ReactMediaRecorderProps) => { | ||
| const mediaRecorder = useRef<MediaRecorder | null>(null); | ||
| window.MediaRecorder = AudioRecorder |
There was a problem hiding this comment.
May be overwrite only if mediarecorder doesn’t exist
( As suggested in the audio recorder polyfill readme)
if (!window.MediaRecorder) {
document.write(
decodeURI('%3Cscript defer src="/polyfill.js">%3C/script>')
}
No description provided.