GRIDEDIT-1970 removed macOS-13 runner. Added macOS-15 runner #494
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates GitHub Actions workflow configurations to replace the deprecated macOS-13 runner with macOS-15, aligning the CI/CD pipeline with newer macOS runner versions.
Key Changes:
- Removed
macos-13runner from the build matrix in feature/master and release workflows - Added
macos-15runner to the build matrix - Updated the Xcode version selection condition to include
macos-14andmacos-15runners
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.github/workflows/build-and-test-workflow.yml |
Updated Xcode version selection condition to support macos-14 and macos-15 runners |
.github/workflows/build-and-test-release.yml |
Replaced macos-13 runner with macos-15 in the build matrix |
.github/workflows/build-and-test-feature-master.yml |
Replaced macos-13 runner with macos-15 in the build matrix |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
|
||
| - name: Set Xcode version | ||
| if: inputs.platform == 'macos-13' || inputs.platform == 'macos-13-xlarge' | ||
| if: inputs.platform == 'macos-13-xlarge' || inputs.platform == 'macos-14' || inputs.platform == 'macos-15' |
There was a problem hiding this comment.
If setting of the xcode version to 14.1 gets the macos 14 and 15 builds to complete then I guess this is good.
There was a problem hiding this comment.
this was already in there. just updated the checks to the correct version. this might change as part of GRIDEDIT-1971. but I'll see that when I get there.
ScottWillcox
requested review from
RStolkerDeltares
and removed request for
ahmad-el-sayed
|
|
||
| - name: Set Xcode version | ||
| if: inputs.platform == 'macos-13' || inputs.platform == 'macos-13-xlarge' | ||
| if: inputs.platform == 'macos-14' || inputs.platform == 'macos-15' |
There was a problem hiding this comment.
xcode version should probably be increased as well:
https://github.com/actions/runner-images/blob/main/images/macos/macos-14-Readme.md#xcode
https://github.com/actions/runner-images/blob/main/images/macos/macos-15-Readme.md#xcode
3 participants
note: this does not encompass fixing the builds for MacOS. that will be done in GRIDEDIT-1971.