Skip to content

Commit 52c06f0

Browse files
authored
Merge pull request #179 from DeployGate/fix/agp810support
Support Android Gradle Plugin 8.1.0
2 parents 47577ab + 17f59b8 commit 52c06f0

File tree

4 files changed

+24
-5
lines changed

4 files changed

+24
-5
lines changed

.github/workflows/build-and-test.yml

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,8 @@ jobs:
102102
- '7.2.0'
103103
- '7.3.0'
104104
- '7.4.0'
105-
- '8.0.0-beta04'
105+
- '8.0.0'
106+
- '8.1.0'
106107
include:
107108
- agp_version: '4.2.0'
108109
gradle_version: '6.7.1'
@@ -118,7 +119,11 @@ jobs:
118119
gradle_version: '7.4.2'
119120
- agp_version: '7.4.0'
120121
gradle_version: '7.5'
121-
- agp_version: '8.0.0-beta04'
122+
- agp_version: '8.0.0'
123+
gradle_version: '8.0'
124+
java_version: '17'
125+
runner_gradle_version: '8.0'
126+
- agp_version: '8.1.0'
122127
gradle_version: '8.0'
123128
java_version: '17'
124129
runner_gradle_version: '8.0'

run_acceptance_tests.bash

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,8 @@ done < <(cat<<EOF
1515
7.1.0 7.2
1616
7.2.0 7.3.3
1717
7.3.0 7.4.2
18-
7.4.0-rc02 7.5
19-
8.0.0-alpha10 7.5
18+
7.4.0 7.5
19+
8.0.0 8.0
20+
8.1.0 8.0
2021
EOF
2122
)

src/main/groovy/com/deploygate/gradle/plugins/artifacts/PackageAppTaskCompat.groovy

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
package com.deploygate.gradle.plugins.artifacts
22

3+
import com.deploygate.gradle.plugins.internal.agp.AndroidGradlePlugin
34
import groovy.transform.PackageScope
45
import org.jetbrains.annotations.NotNull
56

@@ -50,6 +51,10 @@ class PackageAppTaskCompat {
5051
}
5152

5253
static Collection<String> getApkNames(packageAppTask) {
53-
return packageAppTask.variantOutputs.get().collect { it.outputFileName.get() }
54+
if (AndroidGradlePlugin.hasOutputsHandlerApiOnPackageApplication()) {
55+
return packageAppTask.outputsHandler.get().getOutputs { true }.collect { it.outputFileName }
56+
} else {
57+
return packageAppTask.variantOutputs.get().collect { it.outputFileName.get() }
58+
}
5459
}
5560
}

src/main/groovy/com/deploygate/gradle/plugins/internal/agp/AndroidGradlePlugin.groovy

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,14 @@ class AndroidGradlePlugin {
3939
return AGP_VERSION
4040
}
4141

42+
/**
43+
* @since AGP 8.1.0 https://android.googlesource.com/platform/tools/base/+/da5cbdf59f91f7480a5d9615a20f766d19c6034a%5E%21/#F32
44+
*/
45+
static boolean hasOutputsHandlerApiOnPackageApplication() {
46+
def version = getVersion()
47+
return version.major >= 8 && version.minor >= 1
48+
}
49+
4250
@NotNull
4351
static String androidAssembleTaskName(@NotNull String variantName) {
4452
return "assemble${variantName.capitalize()}"

0 commit comments

Comments
 (0)