fix: onInitialization to wait for initialization to the complete and config received (#160)

Author: suthar26

android/src/main/kotlin/com/devcycle/devcycle_flutter_client_sdk/DevCycleFlutterClientSdkPlugin.kt

@@ -71,15 +71,18 @@ class DevCycleFlutterClientSdkPlugin: FlutterPlugin, MethodCallHandler {
 
         client.onInitialized(object : DevCycleCallback<String> {
           override fun onSuccess(result: String) {
+            args["isInitialized"] = true
             callFlutter("clientInitialized", args)
+            res.success(null)
           }
 
           override fun onError(t: Throwable) {
             args["error"] = t.message
+            args["isInitialized"] = false
             callFlutter("clientInitialized", args)
+            res.error("error", t.message, null)
           }
         })
-        res.success(null)
       }
       "identifyUser" -> {
         val user = getUserFromMap(call.argument("user")!!)
@@ -196,7 +199,11 @@ class DevCycleFlutterClientSdkPlugin: FlutterPlugin, MethodCallHandler {
     if (anonymous is Boolean) userBuilder.withIsAnonymous(anonymous)
 
     val userId = map["userId"] as? String
-    if (userId is String) userBuilder.withUserId(userId)
+    if (userId is String) {
+      android.util.Log.e("init", map["name"].toString());
+      userBuilder.withUserId(userId)
+      userBuilder.withIsAnonymous(false)
+    } else userBuilder.withIsAnonymous(true)
 
     val email = map["email"] as? String
     if (email is String) userBuilder.withEmail(email)

example/pubspec.yaml

@@ -4,10 +4,10 @@ version: 0.0.1
 
 # The following line prevents the package from being accidentally published to
 # pub.dev using `flutter pub publish`. This is preferred for private packages.
-publish_to: 'none' # Remove this line if you wish to publish to pub.dev
+publish_to: "none" # Remove this line if you wish to publish to pub.dev
 
 environment:
-  sdk: '>=2.14.0 <3.0.0'
+  sdk: ">=2.17.0 <3.0.0"
 
 # Dependencies specify other packages that your package needs in order to work.
 # To automatically upgrade your package dependencies to the latest versions
@@ -48,7 +48,6 @@ dev_dependencies:
 
 # The following section is specific to Flutter packages.
 flutter:
-
   # The following line ensures that the Material Icons font is
   # included with your application, so that you can use the icons in
   # the material Icons class.

ios/Classes/SwiftDevCycleFlutterClientSdkPlugin.swift

@@ -39,8 +39,10 @@ public class SwiftDevCycleFlutterClientSdkPlugin: NSObject, FlutterPlugin {
                     .user(dvcUser)
                     .options(getOptionsFromDict(dict: options ?? [:] ))
                     .build(onInitialized: { error in
+                        callbackArgs["isInitialized"] = true
                         if (error != nil) {
                             callbackArgs["error"] = "\(String(describing: error))"
+                            callbackArgs["isInitialized"] = false
                         }
                         self.channel.invokeMethod("clientInitialized", arguments: callbackArgs)
                     })

lib/devcycle_flutter_client_sdk.dart

@@ -2,6 +2,7 @@ import 'package:devcycle_flutter_client_sdk/devcycle_event.dart';
 import 'package:flutter/services.dart';
 import 'package:uuid/uuid.dart';
 import 'package:logger/logger.dart';
+import 'dart:async';
 
 import 'devcycle_flutter_client_sdk_platform_interface.dart';
 import 'devcycle_user.dart';
@@ -27,6 +28,9 @@ class DevCycleClient {
 
   Future<void>? _clientReady;
 
+  bool _isInitialized = false;
+  Completer<void>? _initializationCompleter;
+
   /// Callback triggered on client initialization
   ErrorCallback? _clientInitializedCallback;
   // Map of variable keys to a list of variable objects, used to update variable values
@@ -61,9 +65,14 @@ class DevCycleClient {
 
     switch (call.method) {
       case 'clientInitialized':
+        _isInitialized = call.arguments['isInitialized'];
         if (_clientInitializedCallback != null) {
           _clientInitializedCallback!(error);
         }
+        // Complete the initialization
+        if (_isInitialized) {
+          _initializationCompleter?.complete();
+        }
         break;
       case 'variableUpdated':
         final key = call.arguments['key'];
@@ -128,8 +137,13 @@ class DevCycleClient {
     }
   }
 
-  DevCycleClient onInitialized(ErrorCallback callback) {
+  Future<DevCycleClient> onInitialized(ErrorCallback callback) async {
     _clientInitializedCallback = callback;
+    _initializationCompleter = Completer<void>();
+
+    // Wait for the initialization to complete
+    await _initializationCompleter?.future;
+
     return this;
   }
 
@@ -138,7 +152,8 @@ class DevCycleClient {
     return DevCycleFlutterClientSdkPlatform.instance.getPlatformVersion();
   }
 
-  Future<void> identifyUser(DevCycleUser user, [VariablesCallback? callback]) async {
+  Future<void> identifyUser(DevCycleUser user,
+      [VariablesCallback? callback]) async {
     await _clientReady;
     if (callback != null) {
       String callbackId = _uuid.v4();
@@ -244,4 +259,4 @@ class DevCycleClientBuilder {
 }
 
 @Deprecated('Use DevCycleClientBuilder instead')
-typedef DVCClientBuilder = DevCycleClientBuilder;
+typedef DVCClientBuilder = DevCycleClientBuilder;