User model conversion and tests

Author: JamieSinn

Gemfile

@@ -15,3 +15,5 @@ group :development, :test do
   gem 'pry-byebug'
   gem 'rubocop', '~> 1.57.1'
 end
+
+gem "openfeature-sdk", "~> 0.4.0"

lib/devcycle-ruby-server-sdk.rb

@@ -27,6 +27,7 @@
 
 # APIs
 require 'devcycle-ruby-server-sdk/api/client'
+require 'devcycle-ruby-server-sdk/api/dev_cycle_provider'
 
 require 'devcycle-ruby-server-sdk/localbucketing/options'
 require 'devcycle-ruby-server-sdk/localbucketing/local_bucketing'

lib/devcycle-ruby-server-sdk/api/client.rb

@@ -3,6 +3,7 @@
 
 module DevCycle
   class Client
+    attr_reader :open_feature_provider
     def initialize(sdkKey, dvc_options = Options.new, wait_for_init = false)
       if sdkKey.nil?
         raise ArgumentError.new('Missing SDK key!')
@@ -26,11 +27,6 @@ def initialize(sdkKey, dvc_options = Options.new, wait_for_init = false)
       @open_feature_provider = DevCycleProvider.new(self)
     end
 
-
-    def get_open_feature_provider
-      return @open_feature_provider
-    end
-
     def close
       if @dvc_options.enable_cloud_bucketing
         @logger.info("Cloud Bucketing does not require closing.")

lib/devcycle-ruby-server-sdk/api/dev_cycle_provider.rb

@@ -1,41 +1,95 @@
 # frozen_string_literal: true
 
-class DevCycleProvider
+module DevCycle
+  class Provider
+    def initialize(client)
+      unless client.is_a?(DevCycleClient) do
+        fail ArgumentError('Client must be an instance of DevCycleClient')
+      end
+        @client = client
+      end
+    end
 
-  def initialize(client)
-    @client = client
-  end
-  def init
-    # We handle all initialization on the DVC Client itself
-  end
+    def init
+      # We handle all initialization on the DVC Client itself
+    end
 
-  def shutdown
-    @client.close()
-  end
+    def shutdown
+      @client.close
+    end
 
-  def fetch_boolean_value(flag_key:, default_value:, evaluation_context: nil)
+    def fetch_boolean_value(flag_key:, default_value:, evaluation_context: nil) end
 
-  end
+    def fetch_string_value(flag_key:, default_value:, evaluation_context: nil)
+      # Retrieve a string value from provider source
+    end
 
-  def fetch_string_value(flag_key:, default_value:, evaluation_context: nil)
-    # Retrieve a string value from provider source
-  end
+    def fetch_number_value(flag_key:, default_value:, evaluation_context: nil)
+      # Retrieve a numeric value from provider source
+    end
 
-  def fetch_number_value(flag_key:, default_value:, evaluation_context: nil)
-    # Retrieve a numeric value from provider source
-  end
+    def fetch_integer_value(flag_key:, default_value:, evaluation_context: nil)
+      # Retrieve a integer value from provider source
+    end
 
-  def fetch_integer_value(flag_key:, default_value:, evaluation_context: nil)
-    # Retrieve a integer value from provider source
-  end
+    def fetch_float_value(flag_key:, default_value:, evaluation_context: nil)
+      # Retrieve a float value from provider source
+    end
 
-  def fetch_float_value(flag_key:, default_value:, evaluation_context: nil)
-    # Retrieve a float value from provider source
-  end
+    def fetch_object_value(flag_key:, default_value:, evaluation_context: nil)
+      # Retrieve a hash value from provider source
+    end
 
-  def fetch_object_value(flag_key:, default_value:, evaluation_context: nil)
-    # Retrieve a hash value from provider source
+    def self.user_from_openfeature_context(context)
+      unless context.is_a?(OpenFeature::SDK::EvaluationContext)
+        raise ArgumentError, "Invalid context type, expected OpenFeature::SDK::EvaluationContext but got #{context.class}"
+      end
+      args = {}
+      if context.field('user_id')
+        args.merge!(user_id: context.field('user_id'))
+      elsif context.field('targeting_key')
+        args.merge!(user_id: context.field('targeting_key'))
+      end
+      customData = {}
+      privateCustomData = {}
+      context.fields.each do |field, value|
+        if field === 'user_id' || field === 'targeting_key'
+          next
+        end
+        case field
+        when 'email'
+          args.merge!(email: value)
+        when 'name'
+          args.merge!(name: value)
+        when 'language'
+          args.merge!(language: value)
+        when 'country'
+          args.merge!(country: value)
+        when 'appVersion'
+          if value.is_a?(String)
+            args.merge!(appVersion: value)
+          end
+          next
+        when 'appBuild'
+          if value.is_a?(Numeric)
+            args.merge!(appBuild: value)
+          end
+        when 'customData'
+          if value.is_a?(Hash)
+            customData.merge!(value)
+          end
+          next
+        when 'privateCustomData'
+          if value.is_a?(Hash)
+            privateCustomData.merge!(value)
+          end
+        else
+          customData.merge!(field => value)
+        end
+      end
+      args.merge!(customData: customData)
+      args.merge!(privateCustomData: privateCustomData)
+      User.new(**args)
+    end
   end
-
-
 end

lib/devcycle-ruby-server-sdk/models/user.rb

@@ -13,6 +13,7 @@
 require 'date'
 require 'time'
 require 'oj'
+require 'open_feature/sdk'
 
 module DevCycle
   class User

spec/devcycle_provider_spec.rb

@@ -0,0 +1,76 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+context 'user_from_openfeature_context' do
+  context 'user_id' do
+
+    it 'returns a user with the user_id from the context' do
+      context = OpenFeature::SDK::EvaluationContext.new(user_id: 'user_id')
+      user = DevCycle::Provider.user_from_openfeature_context(context)
+      expect(user.user_id).to eq('user_id')
+    end
+
+    it 'returns a user with the targeting_key from the context' do
+      context = OpenFeature::SDK::EvaluationContext.new(targeting_key: 'targeting_key')
+      user = DevCycle::Provider.user_from_openfeature_context(context)
+      expect(user.user_id).to eq('targeting_key')
+    end
+  end
+  context 'email' do
+    it 'returns a user with a valid user_id and email' do
+      context = OpenFeature::SDK::EvaluationContext.new(user_id: 'user_id', email: 'email')
+      user = DevCycle::Provider.user_from_openfeature_context(context)
+      expect(user.user_id).to eq('user_id')
+      expect(user.email).to eq('email')
+    end
+    it 'returns a user with a valid targeting_key and email' do
+      context = OpenFeature::SDK::EvaluationContext.new(targeting_key: 'targeting_key', email: 'email')
+      user = DevCycle::Provider.user_from_openfeature_context(context)
+      expect(user.user_id).to eq('targeting_key')
+      expect(user.email).to eq('email')
+    end
+  end
+
+  context 'customData' do
+    it 'returns a user with customData' do
+      context = OpenFeature::SDK::EvaluationContext.new(user_id: 'user_id', customData: { 'key' => 'value' })
+      user = DevCycle::Provider.user_from_openfeature_context(context)
+      expect(user.user_id).to eq('user_id')
+      expect(user.customData).to eq({ 'key' => 'value' })
+    end
+  end
+
+  context 'privateCustomData' do
+    it 'returns a user with privateCustomData' do
+      context = OpenFeature::SDK::EvaluationContext.new(user_id: 'user_id', privateCustomData: { 'key' => 'value' })
+      user = DevCycle::Provider.user_from_openfeature_context(context)
+      expect(user.user_id).to eq('user_id')
+      expect(user.privateCustomData).to eq({ 'key' => 'value' })
+    end
+  end
+
+  context 'appVersion' do
+    it 'returns a user with appVersion' do
+      context = OpenFeature::SDK::EvaluationContext.new(user_id: 'user_id', appVersion: '1.0.0')
+      user = DevCycle::Provider.user_from_openfeature_context(context)
+      expect(user.user_id).to eq('user_id')
+      expect(user.appVersion).to eq('1.0.0')
+    end
+
+    it 'returns a user with appBuild' do
+      context = OpenFeature::SDK::EvaluationContext.new(user_id: 'user_id', appBuild: 1)
+      user = DevCycle::Provider.user_from_openfeature_context(context)
+      expect(user.user_id).to eq('user_id')
+      expect(user.appBuild).to eq(1)
+    end
+  end
+  context 'randomFields' do
+    it 'returns a user with customData fields mapped to any non-standard fields' do
+      context = OpenFeature::SDK::EvaluationContext.new(user_id: 'user_id', randomField: 'value')
+      user = DevCycle::Provider.user_from_openfeature_context(context)
+      expect(user.user_id).to eq('user_id')
+      expect(user.customData).to eq({ 'randomField' => 'value' })
+    end
+  end
+end