Skip to content

Commit fe342cb

Browse files
author
devsh
committed
yes the callback always needs to be reset, but only if there's a transfer intended submit
1 parent 9b340a4 commit fe342cb

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

src/nbl/video/utilities/CAssetConverter.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5344,7 +5344,8 @@ ISemaphore::future_t<IQueue::RESULT> CAssetConverter::convert_impl(SReserveResul
53445344
retval.set({params.transfer->scratchSemaphore.semaphore,params.transfer->scratchSemaphore.value});
53455345
}
53465346
// reset original callback
5347-
params.transfer->overflowCallback = std::move(origXferStallCallback);
5347+
if (params.transfer)
5348+
params.transfer->overflowCallback = std::move(origXferStallCallback);
53485349

53495350
// Its too dangerous to leave an Intended Transfer Submit hanging around that needs to be submitted for Compute to make forward progress outside of this utility,
53505351
// and doing transfer-signals-after-compute-wait timeline sema tricks are not and option because:

0 commit comments

Comments
 (0)