Focusout for Dropdown, Menubar and ContextMenu #22
+205
−66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe we need something similar for menubar |
|
One main drawback for this is, to make accessibility work with this. I am not sure if we should go ahead with funtionality or accessibility. Until we find the sweet spot |
wheregmis
changed the title
|
When I serve this branch locally, I'm not able to interact with any of the buttons in the context menu dropdown. I'm guessing because when you click the button, the div loses focus? Screen.Recording.2025-06-02.at.4.17.41.PM.mov |
This reverts commit a8e41a2.
|
Thank you @ealmloff for pointing it out. Looks like inert was making it not work for some reason. But we can leave it commented for now. Should be okay now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt for #18 & #28