Skip to content

dx check fail because it check every crate at the .cargo folder #3751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
LuckyTurtleDev opened this issue Feb 16, 2025 · 1 comment · Fixed by #4038
Closed

dx check fail because it check every crate at the .cargo folder #3751

LuckyTurtleDev opened this issue Feb 16, 2025 · 1 comment · Fixed by #4038
Labels
bug Something isn't working cli Related to the dioxus-cli program good first issue Good for newcomers

Comments

@LuckyTurtleDev
Copy link

Problem

My $CARGO_HOME is set to the project dir + .cargo.
Dx check also this folder and fail.
Steps To Reproduce

Steps to reproduce the behavior:

  • set $CARGO_HOMEto prosect dir +.cargo`
  • depend at thiserror-impl-1.0.69
  • execute dx check

Expected behavior
Do only check the file which are included in the rust src and ignore dependencies.

Screenshots

Environment:

  • Dioxus version: dioxus 0.6.3 (was built without git repository)
  • Rust version: rustc 1.84.1 (e71f9a9a9 2025-01-27)
  • OS info: arch linux
  • App platform: web

Questionnaire
@LuckyTurtleDev LuckyTurtleDev added the bug Something isn't working label Feb 16, 2025
@ealmloff
Copy link
Member

dx check should ignore files in your .gitignore like dx fmt does today. We need to change this method that collects the files to check to use this method from the auto formatter command that respects your gitignore

@ealmloff ealmloff added good first issue Good for newcomers cli Related to the dioxus-cli program labels Feb 24, 2025
@ealmloff ealmloff mentioned this issue Apr 18, 2025
Open
SilentVoid13 added a commit to SilentVoid13/dioxus that referenced this issue Apr 24, 2025
@SilentVoid13
fix: dx check now respects files to ignore (e.g. .gitignore)
2426f74 
closes DioxusLabs#3751
@SilentVoid13 SilentVoid13 mentioned this issue Apr 24, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working cli Related to the dioxus-cli program good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: dx check now respects files to ignore (e.g. .gitignore) SilentVoid13/dioxus
2 participants
@LuckyTurtleDev @ealmloff