Skip to content

fix: dx check now respects files to ignore (e.g. .gitignore) #4038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 25, 2025
Merged

fix: dx check now respects files to ignore (e.g. .gitignore) #4038

merged 1 commit into from
Apr 25, 2025

Conversation

SilentVoid13
Copy link
Contributor

this should fix #3751. basically does what @ealmloff suggested, using the same function to collect .rs files for both dx check and dx fmt

@SilentVoid13 SilentVoid13 requested a review from a team as a code owner April 24, 2025 13:18
ealmloff
ealmloff approved these changes Apr 25, 2025
View reviewed changes
Copy link
Member

@ealmloff ealmloff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Confirmed this fixes the git ignore issue and it is nice to unify some of the file collection logic. The CI failure is unrelated

@ealmloff ealmloff merged commit 74789c4 into DioxusLabs:main Apr 25, 2025
16 of 17 checks passed
@ealmloff ealmloff added bug Something isn't working cli Related to the dioxus-cli program labels Apr 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ealmloff ealmloff ealmloff approved these changes

Assignees
No one assigned
Labels
bug Something isn't working cli Related to the dioxus-cli program
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dx check fail because it check every crate at the .cargo folder
2 participants
@SilentVoid13 @ealmloff