Optionally ignore the TabControl keybindings, which blocks some keybindings from inner elements. #508
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WPF's
TabControlaggressively captures keybindings, even if the focus is on inner elements within an AvalonDockDocumentPane.This was an issue that popped up when I added a code editor as a Document within AvalonDock. Where I noticed the
HomeandEndkeys, were not captured by the code editor, but instead switched between the first and lastTabControlitems.This can be bypassed by overriding the
OnKeyDownevent on an element that uses the TabControl and not calling thebase.OnKeyDownfunction of the baseTabControl.This is well explained in this blogpost.
I could not find a way to do this without editing AvalonDock, as it must be set on one of the elements that are derived from
TabControl.I've added a property to ignore these key bindings (
IgnoreTabControlKeyBindings), which is disabled by default, so not to affect any AvalonDock users. Personally, I wouldn't mind if this is always ignored, as I've never realizedTabControlhad these keybindings anyway, and I find its usefulness minimal at best.It would be fantastic if this could be merged with the AvalonDock with any changes you deem necessary to fit into this codebase.
Thank you.
Example:
