Remove naming-convention eslint-disable comments from apps/roam#1064
Merged
Conversation
- Removed all /* eslint-disable @typescript-eslint/naming-convention */ comments - Removed all // eslint-disable-next-line @typescript-eslint/naming-convention comments - Removed all // eslint-disable-line @typescript-eslint/naming-convention comments - No new lint warnings introduced - relaxed naming rules from ENG-1777 are working correctly Relates to ENG-1779
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
Contributor
PR size/scope checkThis PR is over our review-size guideline.
Please split this into smaller PRs unless there is a clear reason the changes need to land together. If keeping it as one PR, please add a brief justification covering:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes all
@typescript-eslint/naming-conventioneslint-disable comments from theapps/roamdirectory, following the relaxed naming-convention rules introduced in ENG-1777.Changes
/* eslint-disable @typescript-eslint/naming-convention */block comments// eslint-disable-next-line @typescript-eslint/naming-conventioninline comments// eslint-disable-line @typescript-eslint/naming-conventionend-of-line commentsTesting
pnpm lint- all checks passed with exit code 0Related Issues
Linear Issue: ENG-1779