-
Couldn't load subscription status.
- Fork 145
build: add direct dependency on yarl #1462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
| dependencies = [ | ||
| "aiohttp>=3.7.0,<4.0", | ||
| "typing-extensions>=4.1", | ||
| "yarl>=1.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "yarl>=1.0", | |
| "yarl~=1.0", |
Hm, I'd really prefer not to have unbounded versions in the main dependencies unless absolutely necessary; there's always a risk (even if it's a tiny risk) of something breaking from one day to the next, in which case we'd have to issue emergency bugfix releases. Even aiohttp itself has >= 1.17.0, < 2.0 bounds for yarl: https://github.com/aio-libs/aiohttp/blob/0a840daecb59264a37421e7ba37810f4d6ffc931/setup.cfg#L9C8-L9C24
We've had downstream (dev) dependency breakages before, where one of our dependencies had no upper bound on another dependency and broke as a result of it (eg. pdm and twine with importlib-metadata)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But if we overly lock, then we need to submit emergency fixes to allow newer versions.
close #1459