Rename FragmentStateAdapter usages #1014
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TacoTheDank
force-pushed
the
renameStateAdapters
branch
from
ba36ad3 to
0d5f96a
Compare
TacoTheDank
force-pushed
the
renameStateAdapters
branch
from
0d5f96a to
f800a10
Compare
Owner
|
Thank you. But why? |
Contributor
Author
|
Because they all had the same name, which is quite confusing. Also, they were no longer pagerAdapters, but stateAdapters. Keeping them named as pagerAdapters would also be confusing. |
Collaborator
|
Yes that is understandable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They were all named the same, so I renamed them to be specific to each activity.