Skip to content

Conversation

jacobo-doist
Copy link
Contributor

  • This covers:
  • Docs
  • Github Actions (test, build, publish)
  • Pre-commit checks

It also modernises the pyproject.toml (which includes removing license classifiers, which are deprecated)

Builds on top of a previous PR: #77 , which is why it contains those license changes.

Pushing early for review but leaving as draft as I want to merge the license PR first.

@jacobo-doist
Copy link
Contributor Author

@goncalossilva, you've done a few of these. It would be great to get your eyes on this one.

Copy link
Member

@goncalossilva goncalossilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

"RUF002", # ambiguous-unicode-character-docstring
"RUF003", # ambiguous-unicode-character-comment
"RUF012", # mutable-class-default
"RUF200", # invalid-pyproject-toml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need this? Why?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Helps prevent regressions. I also hope that it keeps us with a valid pyproject.toml as the spec changes but this file may not.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does it help prevent regressions? This is in the ignore list, which I presume means it's disabled. It was like this because Poetry is not fully PEP 621 compliant but uv is, so we might be able to enable it (ie. remove this line).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're absolutely right.

Now AI has made this sentence comedy but I mean it.

I'll queue this with a few other minor improvements. I wanted to get the release out to prevent the security alert in any projects that use bitmapist.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤣

@jacobo-doist jacobo-doist marked this pull request as ready for review September 11, 2025 15:37
@jacobo-doist jacobo-doist merged commit 04494e6 into main Sep 12, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants