-
Notifications
You must be signed in to change notification settings - Fork 78
Migrate from poetry to uv #78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
BSD is not enough to specify the license under which the software is released. This change specifies the license to be the 3-clause BSD license.
This commit contains the result of running uvx migrate-to-uv With no additional changes.
@goncalossilva, you've done a few of these. It would be great to get your eyes on this one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
"RUF002", # ambiguous-unicode-character-docstring | ||
"RUF003", # ambiguous-unicode-character-comment | ||
"RUF012", # mutable-class-default | ||
"RUF200", # invalid-pyproject-toml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we still need this? Why?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Helps prevent regressions. I also hope that it keeps us with a valid pyproject.toml as the spec changes but this file may not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does it help prevent regressions? This is in the ignore list, which I presume means it's disabled. It was like this because Poetry is not fully PEP 621 compliant but uv is, so we might be able to enable it (ie. remove this line).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're absolutely right.
Now AI has made this sentence comedy but I mean it.
I'll queue this with a few other minor improvements. I wanted to get the release out to prevent the security alert in any projects that use bitmapist.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤣
Co-authored-by: Gonçalo Silva <goncalo@doist.com>
It also modernises the
pyproject.toml
(which includes removing license classifiers, which are deprecated)Builds on top of a previous PR: #77 , which is why it contains those license changes.
Pushing early for review but leaving as draft as I want to merge the license PR first.